From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1D3C2D0A3 for ; Thu, 29 Oct 2020 23:00:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A165120838 for ; Thu, 29 Oct 2020 23:00:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WQnPoyxn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WOGW8yuk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A165120838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JYaQRVU2Mu37cz8lV0TtynWXr/tbTVy31CqEsMiQhXA=; b=WQnPoyxnPHE6PlmXQYXq1Lhoc AXc+VBJW9o51mY2gtMr8MupOAxwRyKb5AAhgsgXJ0H338yMYyahkbA4Q3bOQDr7WfAzBlgnfb5ZUW h01nVENUc7w0uUFMsszGwpqsSLGxud4l2yYu6gbfYPYdK609hgPIMbAeGNGg323pO401PF2wJxpXN 1AdU0Qwv+Nidu8HeyQxTMo74+Nt4xwqU8f27Z9H/KKRavGzdu0jSGiCi45PsAKLC+sM5fF6yrkEXf jT+sM86gt+xUZtoYYFeeZtujAeqRipMwzXfm8tKYQoFelapktT3u9YwzqivpuZNe3Xz9so8OjNqjy HstOZu4YA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYGtn-00040j-8y; Thu, 29 Oct 2020 23:00:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYGtj-0003z5-Lz for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 23:00:00 +0000 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A68D12076D for ; Thu, 29 Oct 2020 22:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604012398; bh=Se6qLVzzUFZC91uGHHJ6eKR+vvUt7P/gseRVBZUDyqI=; h=References:In-Reply-To:From:Date:Subject:To:List-Id:Cc:From; b=WOGW8yukN9Gj14wXJYKr3VwHWDJDcGU6L3Mcjb+Qi0IyD+aGs8rbF/dC+edM96PRF WOqHF6hRICPGpwAFeTXunvX3thTQ/Rh/+/MRzeuKSvjRWvh/rAbVxdUHFC+wRTQMrK E+7zJDXOEF+ybR4Ad6l65qjJga9YL8i/8kjB81r4= Received: by mail-oi1-f182.google.com with SMTP id j7so4745717oie.12 for ; Thu, 29 Oct 2020 15:59:58 -0700 (PDT) X-Gm-Message-State: AOAM531SN9pqaoIR+YAPgi/1WGubHMj9/1M5Hu9jEIoz8J+NLMTlyPlL R8Rbhk67bqnNtlLRbny6xV/CoubuuhYbmkhAPEc= X-Google-Smtp-Source: ABdhPJwrLTshpBn09wgTqfh1yOgdCsen/fpUqIbC1hVLvFlypGdY4DfsVA0vYyM85K8beNdtKoDrtM2RAUKao4UXy+E= X-Received: by 2002:aca:d64f:: with SMTP id n76mr1476734oig.174.1604012397866; Thu, 29 Oct 2020 15:59:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Thu, 29 Oct 2020 23:59:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Allwinner Fixes for 5.10 To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_185959_931860_12B56FF8 X-CRM114-Status: GOOD ( 37.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Ard Biesheuvel , Chen-Yu Tsai , Maxime Ripard , SoC Team , arm-soc , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Oct 2020 at 23:56, Arnd Bergmann wrote: > > On Thu, Oct 29, 2020 at 11:03 PM Ard Biesheuvel wrote: > > On Thu, 29 Oct 2020 at 22:41, Arnd Bergmann wrote: > > > On Thu, Oct 29, 2020 at 10:23 PM Arnd Bergmann wrote: > > > > On Thu, Oct 29, 2020 at 8:06 PM Maxime Ripard wrote: > > > > > > > > > > ---------------------------------------------------------------- > > > > > Mostly some fixes for a fallout in a PHY driver that pointed out errors > > > > > in our DTs. > > > > > > > > Can you clarify what this means for compatibility of the dtb files? > > > > > > > > I would assume that the modified .dts files all work on older kernels > > > > because you fix the setting, but at least some of them require > > > > the patch with newer kernels, right? > > > > > > > > Are they all broken without the change? Are other platforms > > > > likely to suffer the same problem? IIRC seems that at least > > > > the SynQuacer box had the same issue, but I don't yet > > > > understand how common the problem is. > > > > > > To clarify: I had pulled the branch already when I replied, but the > > > automated email for that apparently did not trigger. > > > > > > I would like to know the background here mainly so I can put > > > it into my pull request to Linus. > > > > > > > The Realtek PHY driver used to ignore the TX/RX delay settings implied > > by the xxx in the the different rgmii-xxx phy-mode settings, and a > > failed attempt was made in the v5.2 timeframe to change this, and so > > the -xxx part has been effectively ignored all this time, meaning you > > could get away with providing the wrong value. > > > > Even though no platform appears to have been affected by this > > incorrect patch, the followup fix that repairs it has been backported > > to -stable, breaking all the formerly working platforms incorporating > > this PHY that describe the mode as 'rgmii' instead of 'rgmii-id'. I > > have argued that the backport of the followup fix should be reverted, > > given that there is a risk that production systems tracking a -stable > > release may be affected by this if they don't take their DT directly > > from the upstream kernel. > > > > I think this PR is fine, though - fixing the DTs going forward is > > needed in any case (although I think backporting DT changes to -stable > > is a bad idea but that is just my opinion) > > Hmm, that sounds much worse than I understood first. I think the > mainline driver needs to be patched back to restore the previous > behavior, and that backported to stable kernels if they are already > broken by the backport. > > While I had already pulled these fixes, I'm dropping them now. > It should have been clear that this kind of driver change is not > acceptable. > This is what Ilias and I tried to argue [0] earlier today, but Andrew has a different view. [0] https://lore.kernel.org/netdev/CAMj1kXGQDeOGj+2+tMnPhjoPJRX+eTh8-94yaH_bGwDATL7pkg@mail.gmail.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel