All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Marc Zyngier <maz@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Android Kernel Team <kernel-team@android.com>,
	Russell King <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: cache-v7: get rid of mini-stack
Date: Tue, 9 Feb 2021 23:37:35 +0100	[thread overview]
Message-ID: <CAMj1kXHr7E=Sh9uuAe6+CHbzK_q0tVpXYte3Qwqcui9Gy5_JYA@mail.gmail.com> (raw)
In-Reply-To: <8p7s4319-4rpo-9s8r-rq61-52rqsn49s735@syhkavp.arg>

On Tue, 9 Feb 2021 at 00:08, Nicolas Pitre <nico@fluxnic.net> wrote:
>
> On Mon, 8 Feb 2021, Ard Biesheuvel wrote:
>
> > @@ -549,16 +555,6 @@ __errata_finish:
> >   THUMB(      orr     r0, r0, #1 << 30        )       @ Thumb exceptions
> >       ret     lr                              @ return to head.S:__ret
> >
> > -     .align  2
> > -__v7_setup_stack_ptr:
> > -     .word   PHYS_RELATIVE(__v7_setup_stack, .)
> > -ENDPROC(__v7_setup)
> > -
> > -     .bss
> > -     .align  2
> > -__v7_setup_stack:
> > -     .space  4 * 7                           @ 7 registers
> > -
> >       __INITDATA
>
> You should have preserved the ENDPROC here.
>

Indeed. Will fix that in v2.

Thanks,
Ard.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-09 22:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 22:49 [PATCH 0/3] ARM: v7: get rid of boot time mini stack Ard Biesheuvel
2021-02-08 22:49 ` [PATCH 1/3] ARM: cache-v7: add missing ISB after cache level selection Ard Biesheuvel
2021-02-08 22:49 ` [PATCH 2/3] ARM: cache-v7: refactor v7_invalidate_l1 to avoid clobbering r5/r6 Ard Biesheuvel
2021-02-08 22:49 ` [PATCH 3/3] ARM: cache-v7: get rid of mini-stack Ard Biesheuvel
2021-02-08 23:07   ` Nicolas Pitre
2021-02-09 22:37     ` Ard Biesheuvel [this message]
2021-02-08 23:11 ` [PATCH 0/3] ARM: v7: get rid of boot time mini stack Nicolas Pitre
2021-02-09 22:37   ` Ard Biesheuvel
2021-02-09 22:59     ` Nicolas Pitre
2021-02-09 23:02       ` Ard Biesheuvel
2021-02-09 23:22         ` Nicolas Pitre
2021-02-10 17:39           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXHr7E=Sh9uuAe6+CHbzK_q0tVpXYte3Qwqcui9Gy5_JYA@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=maz@kernel.org \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.