Re: [openembedded-core][PATCH] kernel.bbclass: do not deploy fitImage; kernel-fitimage.bbclass does that.

[Leon Woestenberg <leon@sidebranch.com>]

Hi Andre,

thanks for reviewing.

On Sat, Sep 8, 2018 at 12:10 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Thu, Sep 6, 2018 at 2:06 PM, Leon Woestenberg <leon@sidebranch.com> wrote:
>> +               if [ "$imageType" != "fitImage" ]; then
>> +                       for imageType in ${KERNEL_IMAGETYPES} ; do
>
> This looks odd. You test imageType before the for loop which assigns a
> value to it?
>
Good catch. I will create new patch that turns the lines around, i.e.
test within the for loop

(The above acted on the last imageType of the previous for loop, which
had the correct order.)

>> +                               initramfs_base_name=${imageType}-${INITRAMFS_NAME}
>> +                               initramfs_symlink_name=${imageType}-${INITRAMFS_LINK_NAME}
>> +                               install -m 0644 ${KERNEL_OUTPUT_DIR}/${imageType}.initramfs $deployDir/${initramfs_base_name}.bin
>> +                               ln -sf ${initramfs_base_name}.bin $deployDir/${initramfs_symlink_name}.bin
>> +                       done
>> +               fi
>>         fi
>>  }
>>  do_deploy[cleandirs] = "${DEPLOYDIR}"

Thanks,

Leon.