From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D5F91BC3F for ; Sat, 11 May 2024 18:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715453261; cv=none; b=VJSb1OAVO1yFTs3inJq0uWE09LUN5qqRN5qMj5OhJSiJDuVsp83XTFSXifuHMLXXOHrbUJHAvvb+EtI/C1/rmXsV3tdDqw/EDdME9h2GhkLnTQpLbacVO8UAS8Iv+Qo6jtI71aeTgug4FvBejnZnuQR6fxfeM//LRqEd8e1rx3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715453261; c=relaxed/simple; bh=YVOdlFgTphP8iWkdNlurQhMrD26ZChBnbBkDzPU2aRQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tArfKUfsNz6pf9hJnoxqxyX5MWwnAqHH/b9KX02L84vil/ZiSd+8NmPK5UWNpRnRpBzb2G8iC9TtsPqs5cYvQLt4twhq57/7QV2s0u7eyo7BrXkOI1q8LGglIhdm8xonPauTmkSFcq4+23ysrnDzVaI4KVvpqsXPcRfxoZ8IPkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=eB1FrXnt; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="eB1FrXnt" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2e09138a2b1so40036041fa.3 for ; Sat, 11 May 2024 11:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1715453257; x=1716058057; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BuJ6CwAMNvaLdIW7Ij5QqE6r9837KCVxY1U3dFFJNyg=; b=eB1FrXntt7AkMenK4PFJm4pXaF5r1aCXKaSCX5JwUGYlnJmtgF/kvQCgh12+GRQYxs qKcGi1e/5UoFNKdpyEPHinAA2bpW8R4aSZksR3DmedxVtJ6mbDYjO2wvEZUTG6+V58rz SLKVsQbdHBahcm+48cEISh9SRGl14/IcMl2KgkFpJ/DtLR9nVj8BVd4x2DjpOV60RxJH F+r0zgVC6CujqiOqvvrTLSh0PsGbvRespqro2SzMrWw9xjGCYLaTWXM28caBxMmtiSaE 9dHAQhmKv7rH1c803ETD6QR1CizD+PdKhmKvRZgbXQ9ngaCcfu0PCvuIwscr07x5x5Mo oHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715453257; x=1716058057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BuJ6CwAMNvaLdIW7Ij5QqE6r9837KCVxY1U3dFFJNyg=; b=bAFdGSdljklmJhZDnNtL4KVRHxXBNxVKbnT67tMc/NomuY7T2qQakWs/GVdqfjw1Ht LiGpEEv92zmOxl4GEdZhY2966VNfdMn8YKQ42HYlzYujEmGV7JVrpDr+W6jbuGLEmN3+ 7N4eOnDMIIW/WXQhM9kEirIHrvPUhy5ATbFmmdZ5GpXhy/v6/ExlwNGauzeM2PXwrxFZ 2nxXpIOphzbLQHbBDlJswE6wYmNaJYxixmSkZv6AW0SiwGKphpmfNc5ju/AwY+xCtHx4 ++I39QiihY2kxRhtXqHLxwsuFyWqWdKxQUq2buzl/JtQ/tcrkAxO8P0UyDPnJZo+gnXK cPsA== X-Forwarded-Encrypted: i=1; AJvYcCWhDfNyN+jJIykD7p9jOAnc1//As0DjGf0fX45IgyXj/C1c8uPb+3GblHddMqGwkwJadzopzjHcK/oPDsmlFqv9uGXvzWKsls1n01H8 X-Gm-Message-State: AOJu0Yyul6xk+ZZ3m1/Hez4j+qrXSatRVwPL5Pk2u+y/AQjVMtK1tUru 0xm8sRFI0cOfwKFYbOdCFBy0xiFAuyouImfqXxoNsDcYIwgNfZ66HPJOXm0Yb8szKG1SZo8F5r3 2p9YcGLx+NA/0CJ9eNpk9ynrlo1xNPwyJXiy8Pg== X-Google-Smtp-Source: AGHT+IGj8EW8cP9HdJkRuf6X8EYKSYb8VGuoFRypZ4xZxIbbcBdpQwwEMt4n9/cs066lBCUiOGPepJWdPvsEQNjXQss= X-Received: by 2002:a2e:8794:0:b0:2d8:34ec:54e6 with SMTP id 38308e7fff4ca-2e5204ccd8fmr33387821fa.33.1715453257450; Sat, 11 May 2024 11:47:37 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240510064053.278257-1-Mariel.Tinaco@analog.com> <20240510064053.278257-2-Mariel.Tinaco@analog.com> <20240511172500.718fe12d@jic23-huawei> In-Reply-To: <20240511172500.718fe12d@jic23-huawei> From: David Lechner Date: Sat, 11 May 2024 13:47:26 -0500 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: iio: dac: add docs for ad8460 To: Jonathan Cameron Cc: Mariel Tinaco , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Michael Hennerich , Marcelo Schmitt , Dimitri Fedrau , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 11, 2024 at 11:25=E2=80=AFAM Jonathan Cameron wrote: > > On Fri, 10 May 2024 12:28:19 -0500 > David Lechner wrote: > > > On Fri, May 10, 2024 at 1:42=E2=80=AFAM Mariel Tinaco wrote: > > > > > > This adds the bindings documentation for the 14-bit > > > High Voltage, High Current, Waveform Generator > > > Digital-to-Analog converter. > > > > > > Signed-off-by: Mariel Tinaco > > > --- > > > .../bindings/iio/dac/adi,ad8460.yaml | 67 +++++++++++++++++= ++ > > > MAINTAINERS | 7 ++ > > > 2 files changed, 74 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad8= 460.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad8460.yam= l b/Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml > > > new file mode 100644 > > > index 000000000..924f76209 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml > > > @@ -0,0 +1,67 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +# Copyright 2024 Analog Devices Inc. > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad8460.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analog Devices AD8460 DAC > > > + > > > +maintainers: > > > + - Mariel Tinaco > > > + > > > +description: | > > > + Analog Devices AD8460 110 V High Voltage, 1 A High Current, > > > + Arbitrary Waveform Generator with Integrated 14-Bit High Speed DAC > > > + https://www.analog.com/media/en/technical-documentation/data-sheet= s/ad8460.pdf > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - adi,ad8460 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + spi-max-frequency: > > > + maximum: 20000000 > > > + > > > + vref-supply: > > > > It would be nice to make the property name match the pin name since > > there is more than one reference voltage input. > > > > refio-1p2v-supply: > > > > > + description: Drive voltage in the range of 1.2V maximum to as lo= w as > > > + low as 0.12V through the REF_IO pin to adjust full scale outpu= t span > > > > I don't seen anything in the datasheet named REF_IO. Is this a typo > > and it should be REFIO_1P2V? > > > > > + > > > + clocks: > > > + description: The clock for the DAC. This is the sync clock > > > + > > > + adi,rset-ohms: > > > + description: Specify value of external resistor connected to FS_= ADJ pin > > > + to establish internal HVDAC's reference current I_REF > > > + minimum: 2000 > > > + maximum: 20000 > > > + > > > > I see lots more pins on the datasheet, many of which should be trivial > > to add bindings for (we prefer to have the bindings as complete as > > possible even if the driver doesn't implement everything). Potential > > candidates: > > > > sdn-reset-gpios: (active high) > > reset-gpios: (active low) > > sdn-io-gpios: (active high) > > > > hvcc-supply: > > hvee-supply: > > vcc-5v-supply: > > vref-5v-supply: > > dvdd-3p3v-supply: > > avdd-3p3v-supply: > > > > It also looks like there is a parallel interface for data, so I would > > expect to see an io-backends property that links to the PHY used for > > handling that. > > > Ultimately yes, but the parallel interface might require some decisions o= n > binding that are non obvious until it's actually implemented. So maybe > don't need that bit from the start. The rest I agree should be here. > > Since the driver patch uses a DMA channel that isn't documented here, I am assuming that the parallel interface is being used so we do need to consider it now. :-)