From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B6BC43334 for ; Tue, 7 Jun 2022 00:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235494AbiFGAmm (ORCPT ); Mon, 6 Jun 2022 20:42:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232787AbiFGAmg (ORCPT ); Mon, 6 Jun 2022 20:42:36 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E84F12091 for ; Mon, 6 Jun 2022 17:42:35 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id d14so12929205wra.10 for ; Mon, 06 Jun 2022 17:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xrS17sEQ3fRPRqMXnMRDhd1tVPi2Vsh08gg2EBYpymM=; b=SandzrnngwOhRTb7pOv7vDUXRvqY6I+fX26+o4AE+4oTdmUbOSgFO7ZLB+rx1z3A/D xV9ISdzwufntSdxLAJVDSJSsY/g1ASXMr+GS9Ep8fv6saHUVZfAID5Y6sMpqLDrZ6+ri 8DnY1F8gCpDfLb3G9J0S3+A6EiWDuwMmOamclAsFTGps0qCe6xHs+s4QaTBeyZzhvvtd xs1nbZ0048cLZuV27n8vhLONuob2ISCzfsahl7H2WWuDMBdZvGFld2a0fq6RyDYfpi2n GM9dIiSUT1ll9rIbt5B9ToV1tMRPrwu7j/rrIe5zmemKTTII4nDov62UIwXsQSFMGmQ5 hf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xrS17sEQ3fRPRqMXnMRDhd1tVPi2Vsh08gg2EBYpymM=; b=kkHNFrl+I0FMbmhSQahXeh1cPnm//3VbdtJtT4l9ymF6vYqc5qU145RfrQwlNaE+I/ VYTgDZoyseFIla8yQ+VmxQ7k0nihnopjoInrCVtX3Ia99eQxrC1U4iczwrxwuJMkInkq 1D7mBkQXxup5H1go+PDVq13E5XWlFHfsBGV7sAgxef6b4Jlv1Wep2QLHJHi9G2HSOMxi +1vvpjdGqRdHSP+Qpi6xjVAVpHG4x8hx3ZfDavEKAsYyQwGfHe28KseQssM2514i8zCi 6d0cl+3Yi5wS4kEJuHw0U4wt3gZ21rmKTSX7/fjAIYUDI25PK62QJBLOyCkC56PJwERm TTwQ== X-Gm-Message-State: AOAM533R1Fhr/1vewjJJwvdSshEjxvGCaKO5PaiPjv/sbWAh+fh7JK+X y/7nGs61CyqMSWvM9S1d9lk3oW26KQ0QDV6DZxUicQ== X-Google-Smtp-Source: ABdhPJycltbOTsL7TkxiF885x5QthonQlvgpxJIZFOu+1GRjvPzN5Kl98cntZbpqNcd7ixaTx3UK+BqqMjFqf1qFZU4= X-Received: by 2002:a5d:4b10:0:b0:213:5e0:2c6c with SMTP id v16-20020a5d4b10000000b0021305e02c6cmr23787190wrq.126.1654562553942; Mon, 06 Jun 2022 17:42:33 -0700 (PDT) MIME-Version: 1.0 References: <20220519134204.5379-1-will@kernel.org> <20220519134204.5379-60-will@kernel.org> In-Reply-To: <20220519134204.5379-60-will@kernel.org> From: Peter Collingbourne Date: Mon, 6 Jun 2022 17:42:22 -0700 Message-ID: Subject: Re: [PATCH 59/89] KVM: arm64: Do not support MTE for protected VMs To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, May 19, 2022 at 7:40 AM Will Deacon wrote: > > From: Fuad Tabba > > Return an error (-EINVAL) if trying to enable MTE on a protected > vm. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/arm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 10e036bf06e3..8a1b4ba1dfa7 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -90,7 +90,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > break; > case KVM_CAP_ARM_MTE: > mutex_lock(&kvm->lock); > - if (!system_supports_mte() || kvm->created_vcpus) { > + if (!system_supports_mte() || > + kvm_vm_is_protected(kvm) || Should this check be added to kvm_vm_ioctl_check_extension() as well? Peter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55C23C433EF for ; Tue, 7 Jun 2022 00:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gx+9FxaCdzIw5AogcntovPGokVqOSgqw2MuVxzFTKOY=; b=SOdethbremw4tw 68yvz/z/mMcvqBNk3Chffcjc7Uw1w6L5zOdcpIdKtf7Cx61les5/Jq5om00xqWnHwvSbt/scXez16 0ZuDqpCg8Ph9lds+nzwpcGTGS3A8891p9UpOEiF77q8vC69e9+S5SP/3S2SYbVeuaplJ0a0Ciz4eu Hi8JP/91ycIaQEHAbTCwtrQMe8U/Np927e0hQ2V/b0mXy8CBgJWjFKPauOT3ECz+ofxp7Nd8qHUSF 33klfIYAPxXMDwd97e/5xJRZlox4WJwqRdUZ/cDj93SYCFeSlC+vKFnuOKQgkg40r3Fhg0y4hUBZc JC4ehrt+B1IYnyUPhrrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyNIt-003v9V-Ft; Tue, 07 Jun 2022 00:42:39 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyNIp-003v8d-KY for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 00:42:36 +0000 Received: by mail-wr1-x429.google.com with SMTP id q15so13888748wrc.11 for ; Mon, 06 Jun 2022 17:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xrS17sEQ3fRPRqMXnMRDhd1tVPi2Vsh08gg2EBYpymM=; b=SandzrnngwOhRTb7pOv7vDUXRvqY6I+fX26+o4AE+4oTdmUbOSgFO7ZLB+rx1z3A/D xV9ISdzwufntSdxLAJVDSJSsY/g1ASXMr+GS9Ep8fv6saHUVZfAID5Y6sMpqLDrZ6+ri 8DnY1F8gCpDfLb3G9J0S3+A6EiWDuwMmOamclAsFTGps0qCe6xHs+s4QaTBeyZzhvvtd xs1nbZ0048cLZuV27n8vhLONuob2ISCzfsahl7H2WWuDMBdZvGFld2a0fq6RyDYfpi2n GM9dIiSUT1ll9rIbt5B9ToV1tMRPrwu7j/rrIe5zmemKTTII4nDov62UIwXsQSFMGmQ5 hf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xrS17sEQ3fRPRqMXnMRDhd1tVPi2Vsh08gg2EBYpymM=; b=qUxqUaivuDjIM8+zeF8mzXBEGbvDlGmfDAO1aKvcLh6STd5bhvFXw2zSuSZGUOfvvG JKi4ORwwdyspzFd0AdHZFVaEjmEzUVaU93HPdIHwBGQMMnW//ppi9PAmZDGSYMDmmRSI gbeP1Iu42l2i0uwCQEp+gqr0VtBx5U9qw4P2XCR+12I5FMicglbYZc8HZ0c07ONbGLaT 8dCO5H4yxhkYeWEOvKljFdAiQTZPleWJOHt4ZvnOIjg6EojTQRVWVm+5XFDK4lQDoDBd azVVM3j3zUG+AK84J8x8aVQqKIM+OcB+Nosz1b/ggrupKeLOKRqRkRMHBPM0WTyySLUi EH8g== X-Gm-Message-State: AOAM530T9Urdj9yc2ZMXnm42A9NDpIEld3bNUTjDXxK+9rcIzyRidjh0 9AiqCpXYox0BCN+/QlKQtDu1uTeYJeg9dhOnGWx4nA== X-Google-Smtp-Source: ABdhPJycltbOTsL7TkxiF885x5QthonQlvgpxJIZFOu+1GRjvPzN5Kl98cntZbpqNcd7ixaTx3UK+BqqMjFqf1qFZU4= X-Received: by 2002:a5d:4b10:0:b0:213:5e0:2c6c with SMTP id v16-20020a5d4b10000000b0021305e02c6cmr23787190wrq.126.1654562553942; Mon, 06 Jun 2022 17:42:33 -0700 (PDT) MIME-Version: 1.0 References: <20220519134204.5379-1-will@kernel.org> <20220519134204.5379-60-will@kernel.org> In-Reply-To: <20220519134204.5379-60-will@kernel.org> From: Peter Collingbourne Date: Mon, 6 Jun 2022 17:42:22 -0700 Message-ID: Subject: Re: [PATCH 59/89] KVM: arm64: Do not support MTE for protected VMs To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_174235_709411_735002CC X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 19, 2022 at 7:40 AM Will Deacon wrote: > > From: Fuad Tabba > > Return an error (-EINVAL) if trying to enable MTE on a protected > vm. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/arm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 10e036bf06e3..8a1b4ba1dfa7 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -90,7 +90,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > break; > case KVM_CAP_ARM_MTE: > mutex_lock(&kvm->lock); > - if (!system_supports_mte() || kvm->created_vcpus) { > + if (!system_supports_mte() || > + kvm_vm_is_protected(kvm) || Should this check be added to kvm_vm_ioctl_check_extension() as well? Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFC3CCA47C for ; Tue, 7 Jun 2022 11:12:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 21A8D4B325; Tue, 7 Jun 2022 07:12:53 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GANkPTm3l7NF; Tue, 7 Jun 2022 07:12:52 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 60DBD4B366; Tue, 7 Jun 2022 07:12:45 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 59C984B2F6 for ; Mon, 6 Jun 2022 20:42:36 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DCpDtvfEjMXW for ; Mon, 6 Jun 2022 20:42:35 -0400 (EDT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 35BB14B19D for ; Mon, 6 Jun 2022 20:42:35 -0400 (EDT) Received: by mail-wr1-f49.google.com with SMTP id q7so21926198wrg.5 for ; Mon, 06 Jun 2022 17:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xrS17sEQ3fRPRqMXnMRDhd1tVPi2Vsh08gg2EBYpymM=; b=SandzrnngwOhRTb7pOv7vDUXRvqY6I+fX26+o4AE+4oTdmUbOSgFO7ZLB+rx1z3A/D xV9ISdzwufntSdxLAJVDSJSsY/g1ASXMr+GS9Ep8fv6saHUVZfAID5Y6sMpqLDrZ6+ri 8DnY1F8gCpDfLb3G9J0S3+A6EiWDuwMmOamclAsFTGps0qCe6xHs+s4QaTBeyZzhvvtd xs1nbZ0048cLZuV27n8vhLONuob2ISCzfsahl7H2WWuDMBdZvGFld2a0fq6RyDYfpi2n GM9dIiSUT1ll9rIbt5B9ToV1tMRPrwu7j/rrIe5zmemKTTII4nDov62UIwXsQSFMGmQ5 hf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xrS17sEQ3fRPRqMXnMRDhd1tVPi2Vsh08gg2EBYpymM=; b=XkAvF411Sqoq6IckxI/RPAJHHMEQvHggEVYRifxzHXfqRx2b4SNktcZ8joz38mlD9m Manp1cp0VvMSRCuZGyue1YqHedFofynxOfPkg82TYm7IFU6PrN1wE0l06e11VlEAsGTK utcQw08YbocNlJpGjZqGOGw/QylZuFZQdRm4oC1AwRy9JzRV5Yyt3EalEOQUyrk4Cl2c /NUFi6WsgUtXa+r0NftrCPM/jMHRyDQVkz7nseub2oMus/D2VI7hBIE/Is09vspsk26e 6ieiwkNKYI229AyaBpyR/Hoxu7qalpioAxfuyaLjOumUYGKx8KZ9CjaV+A7z5MrkxiNn jDrg== X-Gm-Message-State: AOAM532PjHVJjNMr38+6wmaVg8zLaM8+YsSyIfvnafGrvnWqdrERJVNN LTFKXgSL4c8QjR1gYKZANQW6SLzo4OXlRiFJ6HfMhw== X-Google-Smtp-Source: ABdhPJycltbOTsL7TkxiF885x5QthonQlvgpxJIZFOu+1GRjvPzN5Kl98cntZbpqNcd7ixaTx3UK+BqqMjFqf1qFZU4= X-Received: by 2002:a5d:4b10:0:b0:213:5e0:2c6c with SMTP id v16-20020a5d4b10000000b0021305e02c6cmr23787190wrq.126.1654562553942; Mon, 06 Jun 2022 17:42:33 -0700 (PDT) MIME-Version: 1.0 References: <20220519134204.5379-1-will@kernel.org> <20220519134204.5379-60-will@kernel.org> In-Reply-To: <20220519134204.5379-60-will@kernel.org> From: Peter Collingbourne Date: Mon, 6 Jun 2022 17:42:22 -0700 Message-ID: Subject: Re: [PATCH 59/89] KVM: arm64: Do not support MTE for protected VMs To: Will Deacon X-Mailman-Approved-At: Tue, 07 Jun 2022 07:12:43 -0400 Cc: Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Andy Lutomirski , Linux ARM , Michael Roth , Catalin Marinas , Chao Peng , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, May 19, 2022 at 7:40 AM Will Deacon wrote: > > From: Fuad Tabba > > Return an error (-EINVAL) if trying to enable MTE on a protected > vm. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/arm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 10e036bf06e3..8a1b4ba1dfa7 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -90,7 +90,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > break; > case KVM_CAP_ARM_MTE: > mutex_lock(&kvm->lock); > - if (!system_supports_mte() || kvm->created_vcpus) { > + if (!system_supports_mte() || > + kvm_vm_is_protected(kvm) || Should this check be added to kvm_vm_ioctl_check_extension() as well? Peter _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm