From: Max Filippov <jcmvbkbc@gmail.com>
To: Filip Bozuta <Filip.Bozuta@syrmia.com>
Cc: Riku Voipio <riku.voipio@iki.fi>,
qemu-devel <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2 2/3] linux-user: Add missing termbits types and values definitions
Date: Thu, 23 Jul 2020 14:27:32 -0700 [thread overview]
Message-ID: <CAMo8Bf+MEeTGuh5KfTBa97Xc11FfNAcYz5L9GGrKDtfopZQc0A@mail.gmail.com> (raw)
In-Reply-To: <CAMo8Bf+O8ggdKuxhwQ_GyBwDyPAwBB=v=kD1Dnq=VWW-SvHJEg@mail.gmail.com>
On Thu, Jul 23, 2020 at 2:25 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> On Thu, Jul 23, 2020 at 2:04 PM Filip Bozuta <Filip.Bozuta@syrmia.com> wrote:
> >
> > This patch introduces missing target types ('target_flag_t', 'target_cc_t',
> > 'target_speed_t') in a few 'termibts.h' header files. Also, two missing
> > values ('TARGET_IUTF8' and 'TARGET_EXTPROC') were also added. These values
> > were also added in file 'syscall.c' in bitmask tables 'iflag_tbl[]' and
> > 'lflag_tbl[]' which are used to convert values of 'struct termios' between
> > target and host.
> >
> > Signed-off-by: Filip Bozuta <Filip.Bozuta@syrmia.com>
> > ---
> > linux-user/alpha/termbits.h | 1 +
> > linux-user/cris/termbits.h | 18 ++++++++----
> > linux-user/hppa/termbits.h | 17 +++++++----
> > linux-user/mips/termbits.h | 17 +++++++----
> > linux-user/ppc/termbits.h | 21 ++++++++------
> > linux-user/sh4/termbits.h | 19 +++++++++----
> > linux-user/sparc/termbits.h | 18 ++++++++----
> > linux-user/sparc64/termbits.h | 18 ++++++++----
> > linux-user/syscall.c | 34 +++++++++++-----------
> > linux-user/xtensa/termbits.h | 53 ++++++++++++++++++-----------------
> > 10 files changed, 130 insertions(+), 86 deletions(-)
>
> Curious why you did it to some targets, but not to others?
> E.g. the following headers have similar definitions:
> linux-user/aarch64/termbits.h
> linux-user/arm/termbits.h
> linux-user/i386/termbits.h
> linux-user/m68k/termbits.h
> linux-user/microblaze/termbits.h
> linux-user/nios2/termbits.h
> linux-user/riscv/termbits.h
> linux-user/s390x/termbits.h
> linux-user/tilegx/termbits.h
Never mind, I got this email before the other that adds generic headers...
Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
next prev parent reply other threads:[~2020-07-23 21:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 21:02 [PATCH v2 0/3] Adding support for printing contents of 'struct termios' which is used by ioctls of group 'ioctl_tty' Filip Bozuta
2020-07-23 21:02 ` [PATCH v2 1/3] linux-user: Add generic 'termbits.h' for some archs Filip Bozuta
2020-08-07 13:10 ` Laurent Vivier
2020-08-24 20:38 ` Laurent Vivier
2020-07-23 21:02 ` [PATCH v2 2/3] linux-user: Add missing termbits types and values definitions Filip Bozuta
2020-07-23 21:25 ` Max Filippov
2020-07-23 21:27 ` Max Filippov [this message]
2020-08-07 13:13 ` Laurent Vivier
2020-08-24 20:39 ` Laurent Vivier
2020-07-23 21:02 ` [PATCH v2 3/3] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines Filip Bozuta
2020-08-07 13:18 ` Laurent Vivier
2020-08-24 20:50 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8Bf+MEeTGuh5KfTBa97Xc11FfNAcYz5L9GGrKDtfopZQc0A@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=Filip.Bozuta@syrmia.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.