From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130C7C07E96 for ; Thu, 8 Jul 2021 08:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8DE861C3F for ; Thu, 8 Jul 2021 08:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231235AbhGHIoq (ORCPT ); Thu, 8 Jul 2021 04:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbhGHIop (ORCPT ); Thu, 8 Jul 2021 04:44:45 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 724DEC061574 for ; Thu, 8 Jul 2021 01:42:03 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id cy23so2379287edb.4 for ; Thu, 08 Jul 2021 01:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=os/T813PZdDCU5XBX3OMjqspJfYpz1AMtwUEcpldmCU=; b=d1gplhl6eBDBBtCFbhQ87Fu5JJvAdcL0ZtOA/xnA/P44IGqhqYrHr1miuolseUIeKp +nXMZmw/jcyqylbOHuZYz69yGM73v98UgtBqFLdx9Z+vn1BuZcmPzygE0Y6oSKT3aYhC d8H9ODr61uI52Fq0RVqmLCyGbgj++7SYf3kUJmjySftyXAt5VyLvzrT/uNuHYXb/X4RR j+0NZCKmNnX6ANd9xMH4YkB8H0fvszFuqtT6CVCJsTbW2cHWqw9icRr1X8olGfaBtT7o aPZf3/Pd9CQfrP+T01RN5PPHoFhlJkWTKE8LCPTz8/wQc14J1Ygx7YzehJsREx9HFjBn GYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=os/T813PZdDCU5XBX3OMjqspJfYpz1AMtwUEcpldmCU=; b=OB4wYXBn9aAub3ovpPeMt5nkupkRFuf7WDDrHUuxtfcA01bdXF7EsLq8QA5bu5Ico0 vyCBAlc6KK32tK4LzANjyE+8Pm5YeVWu3+m2g6wEdDeLvttWSubxR9oVBBVGd0n9zCg9 QOBpnzjf3lb8/hO8KN404CgEPg+F6CaQwkjcmM8b2TqKAx1b7kSrDOBTWgTu56yvEXRx 6LFisGhT0BLAu3lQWDHo/9YNsO0C4lM4HPR4u/qSOKto56LKLQFC6rNv2tXNHouiAyPp T+xgf84ZWBwJmemDcBKz7QMVjsBOW6/x49+qq/5bgWXbTlxul6AyPKBTiWh1YPZTHUYM 8rEQ== X-Gm-Message-State: AOAM5338OXhyRYFb6ZF3GkjCsG4o/5aKwhdQqFDqeuMnDPoYpZk4jJe1 M3mFsu4BWtslTjpg+T0NRsAZkWuY8oYqQmWySTM= X-Google-Smtp-Source: ABdhPJx83Wr9R9gdGNSGocTRyRtkWBZAGSCWqjaompP2jLu6wFyiWdSCGUG3FLeBDgXgrd8lyLyM5pBRHsvsxEJrN3U= X-Received: by 2002:a05:6402:100e:: with SMTP id c14mr35744812edu.51.1625733722153; Thu, 08 Jul 2021 01:42:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Max Filippov Date: Thu, 8 Jul 2021 01:41:50 -0700 Message-ID: Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() To: Takashi Iwai Cc: Sergey Senozhatsky , alsa-devel@alsa-project.org, Leon Romanovsky , Takashi Iwai , LKML , "Gustavo A. R. Silva" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 8, 2021 at 12:13 AM Takashi Iwai wrote: > On Wed, 07 Jul 2021 22:33:22 +0200, > Max Filippov wrote: > > > > On Wed, Jul 7, 2021 at 11:14 AM Takashi Iwai wrote: > > > On Wed, 07 Jul 2021 19:50:07 +0200, Max Filippov wrote: > > > > It didn't change anything in my case. My further observation is that > > > > the snd_intel8x0_update is called before the ichdev->prepared > > > > is set to one and as a result IRQ is apparently never cleared. > > > > > > So it's broken in anyway no matter whether > > > intel8x0_measure_ac97_clock() is called or not, right? > > > > The change that you suggested didn't eliminate the call to > > intel8x0_measure_ac97_clock, it's still called and an interrupt > > flood happens at the same place. > > Ah I see the point. Then the fix would be a oneliner like below. > > > Takashi > > --- a/sound/pci/intel8x0.c > +++ b/sound/pci/intel8x0.c > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > int status, civ, i, step; > int ack = 0; > > - if (!ichdev->prepared || ichdev->suspended) > + if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended) There's no ichdev::in_measurement, but if replaced with chip->in_measurement it indeed fixes my issue. So with this change: Tested-by: Max Filippov -- Thanks. -- Max From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DD7C07E9E for ; Thu, 8 Jul 2021 08:43:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D84461CDD for ; Thu, 8 Jul 2021 08:43:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D84461CDD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 30F2A112; Thu, 8 Jul 2021 10:42:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 30F2A112 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625733786; bh=sLZQJmmszgN5osCJAAakV0oWG3lDL3aiL5wdnWsmWVs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SjaehVk66bFNBFPdIZ3x6SNjzJAsrs1Ejlt4q4LbV14k6k9iHumhMP/bsPAiouGVN +NKgqlyPAIJu6CGIO0MZ+8YlFNFKtp2WLEx9Ty9iDMzLrbcrXChax0DOstF+sITpkn dCNkzgHSp+eN1nSgPKCpwhpri+slx1c9YzhwXi2Q= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BDADDF80246; Thu, 8 Jul 2021 10:42:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6E219F80249; Thu, 8 Jul 2021 10:42:09 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2756BF80143 for ; Thu, 8 Jul 2021 10:42:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2756BF80143 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d1gplhl6" Received: by mail-ed1-x52d.google.com with SMTP id t10so1281021eds.2 for ; Thu, 08 Jul 2021 01:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=os/T813PZdDCU5XBX3OMjqspJfYpz1AMtwUEcpldmCU=; b=d1gplhl6eBDBBtCFbhQ87Fu5JJvAdcL0ZtOA/xnA/P44IGqhqYrHr1miuolseUIeKp +nXMZmw/jcyqylbOHuZYz69yGM73v98UgtBqFLdx9Z+vn1BuZcmPzygE0Y6oSKT3aYhC d8H9ODr61uI52Fq0RVqmLCyGbgj++7SYf3kUJmjySftyXAt5VyLvzrT/uNuHYXb/X4RR j+0NZCKmNnX6ANd9xMH4YkB8H0fvszFuqtT6CVCJsTbW2cHWqw9icRr1X8olGfaBtT7o aPZf3/Pd9CQfrP+T01RN5PPHoFhlJkWTKE8LCPTz8/wQc14J1Ygx7YzehJsREx9HFjBn GYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=os/T813PZdDCU5XBX3OMjqspJfYpz1AMtwUEcpldmCU=; b=WUOPktSXqzBEaLur1OSxugcL9iLkM4nsIqLgbpD/LplnBwWd4u/Ru4/aYM+MGmp9Zm eDvEpttpr1GovplhTC/pCcgi07uQ2L9KtVYJAanE9Z41x3TzOG3CB16Ymbqj2mfhEkpL 0bbnk/aJh2rKcAKzrUnrx4+dsH6xbVFKv0goVlbOmvISJDcO4gjmBCysrUcB/jXQan2F BUDoFDHJVWMlulbNKfsnNLmWhUkUAmxYrxMBjj7kxaHviz5UI5MgsfvYoUZ+vv9k8i8N f3ukIH8wVmgTBLU1ZYexYNIVTZgU1mIcsBH+uAiw+d//VOcpclxW4c9kGhEqS9VUVUt3 ARsA== X-Gm-Message-State: AOAM532iH1Ly6c1jTgfEbvkrtdYuH4CbNJRc1ILIMY0r++lv1HXBK1BY jMXDAhY9rMcum/usaj8I26T9yu0Xeoh7R7oC6HE= X-Google-Smtp-Source: ABdhPJx83Wr9R9gdGNSGocTRyRtkWBZAGSCWqjaompP2jLu6wFyiWdSCGUG3FLeBDgXgrd8lyLyM5pBRHsvsxEJrN3U= X-Received: by 2002:a05:6402:100e:: with SMTP id c14mr35744812edu.51.1625733722153; Thu, 08 Jul 2021 01:42:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Max Filippov Date: Thu, 8 Jul 2021 01:41:50 -0700 Message-ID: Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() To: Takashi Iwai Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, Leon Romanovsky , LKML , "Gustavo A. R. Silva" , Takashi Iwai , Sergey Senozhatsky X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jul 8, 2021 at 12:13 AM Takashi Iwai wrote: > On Wed, 07 Jul 2021 22:33:22 +0200, > Max Filippov wrote: > > > > On Wed, Jul 7, 2021 at 11:14 AM Takashi Iwai wrote: > > > On Wed, 07 Jul 2021 19:50:07 +0200, Max Filippov wrote: > > > > It didn't change anything in my case. My further observation is that > > > > the snd_intel8x0_update is called before the ichdev->prepared > > > > is set to one and as a result IRQ is apparently never cleared. > > > > > > So it's broken in anyway no matter whether > > > intel8x0_measure_ac97_clock() is called or not, right? > > > > The change that you suggested didn't eliminate the call to > > intel8x0_measure_ac97_clock, it's still called and an interrupt > > flood happens at the same place. > > Ah I see the point. Then the fix would be a oneliner like below. > > > Takashi > > --- a/sound/pci/intel8x0.c > +++ b/sound/pci/intel8x0.c > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > int status, civ, i, step; > int ack = 0; > > - if (!ichdev->prepared || ichdev->suspended) > + if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended) There's no ichdev::in_measurement, but if replaced with chip->in_measurement it indeed fixes my issue. So with this change: Tested-by: Max Filippov -- Thanks. -- Max