From mboxrd@z Thu Jan 1 00:00:00 1970 From: Max Filippov Date: Mon, 12 Feb 2018 13:48:53 -0800 Subject: [U-Boot] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set In-Reply-To: <20180212210356.GJ10592@bill-the-cat> References: <20180130152313.28099-1-abrodkin@synopsys.com> <20180211204733.GK3061@bill-the-cat> <1518442049.4974.50.camel@synopsys.com> <20180212142359.GM3061@bill-the-cat> <20180212210356.GJ10592@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Feb 12, 2018 at 1:03 PM, Tom Rini wrote: >> On Mon, Feb 12, 2018 at 6:23 AM, Tom Rini wrote: >> > I'm largely ok with the above, but: >> > - For Xtensa (Max?), CONFIG_SYS_TEXT_ADDR needs to be renamed to >> > CONFIG_SYS_TEXT_BASE there >> >> For xtensa that address is defined as an expression, like >> (CONFIG_SYS_MEMORY_TOP - CONFIG_SYS_MONITOR_LEN), >> and for a single board it may vary with the CPU core on that board. > > OK. But are those also really dynamic values? SYS_MEMORY_TOP, > SYS_MONITOR_LEN and SYS_TEXT_ADDR need to be converted to Kconfig, or > removed from CONFIG namespace, whatever makes the most sense. If the At least two of the three -- yes, in a sense that they cannot be calculated without the core-specific configuration overlay. I'll move SYS_MONITOR_LEN to the Kconfig and move SYS_MEMORY_TOP and SYS_TEXT_ADDR from the CONFIG namespace. > notion of CONFIG_SYS_TEXT_BASE is just pointless to Xtensa, we add them > to the ifneq(...,) test for the change Alexey is doing. Thanks! Yes, please. -- Thanks. -- Max