Re: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0

From: Max Filippov <jcmvbkbc@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Chris Zankel <chris@zankel.net>,
	"open list:TENSILICA XTENSA PORT (xtensa)" 
	<linux-xtensa@linux-xtensa.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0
Date: Tue, 10 Aug 2021 16:21:29 -0700	[thread overview]
Message-ID: <CAMo8BfL6D3MU-_RO-FQoywPJfdZPaa2=TRZw4ZgxwPfjRXbG=g@mail.gmail.com> (raw)
In-Reply-To: <1627640999-17706-1-git-send-email-jiapeng.chong@linux.alibaba.com>

Hi Jiapeng,

On Fri, Jul 30, 2021 at 3:30 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing
> pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/xtensa/platforms/iss/console.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
> index 81f9889..92d4624 100644
> --- a/arch/xtensa/platforms/iss/console.c
> +++ b/arch/xtensa/platforms/iss/console.c
> @@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count)
>  {
>         int len = strlen(s);

Here's a bigger issue in this function: s is used in strlen before it
is checked for NULL.
I've posted another patch that fixes it.

> -       if (s != 0 && *s != 0)
> +       if (s && *s != 0)
>                 simc_write(1, s, count < len ? count : len);
>  }
>
> --
> 1.8.3.1
>

-- 
Thanks.
-- Max