From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4FB5C433F5 for ; Wed, 15 Sep 2021 07:56:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ED5060F58 for ; Wed, 15 Sep 2021 07:56:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6ED5060F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQPm2-00009D-Lk for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 03:56:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQPkb-0006ux-Sr; Wed, 15 Sep 2021 03:54:37 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:41668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQPka-0004SU-Hc; Wed, 15 Sep 2021 03:54:37 -0400 Received: by mail-pl1-x629.google.com with SMTP id v2so1113709plp.8; Wed, 15 Sep 2021 00:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E3gAr87EDemAc8yEwCl6/Y8xliZAWl1VYELf/UlFmJo=; b=pTuB/N6YJm9LCrs8qN/14kPcAcSRNzMSqJDO7/oM5rP8imKClM5xjzOs1WabCSw4zd hHfF6Ym29I4GSIub1ow1fotXJqYK7W1dLcMAu4l12vAry/0Re8bVqXK6Lhj2Nh90rAHO JIXROfZIwYweBk7r7scwCBCRGQsG4yYlx9a97nEAJ0w+cxCnJu7Phet/JRNtMUJ0aAOc kihyf6mSvsT/Y1IMbIXIDRhFiKwE8cibqB8/15QMA1+ieanh5h2H85nlFe8LdnIY6Bfd pyq0I4MMOTQHkwqAQSpukDrRicA3Uyf5ywkUKMxJaSwB2V39u7+/L4sOY950kOviZDSg jfdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E3gAr87EDemAc8yEwCl6/Y8xliZAWl1VYELf/UlFmJo=; b=B+c9HLROwYHcrcImHWpoOxN703QqVeyp7T4qKNsVONSk661XDX4KvDd2VmvMLzUeM+ Rk0Ewj+VTMol0saYYdhwjGzdq9VQX46oSvg5kCO0vgXtTWFaauylvs3nv2Afh0YB/tyF rXqchOesJWYueOwZph+CFF0nkMgmOIHdh3X5tGLnTU/P1UJ6CyFrcD+WmS+9RW3s+AYT e420tOwU+nts2ozrbEk789Syk9ChY5T5Fc6l84sI7E1ChcPzjBq1fUsYBAJO0rNbqjzT ZlJMhlSpL0RUE8SvGLhW2QZZ0bEuAzAaSu41q8AtrzSI7kY+wuucdHU0j93UfpHKNLYW I70w== X-Gm-Message-State: AOAM532uskebz2f3LUT7ODquCajdEPpDzBa4LwMf5127YCg7kIq/2Zq4 +H63Wp1bhCxPPFZpFL/GWWdqjikgBZKYYTDD49w= X-Google-Smtp-Source: ABdhPJzEu2x0f0ggBgFjBVZqFs1UFWTkCQeoZ6/6tvr+NtX8TdMetf4FHU7hRGghu1+WrApGvYt/YNDr6iAcAtRDaRE= X-Received: by 2002:a17:90a:2ecb:: with SMTP id h11mr7086196pjs.196.1631692472568; Wed, 15 Sep 2021 00:54:32 -0700 (PDT) MIME-Version: 1.0 References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-28-berrange@redhat.com> <1cb38e8f-cc05-461a-c722-efb18519f6fe@amsat.org> In-Reply-To: <1cb38e8f-cc05-461a-c722-efb18519f6fe@amsat.org> From: Max Filippov Date: Wed, 15 Sep 2021 00:54:21 -0700 Message-ID: Subject: Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=jcmvbkbc@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_LOCAL_NOVOWEL=0.5, HK_RANDOM_ENVFROM=0.689, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel , Peter Xu , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x , qemu-arm , Michael Rolnik , qemu-riscv@nongnu.org, Stafford Horne , David Gibson , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 15, 2021 at 12:32 AM Philippe Mathieu-Daud=C3=A9 wrote: > On 9/14/21 4:20 PM, Daniel P. Berrang=C3=A9 wrote: > > if ((flags & CPU_DUMP_FPU) && > > xtensa_option_enabled(env->config, XTENSA_OPTION_FP_COPROCESSO= R)) { > > - qemu_fprintf(f, "\n"); > > + g_string_append_printf(buf, "\n"); > > g_string_append_c(); simpler to move it before this if() statement. It adds spacing between optional blocks, why does it need to be moved out? > > if ((flags & CPU_DUMP_FPU) && > > xtensa_option_enabled(env->config, XTENSA_OPTION_DFP_COPROCESS= OR) && > > !xtensa_option_enabled(env->config, XTENSA_OPTION_DFPU_SINGLE_= ONLY)) { > > - qemu_fprintf(f, "\n"); > > + g_string_append_printf(buf, "\n"); > > Ditto (move out). Here as well. --=20 Thanks. -- Max From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQPke-0006xZ-1l for mharc-qemu-riscv@gnu.org; Wed, 15 Sep 2021 03:54:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQPkb-0006ux-Sr; Wed, 15 Sep 2021 03:54:37 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:41668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQPka-0004SU-Hc; Wed, 15 Sep 2021 03:54:37 -0400 Received: by mail-pl1-x629.google.com with SMTP id v2so1113709plp.8; Wed, 15 Sep 2021 00:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E3gAr87EDemAc8yEwCl6/Y8xliZAWl1VYELf/UlFmJo=; b=pTuB/N6YJm9LCrs8qN/14kPcAcSRNzMSqJDO7/oM5rP8imKClM5xjzOs1WabCSw4zd hHfF6Ym29I4GSIub1ow1fotXJqYK7W1dLcMAu4l12vAry/0Re8bVqXK6Lhj2Nh90rAHO JIXROfZIwYweBk7r7scwCBCRGQsG4yYlx9a97nEAJ0w+cxCnJu7Phet/JRNtMUJ0aAOc kihyf6mSvsT/Y1IMbIXIDRhFiKwE8cibqB8/15QMA1+ieanh5h2H85nlFe8LdnIY6Bfd pyq0I4MMOTQHkwqAQSpukDrRicA3Uyf5ywkUKMxJaSwB2V39u7+/L4sOY950kOviZDSg jfdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E3gAr87EDemAc8yEwCl6/Y8xliZAWl1VYELf/UlFmJo=; b=B+c9HLROwYHcrcImHWpoOxN703QqVeyp7T4qKNsVONSk661XDX4KvDd2VmvMLzUeM+ Rk0Ewj+VTMol0saYYdhwjGzdq9VQX46oSvg5kCO0vgXtTWFaauylvs3nv2Afh0YB/tyF rXqchOesJWYueOwZph+CFF0nkMgmOIHdh3X5tGLnTU/P1UJ6CyFrcD+WmS+9RW3s+AYT e420tOwU+nts2ozrbEk789Syk9ChY5T5Fc6l84sI7E1ChcPzjBq1fUsYBAJO0rNbqjzT ZlJMhlSpL0RUE8SvGLhW2QZZ0bEuAzAaSu41q8AtrzSI7kY+wuucdHU0j93UfpHKNLYW I70w== X-Gm-Message-State: AOAM532uskebz2f3LUT7ODquCajdEPpDzBa4LwMf5127YCg7kIq/2Zq4 +H63Wp1bhCxPPFZpFL/GWWdqjikgBZKYYTDD49w= X-Google-Smtp-Source: ABdhPJzEu2x0f0ggBgFjBVZqFs1UFWTkCQeoZ6/6tvr+NtX8TdMetf4FHU7hRGghu1+WrApGvYt/YNDr6iAcAtRDaRE= X-Received: by 2002:a17:90a:2ecb:: with SMTP id h11mr7086196pjs.196.1631692472568; Wed, 15 Sep 2021 00:54:32 -0700 (PDT) MIME-Version: 1.0 References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-28-berrange@redhat.com> <1cb38e8f-cc05-461a-c722-efb18519f6fe@amsat.org> In-Reply-To: <1cb38e8f-cc05-461a-c722-efb18519f6fe@amsat.org> From: Max Filippov Date: Wed, 15 Sep 2021 00:54:21 -0700 Message-ID: Subject: Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel , Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Laurent Vivier , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x , qemu-arm , Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , qemu-ppc , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=jcmvbkbc@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_LOCAL_NOVOWEL=0.5, HK_RANDOM_ENVFROM=0.689, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 07:54:38 -0000 On Wed, Sep 15, 2021 at 12:32 AM Philippe Mathieu-Daud=C3=A9 wrote: > On 9/14/21 4:20 PM, Daniel P. Berrang=C3=A9 wrote: > > if ((flags & CPU_DUMP_FPU) && > > xtensa_option_enabled(env->config, XTENSA_OPTION_FP_COPROCESSO= R)) { > > - qemu_fprintf(f, "\n"); > > + g_string_append_printf(buf, "\n"); > > g_string_append_c(); simpler to move it before this if() statement. It adds spacing between optional blocks, why does it need to be moved out? > > if ((flags & CPU_DUMP_FPU) && > > xtensa_option_enabled(env->config, XTENSA_OPTION_DFP_COPROCESS= OR) && > > !xtensa_option_enabled(env->config, XTENSA_OPTION_DFPU_SINGLE_= ONLY)) { > > - qemu_fprintf(f, "\n"); > > + g_string_append_printf(buf, "\n"); > > Ditto (move out). Here as well. --=20 Thanks. -- Max