All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Nikita Shubin <nikita.shubin@maquefel.me>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] gpio: ep93xx: drop to_irq binding
Date: Mon, 4 Jan 2021 15:17:46 +0100	[thread overview]
Message-ID: <CAMpxmJU-j93c8qUduehGKdHigswYcnAkhXKx8NmQjPqO7ibJjw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdadUVHefag4d42BJiOraAmHrXDcK7gzjZrLXn371rMwOA@mail.gmail.com>

On Sun, Dec 27, 2020 at 10:21 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Thu, Dec 24, 2020 at 12:22 PM Nikita Shubin
> <nikita.shubin@maquefel.me> wrote:
>
> > As ->to_irq is redefined in gpiochip_add_irqchip, having it defined in
> > driver is useless, so let's drop it.
> >
> > Also i think it is worth to give a gentle warning in
> > gpiochip_add_irqchip, to prevent people relying on to_irq.
> >
> > For example
> >
> > WARN_ON_ONCE(gc->to_irq,
> > "to_irq is redefined in gpiochip_add_irqchip" \
> > "and you shouldn't rely on it\n");
> >
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Take out the suggestion in the commit message and implement it,
> but I think WARN_ON is too nasty, just use dev_err().
>
> Yours,
> Linus Walleij

This depends on patch 1/3 so I'll wait until you resend with issues addressed.

Bartosz

  reply	other threads:[~2021-01-04 14:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 11:22 [RFC PATCH 0/3] gpio: ep93xx: convert to multi irqchips Nikita Shubin
2020-12-24 11:22 ` [RFC PATCH 1/3] " Nikita Shubin
2020-12-26 17:52   ` Andy Shevchenko
2020-12-28 15:05     ` nikita.shubin
2020-12-24 11:22 ` [RFC PATCH 2/3] gpio: ep93xx: drop to_irq binding Nikita Shubin
2020-12-27 21:21   ` Linus Walleij
2021-01-04 14:17     ` Bartosz Golaszewski [this message]
2020-12-24 11:22 ` [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first Nikita Shubin
2020-12-27 21:22   ` Linus Walleij
2020-12-26 17:34 ` [RFC PATCH 0/3] gpio: ep93xx: convert to multi irqchips Andy Shevchenko
2020-12-27 14:00   ` Linus Walleij
2020-12-27 13:55 ` Linus Walleij
2020-12-28 15:14   ` nikita.shubin
2020-12-28 20:41     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMpxmJU-j93c8qUduehGKdHigswYcnAkhXKx8NmQjPqO7ibJjw@mail.gmail.com \
    --to=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikita.shubin@maquefel.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.