From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F02BC433F7 for ; Sat, 18 Jul 2020 09:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C968207FB for ; Sat, 18 Jul 2020 09:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="qraFjx5Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbgGRJZF (ORCPT ); Sat, 18 Jul 2020 05:25:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726566AbgGRJYz (ORCPT ); Sat, 18 Jul 2020 05:24:55 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3418C0619D3 for ; Sat, 18 Jul 2020 02:24:52 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id j10so9479799qtq.11 for ; Sat, 18 Jul 2020 02:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BFno1i8ULLYg3FCWz/CmmFbzrbZUMcHSe/iu00Qu+g4=; b=qraFjx5YB4bZTW6OHepRqQaJ0u0cZulZzc6jCeVJQqh5HmzdjraCoxIsFGOjzxFbEr J/CjhdP91NLLJbeYiRuK4+TC+KK/tuE8uSpy/P6hs/dQ0owN3mLDZlkgzjRMUerX3Px+ VPE0K7m+Zvh7kJj5V9I3nWFF5+YxZuU6jLmxxOd+Sl4CduA9BetaIgNS9UlkwgeUssFl jTZSEDd5UWQd+VG1l2IiIf0dx0bE7QcrBp5OtohGKUQkHa6aaurNk1pxMjP+FFxojDy0 HRPP6UodUcCNU8GyTEuMzs8KKjUjxbWToLpHa61Q0w2hAsZPR34YPEH6PSZ2y252A1w8 uZbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BFno1i8ULLYg3FCWz/CmmFbzrbZUMcHSe/iu00Qu+g4=; b=QgDj9eKWr3EhySZXW/7l2l9U1RvdppQWDbvaCGRV/OQ1OEI684kRNOOvAyDxP3G/HD VD/VGADCaO9HKKtZCtCZPXUufr9kYNhcswezGXzmHTKhrhIJwOpomAIYy4leIr4XUCPZ 7nYGybBUQgbXayLPsQ/U0zU6oIywUhDgsD9hh4Cn9u8V/stPghKLZxa+R22z3MQYXxTP JThLHFlWouL82LtHYuvcMavQOI0pRTbJjGM4vnHsG6FWFdDz8CtmFeneSlk0wLSuPlPH LikqSfm2xnRxMDpBECY74N/bumIAUY3GN+5UNrEWaE5oE05rsv/Yxi2TF8NimZlpeMMn j1CA== X-Gm-Message-State: AOAM530M2wSAkLqrsUVXVMWxMp5nIGTiaHqnbsQiYbEHpYU9OvyiJtT1 yKUjLSBghrqzvsYodUmLuFzjFmnt3XHsvBk32uvtBQ== X-Google-Smtp-Source: ABdhPJzM6hZdvPE/up0GYkD8TSobS6uRvY5KVvY9t3AZiSjoUmWbKbOG/uO8a8eca75CeRF2Y+PpLa68jllHUSws0Bg= X-Received: by 2002:aed:2684:: with SMTP id q4mr14373679qtd.208.1595064291603; Sat, 18 Jul 2020 02:24:51 -0700 (PDT) MIME-Version: 1.0 References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-16-lee.jones@linaro.org> In-Reply-To: <20200716135928.1456727-16-lee.jones@linaro.org> From: Bartosz Golaszewski Date: Sat, 18 Jul 2020 11:24:40 +0200 Message-ID: Subject: Re: [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' To: Lee Jones Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , arm-soc , LKML , linux-iio , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2020 at 3:59 PM Lee Jones wrote: > > File headers are not good candidates for kerneldoc. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dummy/iio_dummy_evgen.c:30: warning: Cannot understand * @regs: irq regs we are faking > on line 30 - I thought it was a doc line > drivers/iio/dummy/iio_dummy_evgen.c:42: warning: Function parameter or member 'irq_sim_domain' not described in 'iio_dummy_eventgen' > > Cc: Marc Zyngier > Cc: Bartosz Golaszewski > Signed-off-by: Lee Jones > --- > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c > index ee85d596e5284..1febbbff0ded6 100644 > --- a/drivers/iio/dummy/iio_dummy_evgen.c > +++ b/drivers/iio/dummy/iio_dummy_evgen.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > -/** > +/* > * Copyright (c) 2011 Jonathan Cameron > * > * Companion module to the iio simple dummy example driver. > @@ -27,11 +27,13 @@ > #define IIO_EVENTGEN_NO 10 > > /** > + * struct iio_dummy_eventgen > * @regs: irq regs we are faking > * @lock: protect the evgen state > * @inuse: mask of which irqs are connected > * @irq_sim: interrupt simulator > * @base: base of irq range > + * @irq_sim_domain: irq domain To be even more clear: this could say: "interrupt simulator domain". Bartosz > */ > struct iio_dummy_eventgen { > struct iio_dummy_regs regs[IIO_EVENTGEN_NO]; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA4AC433DF for ; Sat, 18 Jul 2020 09:26:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC8B2070E for ; Sat, 18 Jul 2020 09:26:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MjDg8Tbb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="qraFjx5Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC8B2070E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u3WpezmR5vTjAekZ+WHYZawBtRcy3IKjzuzscflJnQM=; b=MjDg8TbbLi94NRe/iAYyJzgNg 0GL5mTGG4GXLuFPfYXNVITilfDYZ8rjZz3Bjqkzj3rgbaiVaVpJ+Umoybfz0nTNrLHHxqyzUwphD9 WneBMFxs21SIhTzAXwM6m963lQaPHWBWLPOExcKdyDjQ+b2OvsQgd5gdO9pIByUpzcB2Yy58wDMzN wqvXDBLmhCfp8hxULH7KQ3E5oFROAKpJyKBtH8YHWEQ1J479NW/GzIRLJZIAOg38EUlbNJtnYejFA LDhROUay4z3QZ81Cu0+R3xjQevRff7oTW0s/GmarV2gBYaB80lEOEFf06bJUjvaTp9jcgHyvCD0BR 2WM+3vxrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwj5c-0003hu-22; Sat, 18 Jul 2020 09:25:04 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwj5S-0003dT-Op for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 09:25:00 +0000 Received: by mail-qt1-x843.google.com with SMTP id d27so9502728qtg.4 for ; Sat, 18 Jul 2020 02:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BFno1i8ULLYg3FCWz/CmmFbzrbZUMcHSe/iu00Qu+g4=; b=qraFjx5YB4bZTW6OHepRqQaJ0u0cZulZzc6jCeVJQqh5HmzdjraCoxIsFGOjzxFbEr J/CjhdP91NLLJbeYiRuK4+TC+KK/tuE8uSpy/P6hs/dQ0owN3mLDZlkgzjRMUerX3Px+ VPE0K7m+Zvh7kJj5V9I3nWFF5+YxZuU6jLmxxOd+Sl4CduA9BetaIgNS9UlkwgeUssFl jTZSEDd5UWQd+VG1l2IiIf0dx0bE7QcrBp5OtohGKUQkHa6aaurNk1pxMjP+FFxojDy0 HRPP6UodUcCNU8GyTEuMzs8KKjUjxbWToLpHa61Q0w2hAsZPR34YPEH6PSZ2y252A1w8 uZbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BFno1i8ULLYg3FCWz/CmmFbzrbZUMcHSe/iu00Qu+g4=; b=Hc4TPbzss/iuL1gSPfS0K/ucmxQVyJi/wPAxZ3K1HVdot3/Ee0j9XUXcItQvRtoLB0 iHfN3dZPPbFR9k8vb1xnGX1Pg5wsQysd3yundU5QkwbSUefUcF/qwTkYyin7Fy0r7WqB sw8U78P76bzQK8YQcRkpx8iGs83n1uQPd5nfSDn+96/5yuHUpIx4/MSSzf/kaYdRFRKU 0zxdGGWtqrzarPEIxD97gXmGcpCmRhAM1tLot4Up2NTT1gmmSbY680YpX139KPeu1TZA o4DUY0il6B4P2f/hiVjRdb4ZjcJ7IYVDA0Dmq+7P6pM3zxcX7Q9iZ8ugQu/yjdnsZSdQ E/nQ== X-Gm-Message-State: AOAM5310yhf8BuSzoXRNbtjtch1gYfT3qhw37iTP2amX1gnuXk7HBKH+ MMYVi1fPzJKHVnTQQydwP4pYlxd1qJ0vpIg1e6SUsQ== X-Google-Smtp-Source: ABdhPJzM6hZdvPE/up0GYkD8TSobS6uRvY5KVvY9t3AZiSjoUmWbKbOG/uO8a8eca75CeRF2Y+PpLa68jllHUSws0Bg= X-Received: by 2002:aed:2684:: with SMTP id q4mr14373679qtd.208.1595064291603; Sat, 18 Jul 2020 02:24:51 -0700 (PDT) MIME-Version: 1.0 References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-16-lee.jones@linaro.org> In-Reply-To: <20200716135928.1456727-16-lee.jones@linaro.org> From: Bartosz Golaszewski Date: Sat, 18 Jul 2020 11:24:40 +0200 Message-ID: Subject: Re: [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' To: Lee Jones X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_052454_952197_075C93B6 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio , Marc Zyngier , LKML , Jonathan Cameron , Peter Meerwald-Stadler , Hartmut Knaack , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 16, 2020 at 3:59 PM Lee Jones wrote: > > File headers are not good candidates for kerneldoc. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dummy/iio_dummy_evgen.c:30: warning: Cannot understand * @regs: irq regs we are faking > on line 30 - I thought it was a doc line > drivers/iio/dummy/iio_dummy_evgen.c:42: warning: Function parameter or member 'irq_sim_domain' not described in 'iio_dummy_eventgen' > > Cc: Marc Zyngier > Cc: Bartosz Golaszewski > Signed-off-by: Lee Jones > --- > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c > index ee85d596e5284..1febbbff0ded6 100644 > --- a/drivers/iio/dummy/iio_dummy_evgen.c > +++ b/drivers/iio/dummy/iio_dummy_evgen.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > -/** > +/* > * Copyright (c) 2011 Jonathan Cameron > * > * Companion module to the iio simple dummy example driver. > @@ -27,11 +27,13 @@ > #define IIO_EVENTGEN_NO 10 > > /** > + * struct iio_dummy_eventgen > * @regs: irq regs we are faking > * @lock: protect the evgen state > * @inuse: mask of which irqs are connected > * @irq_sim: interrupt simulator > * @base: base of irq range > + * @irq_sim_domain: irq domain To be even more clear: this could say: "interrupt simulator domain". Bartosz > */ > struct iio_dummy_eventgen { > struct iio_dummy_regs regs[IIO_EVENTGEN_NO]; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel