From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86468C43603 for ; Wed, 11 Dec 2019 09:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50F99214AF for ; Wed, 11 Dec 2019 09:08:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="S60wH1RH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbfLKJH7 (ORCPT ); Wed, 11 Dec 2019 04:07:59 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:36698 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfLKJH7 (ORCPT ); Wed, 11 Dec 2019 04:07:59 -0500 Received: by mail-qk1-f193.google.com with SMTP id a203so8913176qkc.3 for ; Wed, 11 Dec 2019 01:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+1+2OzonF8JaI5zb2TCQGTWjY1hWFqWalCfMdztL7bw=; b=S60wH1RHuXQ8mOnPL0RhPKzQIGXltV0Cv9h00AH+VYro56n5frUBSr4jG3994daVvT V+vThx0M+M5TKEPRP7rKgYkWR9SLOxLfctebgbS4/teJyPdNqlqYK9Sqae4OYe3pOZfj RbOKuXYBl+rwcuW9scJiI3DZUILjSRdRChb2cUjEMEG/J6gALdSSdCrSN73Zs+Oaq7Ld ncsVZLJRCCbXDi37Bkc0aQABg2eiqLVtoela5xrLAMI6eSLhlktSHK/xO5UF2xLQLYer yMxhiSsTvhVSoG04ZT4mwPZHx/2a+Y7mdi6v2EwwgKDOC/A2904us+0B2fJX/ZY9l4Bm hO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+1+2OzonF8JaI5zb2TCQGTWjY1hWFqWalCfMdztL7bw=; b=hbbH/LvTPt70kFWoCIRP3PuUlr9GRIHENexL3x1/EKZkMpPiK6G+ddBnJJPksXRKTg CiWDAdU2ZkjBndSNj3s+sRduyEwlrkz4l3YByt2jcInb3R3/HsvV+PmJFSMAW41fAOUo 7ZOHX6CwWxjcqu6wqazKLdS0BCrdc0QVxjyv9vfstkNOUXZsQXdqfqCXcKv+Qy6O1gx7 W6OcKbHJOEEYxvtcaeGM8Phey1UL+YHNlrya/4biDkXrABeIF9UC/iHEXaQp1NxXNLmq KqtgkhJSIFK2R2Zw0/nTc+LScxvdIf94csY8gUgDM+UPxEGAxlmNko8S+laKnPc6zzq0 ly4w== X-Gm-Message-State: APjAAAX1sF9fPTNISkAfybby8e4BKIDWpgshU/QkY9Y7qyeeCc/5HvJf PM6//VTH4OqHSPxyY3haj15MwWrAY4U2temPwycQQg== X-Google-Smtp-Source: APXvYqxo51nvYaIkggIMq8ITtXp9gbKNulM8Wmtc5DRGjuFLLqvLJhg/1ssY8su+0/x7Vipo/ClbnBGeVsB5uoQ3mKs= X-Received: by 2002:a37:6255:: with SMTP id w82mr1919216qkb.330.1576055278589; Wed, 11 Dec 2019 01:07:58 -0800 (PST) MIME-Version: 1.0 References: <20191210202842.2546758-1-arnd@arndb.de> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 11 Dec 2019 10:07:47 +0100 Message-ID: Subject: Re: [PATCH] gpio: aspeed: avoid return type warning To: Andrew Jeffery Cc: Arnd Bergmann , Linus Walleij , Joel Stanley , Hongwei Zhang , linux-gpio , arm-soc , linux-aspeed@lists.ozlabs.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org wt., 10 gru 2019 o 23:10 Andrew Jeffery napisa=C5=82(a): > > > > On Wed, 11 Dec 2019, at 06:58, Arnd Bergmann wrote: > > gcc has a hard time tracking whether BUG_ON(1) ends > > execution or not: > > > > drivers/gpio/gpio-aspeed-sgpio.c: In function 'bank_reg': > > drivers/gpio/gpio-aspeed-sgpio.c:112:1: error: control reaches end of > > non-void function [-Werror=3Dreturn-type] > > > > Use the simpler BUG() that gcc knows cannot continue. > > > > Fixes: f8b410e3695a ("gpio: aspeed-sgpio: Rename and add Kconfig/Makefi= le") > > Signed-off-by: Arnd Bergmann > > Acked-by: Andrew Jeffery Applied for fixes. Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0B9C3F68F for ; Wed, 11 Dec 2019 09:08:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 500C120836 for ; Wed, 11 Dec 2019 09:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tY6nYcK2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="S60wH1RH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 500C120836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=td4iCnsOQKqLfWc0qr0n1aUOJSTJWuy/y8DGdOA+J24=; b=tY6nYcK2oRhnTo 7TguufGgO18M9zsNjX+IMn5JwRSHwHA93hpDNmuJMJYYQ2BI0ho/SHIVKUFpc1RTSam/VA7U55NnJ Co46rqctMsvIvv+YEgtogfPumdl4y5wM6zRzkoBIyX9dYj3azpAt1rTGXF/A/ZXGkjLrSgDnIRsqR jgshXHI41G55ZzGzPQxhhvZDZ6vYJmYYPDkudTYoJK1ZUZ3eMaWn25PLrkS9bidrGSgys6/KO+HaN /HqE1o6dyHsE43OBfv5Hjpl0jtOv8cje3eQ8Zk5ZjcUavsdEfF0tNkWNlzsKUzjXo6YmIYVf2opNa XPlZvHsHtXh77b7iKQmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iexyX-00073e-KM; Wed, 11 Dec 2019 09:08:05 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iexyT-00072l-5V for linux-arm-kernel@lists.infradead.org; Wed, 11 Dec 2019 09:08:02 +0000 Received: by mail-qk1-x741.google.com with SMTP id w127so7228185qkb.11 for ; Wed, 11 Dec 2019 01:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+1+2OzonF8JaI5zb2TCQGTWjY1hWFqWalCfMdztL7bw=; b=S60wH1RHuXQ8mOnPL0RhPKzQIGXltV0Cv9h00AH+VYro56n5frUBSr4jG3994daVvT V+vThx0M+M5TKEPRP7rKgYkWR9SLOxLfctebgbS4/teJyPdNqlqYK9Sqae4OYe3pOZfj RbOKuXYBl+rwcuW9scJiI3DZUILjSRdRChb2cUjEMEG/J6gALdSSdCrSN73Zs+Oaq7Ld ncsVZLJRCCbXDi37Bkc0aQABg2eiqLVtoela5xrLAMI6eSLhlktSHK/xO5UF2xLQLYer yMxhiSsTvhVSoG04ZT4mwPZHx/2a+Y7mdi6v2EwwgKDOC/A2904us+0B2fJX/ZY9l4Bm hO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+1+2OzonF8JaI5zb2TCQGTWjY1hWFqWalCfMdztL7bw=; b=VC3P8XXEPjVxHd+9nEIr1jH2pLOYrbSTsRY/zuplS7Fv91X3do9ZDyiZJIpGXZOb8i nfiP3AEMcpNjudPCuLgRTU1+W9XBFcGhFI/euOywrmtj9ZkanbgUY3s6wIjGjWC0ke+A rPsRELrfO8ooZZus9EUCqpDAn9q26e5BIypBenM1d2XTzEoZdX2IKqSFra7NvkKChrRP ufCeqwmcW9fXmMFGhxKeT56ksW1o6WEr0TPSnphsQw8NM9mDmS5SmEXo5AHeTYgKq9JC uXYBgxBWIopBKEV9dy4TUOrHqXmM3J5+h5BYUFUas3LyivHhM3EbE353+PszVoa8Uz/N MOOg== X-Gm-Message-State: APjAAAXyBjDHTLWEmZoiGD48QhCkBAEs1lR7FEhI4Fv7zMbwm6AriKn+ ye/9z2do/bQUUuikaC4MlD+soKCCwuWLvtt8aAdJ1A== X-Google-Smtp-Source: APXvYqxo51nvYaIkggIMq8ITtXp9gbKNulM8Wmtc5DRGjuFLLqvLJhg/1ssY8su+0/x7Vipo/ClbnBGeVsB5uoQ3mKs= X-Received: by 2002:a37:6255:: with SMTP id w82mr1919216qkb.330.1576055278589; Wed, 11 Dec 2019 01:07:58 -0800 (PST) MIME-Version: 1.0 References: <20191210202842.2546758-1-arnd@arndb.de> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 11 Dec 2019 10:07:47 +0100 Message-ID: Subject: Re: [PATCH] gpio: aspeed: avoid return type warning To: Andrew Jeffery X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_010801_207567_6F9F053B X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Arnd Bergmann , Linus Walleij , LKML , linux-gpio , Joel Stanley , Hongwei Zhang , arm-soc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org d3QuLCAxMCBncnUgMjAxOSBvIDIzOjEwIEFuZHJldyBKZWZmZXJ5IDxhbmRyZXdAYWouaWQuYXU+ IG5hcGlzYcWCKGEpOgo+Cj4KPgo+IE9uIFdlZCwgMTEgRGVjIDIwMTksIGF0IDA2OjU4LCBBcm5k IEJlcmdtYW5uIHdyb3RlOgo+ID4gZ2NjIGhhcyBhIGhhcmQgdGltZSB0cmFja2luZyB3aGV0aGVy IEJVR19PTigxKSBlbmRzCj4gPiBleGVjdXRpb24gb3Igbm90Ogo+ID4KPiA+IGRyaXZlcnMvZ3Bp by9ncGlvLWFzcGVlZC1zZ3Bpby5jOiBJbiBmdW5jdGlvbiAnYmFua19yZWcnOgo+ID4gZHJpdmVy cy9ncGlvL2dwaW8tYXNwZWVkLXNncGlvLmM6MTEyOjE6IGVycm9yOiBjb250cm9sIHJlYWNoZXMg ZW5kIG9mCj4gPiBub24tdm9pZCBmdW5jdGlvbiBbLVdlcnJvcj1yZXR1cm4tdHlwZV0KPiA+Cj4g PiBVc2UgdGhlIHNpbXBsZXIgQlVHKCkgdGhhdCBnY2Mga25vd3MgY2Fubm90IGNvbnRpbnVlLgo+ ID4KPiA+IEZpeGVzOiBmOGI0MTBlMzY5NWEgKCJncGlvOiBhc3BlZWQtc2dwaW86IFJlbmFtZSBh bmQgYWRkIEtjb25maWcvTWFrZWZpbGUiKQo+ID4gU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFu biA8YXJuZEBhcm5kYi5kZT4KPgo+IEFja2VkLWJ5OiBBbmRyZXcgSmVmZmVyeSA8YW5kcmV3QGFq LmlkLmF1PgoKQXBwbGllZCBmb3IgZml4ZXMuCgpCYXJ0b3N6CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==