From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4308EC35254 for ; Mon, 17 Feb 2020 09:38:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B6652070B for ; Mon, 17 Feb 2020 09:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="0FeSRJlL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbgBQJi5 (ORCPT ); Mon, 17 Feb 2020 04:38:57 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:37652 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728956AbgBQJiz (ORCPT ); Mon, 17 Feb 2020 04:38:55 -0500 Received: by mail-qk1-f194.google.com with SMTP id c188so15575612qkg.4 for ; Mon, 17 Feb 2020 01:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Afwt3f5haicc54NjifQPcLwy6vygZPMQ4dpzw9cQKTs=; b=0FeSRJlLGZWcE4RRPtM4gSIGicjoUxKa7odOoqFd72hdA+O7Xh2FTW49Fm7Lpsu7Mi lh9RJGPKS+YWQzILdfhjbg2+ReSx1iyh/T9kJ1u7/SJZ6cgpgnWRAj/aO1VsoeNMHsj9 4tbh6ZUDZ9kxXD6jidbjINrLnHYHzPbiO/uF0q9hQWRzKnuE0Gdv9DEGu6I1nZCgpBMa IDiuVxZw031QBeoBhdhzfbPD6PdckAYJJjHUP5h4WH7M5YpAij0mqLKV58ZdYBbzUb+z GTs0x/6AOtVfey0ERi+0yuJiGWyYX9Lk6Tp27N3EfBD+oPIIYXmO6rJ9UttLRpQc0KuK 8KQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Afwt3f5haicc54NjifQPcLwy6vygZPMQ4dpzw9cQKTs=; b=IlWfrqhO0gh1DwNaRXplXNMZ4vJV3sIXZAtm/5plWon3LsR18TzllF2oh2BE+innqa EwFCMVOJV9F6typNQWEOa1pLFfKTxHfbMhQzizi4f/EAksNxw8XDa8j8igCLk8irnkDP jbHvdaJIK4LxWhKmYLldNDr4UubkWfWzsLkmzSP9f9iE9PPvcNvSd0aSHfSJBfiIkxwf M9/KZnp1aRR+CDxRIIvboAdZcSFsHae2ycJ/VnQlm2N5C6/eexYlIpU/ylQa65mg14j3 R6NMIvEGMGHVE72bfSfvD/wvjGSrTyLJMnP0DmM8/Bb+h5pk9W39cixrMl57JjggabY8 Q/fQ== X-Gm-Message-State: APjAAAXYTQ8rNp9BFrz+ILBup3/obY/BWQ/R9mQt3q/1W+ID2R/4diS/ dn/a1nK+sdwKb8JBIlSlFeQhAvgtUGmxIDyzJJrUQg== X-Google-Smtp-Source: APXvYqy/AKGSo15DXUV1VHmJaTP8/sfbAtmwyM6qsJnZ0s7CRGTWMHJ7xZ5b5fHI3a6UNJekH+6m3F9i4rgssApSRAc= X-Received: by 2002:a37:8343:: with SMTP id f64mr12901966qkd.21.1581932333854; Mon, 17 Feb 2020 01:38:53 -0800 (PST) MIME-Version: 1.0 References: <20200211210618.GA29823@embeddedor> In-Reply-To: <20200211210618.GA29823@embeddedor> From: Bartosz Golaszewski Date: Mon, 17 Feb 2020 10:38:43 +0100 Message-ID: Subject: Re: [PATCH] gpio: uniphier: Replace zero-length array with flexible-array member To: "Gustavo A. R. Silva" Cc: Linus Walleij , Masahiro Yamada , linux-gpio , arm-soc , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org wt., 11 lut 2020 o 22:03 Gustavo A. R. Silva napisa=C5=82(a): > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2]= , > introduced in C99: > > struct foo { > int stuff; > struct boo array[]; > }; > > By making use of the mechanism above, we will get a compiler warning > in case the flexible array does not occur last in the structure, which > will help us prevent some kind of undefined behavior bugs from being > inadvertenly introduced[3] to the codebase from now on. > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") > > Signed-off-by: Gustavo A. R. Silva Patch applied, thanks! Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB09DC35254 for ; Mon, 17 Feb 2020 09:39:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8216C2070B for ; Mon, 17 Feb 2020 09:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WKS9YZ1v"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="0FeSRJlL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8216C2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b0xX8rEnFjBSLYhNx2PlL07B2jGBpYd00V0qrhwsqio=; b=WKS9YZ1vLabA4R OeCzZ3mpxy5HGhb7T2SPdMY6WwVpPMVbdVUDOJvTif2jn0xvTSaayXEQ0kQFSQX8jjHT8OB+9yxa+ Jzp5ev9l+pUlC1+ZuDAYs4aEBbzS4DZp6VHB+2bF3y/BhlYuid8ku68Omxz3XfeVHW3UIiu3CGPce olZ2+jyVY0JBIXSqlCfQMD17pvMHH7AbjA01mB3jbEYt3uJ7LgYQhW21TV8BWtfMs4kSFtpgW7A2j +1udT72+glHlCj6uZth3RXLOwjz8iwIZ2DRHiy2WJdp9NI2RWz7yaD9P7CuXtKChLBVLKNlNkm3t7 GOkQuYUa4/NxfrfxPKTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3cri-0007sm-GX; Mon, 17 Feb 2020 09:38:58 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3crf-0007s6-BZ for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 09:38:57 +0000 Received: by mail-qk1-x744.google.com with SMTP id p7so15571643qkh.10 for ; Mon, 17 Feb 2020 01:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Afwt3f5haicc54NjifQPcLwy6vygZPMQ4dpzw9cQKTs=; b=0FeSRJlLGZWcE4RRPtM4gSIGicjoUxKa7odOoqFd72hdA+O7Xh2FTW49Fm7Lpsu7Mi lh9RJGPKS+YWQzILdfhjbg2+ReSx1iyh/T9kJ1u7/SJZ6cgpgnWRAj/aO1VsoeNMHsj9 4tbh6ZUDZ9kxXD6jidbjINrLnHYHzPbiO/uF0q9hQWRzKnuE0Gdv9DEGu6I1nZCgpBMa IDiuVxZw031QBeoBhdhzfbPD6PdckAYJJjHUP5h4WH7M5YpAij0mqLKV58ZdYBbzUb+z GTs0x/6AOtVfey0ERi+0yuJiGWyYX9Lk6Tp27N3EfBD+oPIIYXmO6rJ9UttLRpQc0KuK 8KQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Afwt3f5haicc54NjifQPcLwy6vygZPMQ4dpzw9cQKTs=; b=NLCOuO4RyggGCQfXRPkQsIdR8z9bCmYJCmIjaIDvFj8u3xKNedYN8uVN5SIN08Xv7K 8f3dYHXGicrypsvbLp9yv+ZHjZfd4P6VBbW5lvtqsUI2dV1sBJlGTgrPXL9CppumJlWX CdK4FiId6X/gVwL5x6OAWqzXakjZK/LeKq1gVGhlAgrNjfVOHzYkePoFSKGKKzQb2Bvu OFZyAZPneMh1T0sxGKYDM05B0YW58ZnhZ/hk6I3eM0TnlyItTscP+sEioj6HTs1zv2pi uxeL4IWY8Toh/FOcyPECsooitKmsixLOADddNnq1uTYj2nkDBUBYkuANFAXhc2Q2Xu/V 4UGA== X-Gm-Message-State: APjAAAWGkYggE12YdF83/qogao+mS7q96rbgfJk1ZobjDxU/XTYae8PI iXdTShuujZ3h1xPbCwyrE0dw4BPb8VSyuQ/8JM409w== X-Google-Smtp-Source: APXvYqy/AKGSo15DXUV1VHmJaTP8/sfbAtmwyM6qsJnZ0s7CRGTWMHJ7xZ5b5fHI3a6UNJekH+6m3F9i4rgssApSRAc= X-Received: by 2002:a37:8343:: with SMTP id f64mr12901966qkd.21.1581932333854; Mon, 17 Feb 2020 01:38:53 -0800 (PST) MIME-Version: 1.0 References: <20200211210618.GA29823@embeddedor> In-Reply-To: <20200211210618.GA29823@embeddedor> From: Bartosz Golaszewski Date: Mon, 17 Feb 2020 10:38:43 +0100 Message-ID: Subject: Re: [PATCH] gpio: uniphier: Replace zero-length array with flexible-array member To: "Gustavo A. R. Silva" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_013855_393426_781BB53B X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Linus Walleij , LKML , arm-soc , linux-gpio Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org d3QuLCAxMSBsdXQgMjAyMCBvIDIyOjAzIEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1i ZWRkZWRvci5jb20+Cm5hcGlzYcWCKGEpOgo+Cj4gVGhlIGN1cnJlbnQgY29kZWJhc2UgbWFrZXMg dXNlIG9mIHRoZSB6ZXJvLWxlbmd0aCBhcnJheSBsYW5ndWFnZQo+IGV4dGVuc2lvbiB0byB0aGUg QzkwIHN0YW5kYXJkLCBidXQgdGhlIHByZWZlcnJlZCBtZWNoYW5pc20gdG8gZGVjbGFyZQo+IHZh cmlhYmxlLWxlbmd0aCB0eXBlcyBzdWNoIGFzIHRoZXNlIG9uZXMgaXMgYSBmbGV4aWJsZSBhcnJh eSBtZW1iZXJbMV1bMl0sCj4gaW50cm9kdWNlZCBpbiBDOTk6Cj4KPiBzdHJ1Y3QgZm9vIHsKPiAg ICAgICAgIGludCBzdHVmZjsKPiAgICAgICAgIHN0cnVjdCBib28gYXJyYXlbXTsKPiB9Owo+Cj4g QnkgbWFraW5nIHVzZSBvZiB0aGUgbWVjaGFuaXNtIGFib3ZlLCB3ZSB3aWxsIGdldCBhIGNvbXBp bGVyIHdhcm5pbmcKPiBpbiBjYXNlIHRoZSBmbGV4aWJsZSBhcnJheSBkb2VzIG5vdCBvY2N1ciBs YXN0IGluIHRoZSBzdHJ1Y3R1cmUsIHdoaWNoCj4gd2lsbCBoZWxwIHVzIHByZXZlbnQgc29tZSBr aW5kIG9mIHVuZGVmaW5lZCBiZWhhdmlvciBidWdzIGZyb20gYmVpbmcKPiBpbmFkdmVydGVubHkg aW50cm9kdWNlZFszXSB0byB0aGUgY29kZWJhc2UgZnJvbSBub3cgb24uCj4KPiBUaGlzIGlzc3Vl IHdhcyBmb3VuZCB3aXRoIHRoZSBoZWxwIG9mIENvY2NpbmVsbGUuCj4KPiBbMV0gaHR0cHM6Ly9n Y2MuZ251Lm9yZy9vbmxpbmVkb2NzL2djYy9aZXJvLUxlbmd0aC5odG1sCj4gWzJdIGh0dHBzOi8v Z2l0aHViLmNvbS9LU1BQL2xpbnV4L2lzc3Vlcy8yMQo+IFszXSBjb21taXQgNzY0OTc3MzI5MzJm ICgiY3hnYjMvbDJ0OiBGaXggdW5kZWZpbmVkIGJlaGF2aW91ciIpCj4KPiBTaWduZWQtb2ZmLWJ5 OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgoKUGF0Y2ggYXBw bGllZCwgdGhhbmtzIQoKQmFydG9zegoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=