From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D0CBC3A5A8 for ; Wed, 4 Sep 2019 06:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2359F22CED for ; Wed, 4 Sep 2019 06:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Pvsm0jkN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728922AbfIDG54 (ORCPT ); Wed, 4 Sep 2019 02:57:56 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:42660 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728604AbfIDG54 (ORCPT ); Wed, 4 Sep 2019 02:57:56 -0400 Received: by mail-ot1-f67.google.com with SMTP id c10so8189711otd.9 for ; Tue, 03 Sep 2019 23:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Dt75WhUIfHVQfvigwZn6/besGZVEJEtBIQcEOqZ+B54=; b=Pvsm0jkNiRhObMK4vm9PFjK6gDG1RInx1dfQIY+anapAMmQ7BBqa+FSp2oQcED/5ZB fMFHq1bQSJaQxWDjSZDwYSgSZiGzcMYKOHp3BHHpvmkR/bFVtnN1/nZhEyIerU3Ius5Z nhj9GQwxsboOGg+Xy6lXBu8TMN5aY7NAg746v/3ONWMWbQRN3cS84RI2pA4veYqocRhW Tk70wmmQirUWHbVtRF2QYa5Fa7ZUVBzx4h5df3jv2vIplCQB6rnVK09hgrU5zieTdwdI HxM/Gs7C8qN25BCH3ub6QKRMsgVuWSajuOJsabMCCXmOevSJjqfqamqw3aKhEiPWNJMV /Q6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Dt75WhUIfHVQfvigwZn6/besGZVEJEtBIQcEOqZ+B54=; b=h63SLS5b8p4fyRzz8/cmS8IepJ2oVH1CzuzIzftoH68KlvvFQIZjjsu+GWYSbo1KQe M67H2KQjb6UVV07rD14KNmiP3nAyI6oFiWNiVaw40vVAJvhWDsMAwArxVLPoGLUMw2Q0 +CzdKKNCfws0o4D/b+IsZHzgHNe8XhPALQbOQUcP4iC9LOJrUfy0HdhS/vWoJkBqkFQY VsnP1+wFsY02GsUKpDQX2wS8xRw9woTqIyHy4sXjZkWscNl4I9jfBVYvIKDs4OJE9uJH To+i6c0Vn6tAmg/QD9OXO3fz1lA87z+23q0FiB3E2w6KHO29UpQcdeV/4nxws9uVS3Gr G3iA== X-Gm-Message-State: APjAAAWLgQK30zDWydM6zzdqv+gCoahEm3bm2GCWBMWw6gRO/GHDhl7t NZRhq8C+GQ3IuE/4nRURgsVPADgBJ9InqdUVSam6vw== X-Google-Smtp-Source: APXvYqwU0uoAvsRitFcgVrGOxLPCnceC5cmEGe0+fYS1mNopOondiib3itWCLOA9ZD86Hadp9khJFTIPsIhusxb2mrI= X-Received: by 2002:a9d:6c0d:: with SMTP id f13mr1329516otq.85.1567580275770; Tue, 03 Sep 2019 23:57:55 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> In-Reply-To: <20190904061245.30770-1-rashmica.g@gmail.com> From: Bartosz Golaszewski Date: Wed, 4 Sep 2019 08:57:44 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks To: Rashmica Gupta Cc: Linus Walleij , linux-gpio , arm-soc , linux-aspeed@lists.ozlabs.org, LKML , Joel Stanley , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org =C5=9Br., 4 wrz 2019 o 08:13 Rashmica Gupta napisa= =C5=82(a): > > Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') > Please, add a proper commit description. Checkpatch should have warned you about it. Bart > Signed-off-by: Rashmica Gupta > --- > drivers/gpio/gpio-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > index 9defe25d4721..77752b2624e8 100644 > --- a/drivers/gpio/gpio-aspeed.c > +++ b/drivers/gpio/gpio-aspeed.c > @@ -1165,7 +1165,7 @@ static int __init aspeed_gpio_probe(struct platform= _device *pdev) > gpio->chip.base =3D -1; > > /* Allocate a cache of the output registers */ > - banks =3D gpio->config->nr_gpios >> 5; > + banks =3D (gpio->config->nr_gpios >> 5) + 1; > gpio->dcache =3D devm_kcalloc(&pdev->dev, > banks, sizeof(u32), GFP_KERNEL); > if (!gpio->dcache) > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B389EC3A5A8 for ; Wed, 4 Sep 2019 06:58:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8435B22CED for ; Wed, 4 Sep 2019 06:58:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hT1X5Lmp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Pvsm0jkN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8435B22CED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p/lQb30KJhJqSkWFJt9AiA2Zx05eUkQntL4al24EGaA=; b=hT1X5LmpMPOXHm 69KJDeajOLqTAfflvlojhkDIcTIkkm/8VaTSODIGYa8yjKqh0QVH5YfuFMMapbmNkc4XhqBOeBLj+ +zpbnKS49BirE8+W4C0x1mOuUjWGUnEEB7t/AeL9XIOoNO4CmLrw68CoMhrXk3o3aKm3iX/I1U8rz 7aZ9z0PYD89h4uSTbRD0v9tQQ2X+rsLO5HNQ14ME+oH7VePq8SGYXNYieMKMOoZdLomxvSeIXiJwM Xofr/xXEZ63/37SDgnOqQnzWnVaPIxcT+zixQNq0w16gdj1Y6fZK5gaHxrfMu0k4NpWIMIo3gxFpv 7NiBNrieFauWulkW4+Fw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5PEy-00009j-Ax; Wed, 04 Sep 2019 06:58:04 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5PEs-0008Vd-Rj for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 06:58:00 +0000 Received: by mail-ot1-x342.google.com with SMTP id r20so19558835ota.5 for ; Tue, 03 Sep 2019 23:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Dt75WhUIfHVQfvigwZn6/besGZVEJEtBIQcEOqZ+B54=; b=Pvsm0jkNiRhObMK4vm9PFjK6gDG1RInx1dfQIY+anapAMmQ7BBqa+FSp2oQcED/5ZB fMFHq1bQSJaQxWDjSZDwYSgSZiGzcMYKOHp3BHHpvmkR/bFVtnN1/nZhEyIerU3Ius5Z nhj9GQwxsboOGg+Xy6lXBu8TMN5aY7NAg746v/3ONWMWbQRN3cS84RI2pA4veYqocRhW Tk70wmmQirUWHbVtRF2QYa5Fa7ZUVBzx4h5df3jv2vIplCQB6rnVK09hgrU5zieTdwdI HxM/Gs7C8qN25BCH3ub6QKRMsgVuWSajuOJsabMCCXmOevSJjqfqamqw3aKhEiPWNJMV /Q6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Dt75WhUIfHVQfvigwZn6/besGZVEJEtBIQcEOqZ+B54=; b=U8hXzwY/N0VCCKfHEljkZbqT6nusSc54121IYNpMcHzuu8JSgBLRWTmTwvR9nhJrC1 FP431hOw+KgyTwKqSNdzKADDQ0K8AOtGdcg4NOexbdh6e6mMx8a/UkVQy7OgvwcZ1pcj 0pQtjVdJZfYkcW7j3zHEd2g28xcsvMNSaizyY5wIA9+ituoTxIp6eLS0R/eU3wsPWvgT aPHB0RtTrhvmJ/P9ZzLCddWZIGYxMNlYPV8m7gBF/jS7tgGkDQvGjsvdQyyr9MLOaLTM 2hLnKa+237VNgTruymkjdk79i2tOAihlIHAiUJ49X3S0d6tiyN2gpJSvvrVn/PLFwrA9 +jIw== X-Gm-Message-State: APjAAAU/1ZrVkB5jXb8Xd76VUA6q5sV/mVarv0NjzHohmxrxP0i0I44Z //HYKYzBQ/HT+YPJUrcCnoerl2WnJLRGXeUqbxUIdg== X-Google-Smtp-Source: APXvYqwU0uoAvsRitFcgVrGOxLPCnceC5cmEGe0+fYS1mNopOondiib3itWCLOA9ZD86Hadp9khJFTIPsIhusxb2mrI= X-Received: by 2002:a9d:6c0d:: with SMTP id f13mr1329516otq.85.1567580275770; Tue, 03 Sep 2019 23:57:55 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> In-Reply-To: <20190904061245.30770-1-rashmica.g@gmail.com> From: Bartosz Golaszewski Date: Wed, 4 Sep 2019 08:57:44 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks To: Rashmica Gupta X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_235758_993395_4C3237FB X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Linus Walleij , LKML , linux-gpio , Joel Stanley , arm-soc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org xZtyLiwgNCB3cnogMjAxOSBvIDA4OjEzIFJhc2htaWNhIEd1cHRhIDxyYXNobWljYS5nQGdtYWls LmNvbT4gbmFwaXNhxYIoYSk6Cj4KPiBGaXhlczogMzYxYjc5MTE5YTRiNyAoJ2dwaW86IEFkZCBB c3BlZWQgZHJpdmVyJykKPgoKUGxlYXNlLCBhZGQgYSBwcm9wZXIgY29tbWl0IGRlc2NyaXB0aW9u LiBDaGVja3BhdGNoIHNob3VsZCBoYXZlIHdhcm5lZAp5b3UgYWJvdXQgaXQuCgpCYXJ0Cgo+IFNp Z25lZC1vZmYtYnk6IFJhc2htaWNhIEd1cHRhIDxyYXNobWljYS5nQGdtYWlsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncGlvL2dwaW8tYXNwZWVkLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3Bp by9ncGlvLWFzcGVlZC5jIGIvZHJpdmVycy9ncGlvL2dwaW8tYXNwZWVkLmMKPiBpbmRleCA5ZGVm ZTI1ZDQ3MjEuLjc3NzUyYjI2MjRlOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwaW8vZ3Bpby1h c3BlZWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3Bpby9ncGlvLWFzcGVlZC5jCj4gQEAgLTExNjUsNyAr MTE2NSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGFzcGVlZF9ncGlvX3Byb2JlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAgICBncGlvLT5jaGlwLmJhc2UgPSAtMTsKPgo+ICAg ICAgICAgLyogQWxsb2NhdGUgYSBjYWNoZSBvZiB0aGUgb3V0cHV0IHJlZ2lzdGVycyAqLwo+IC0g ICAgICAgYmFua3MgPSBncGlvLT5jb25maWctPm5yX2dwaW9zID4+IDU7Cj4gKyAgICAgICBiYW5r cyA9IChncGlvLT5jb25maWctPm5yX2dwaW9zID4+IDUpICsgMTsKPiAgICAgICAgIGdwaW8tPmRj YWNoZSA9IGRldm1fa2NhbGxvYygmcGRldi0+ZGV2LAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJhbmtzLCBzaXplb2YodTMyKSwgR0ZQX0tFUk5FTCk7Cj4gICAgICAgICBp ZiAoIWdwaW8tPmRjYWNoZSkKPiAtLQo+IDIuMjAuMQo+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==