From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E7EEC169C4 for ; Fri, 8 Feb 2019 12:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B74820857 for ; Fri, 8 Feb 2019 12:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ieGfk5dQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727560AbfBHMsI (ORCPT ); Fri, 8 Feb 2019 07:48:08 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:43527 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbfBHMsI (ORCPT ); Fri, 8 Feb 2019 07:48:08 -0500 Received: by mail-ot1-f66.google.com with SMTP id a11so5546175otr.10 for ; Fri, 08 Feb 2019 04:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JWzV0M0DRGDSHP1/88xQPKP0xbprssAo28cl+Ap6wNM=; b=ieGfk5dQ4O40tNc6NnZ4JeBT1H0kM6WLPymOjxvvkInUU1szdAv052OyksGLlVaeTj hDJFRn+9OHbhXfIWpx0q//LKyMAn1B7TkEBe7lZh1I42nOf8ToYTxr9a3YQ4jVMoJEM6 6ZUa+yc8DStA524HuJ6zwZu93BWXvXetlgqMdANDJtnUdZScdvGbIN+lPUWfeyEVjAEk RHLFA+S4CPkJpsHrmRYGvYjeT7v4CQKJfxHLwCLiV8oMPL/FR2ABQ+2JVmM2nEB3KGdJ NjhyC8Cq3Fq+Q91eVmAb8jJen/YhWtJHpR0q5OrqHF+X5cIgnzHuU7NrrJ45mYDe98MM qBGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JWzV0M0DRGDSHP1/88xQPKP0xbprssAo28cl+Ap6wNM=; b=jw7/3Al246Aam5kcJZ3tBgYE3i1VV4Tz+L1vEOLoKvd8yBEcAE7dP8rsf7ojFOxrMU KRcsLP65Q7hxS05ZOE0AHUz6TQFPh/u2fW3I8w0ph2X1BjovmBob+nEp9mNrgEGqiTJv PDbaStmhtc1bNW8kX17vdAxbtHsIfvnQSc5SDzP3CdYKP1ioZ78Q1QIXdiAlxMu1nXWZ 53mLUK1hZouj/viE+Ws4aOmXiLhHw3IDJdQHto7BKa/cMaat2fN/LhCMA5tPwcANksRg ycTCAfq5+I2cMLw2AzRSsnCbBv3r2v/cHkp1CIqPRPnDhET6NXJXw3TYs7iKc6Fr5U8J xx3w== X-Gm-Message-State: AHQUAuZ2QyC2dYM1ps2kI+rO9LAZqP0DMCzecpuP6QB8mPd+wEFh3XmS R6c8zEUEYxBuSyxu/CaLRHaZl4WtF9DimsRIJjMseQ== X-Google-Smtp-Source: AHgI3Ial+h5E9Y271MzSd0t0lZHzB/vXzwxcYRl1ZDWcV0xgScVWDgDusw+8T2RGaYgTewepPiemzptpCz2QRltdDe0= X-Received: by 2002:a9d:4595:: with SMTP id x21mr4070807ote.234.1549630087103; Fri, 08 Feb 2019 04:48:07 -0800 (PST) MIME-Version: 1.0 References: <20190204171757.32073-1-brgl@bgdev.pl> <20190204171757.32073-6-brgl@bgdev.pl> <9d423e18-8c85-731b-388a-1843067db242@ti.com> In-Reply-To: From: Bartosz Golaszewski Date: Fri, 8 Feb 2019 13:47:56 +0100 Message-ID: Subject: Re: [PATCH v2 05/12] ARM: davinci: da850: switch to using the clocksource driver To: Sekhar Nori Cc: Bartosz Golaszewski , Kevin Hilman , Daniel Lezcano , Rob Herring , Mark Rutland , Thomas Gleixner , arm-soc , LKML , linux-devicetree Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pt., 8 lut 2019 o 13:37 Sekhar Nori napisa=C5=82(a): > > On 08/02/19 6:04 PM, Bartosz Golaszewski wrote: > > pt., 8 lut 2019 o 13:06 Sekhar Nori napisa=C5=82(a): > >> > >> On 04/02/19 10:47 PM, Bartosz Golaszewski wrote: > >>> +static const struct davinci_timer_cfg da850_timer_cfg =3D { > >>> + .reg =3D { > >>> + .start =3D DA8XX_TIMER64P0_BASE, > >>> + .end =3D DA8XX_TIMER64P0_BASE + SZ_4K, > >> > >> SZ_4K - 1 > >> > >> This should have prevented watchdog timer from getting registered. > >> > >> Thanks, > >> Sekhar > > > > My clocksource driver doesn't call request_region() so a subsequent > > devm_ioremap_resource() in the watchdog driver would still succeed. I > > now fixed both the missing call and the value here. > > Ah, got it. Perhaps a call to request_region() should be added to catch > issues? > Yes, that's what I meant by "fixing the missing call". It will be there in v3. Actually the kernel seems to be missing a non-managed ioremap_resource() helper. Maybe I should add it as well. Bart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartosz Golaszewski Subject: Re: [PATCH v2 05/12] ARM: davinci: da850: switch to using the clocksource driver Date: Fri, 8 Feb 2019 13:47:56 +0100 Message-ID: References: <20190204171757.32073-1-brgl@bgdev.pl> <20190204171757.32073-6-brgl@bgdev.pl> <9d423e18-8c85-731b-388a-1843067db242@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sekhar Nori Cc: Mark Rutland , linux-devicetree , Kevin Hilman , Bartosz Golaszewski , Daniel Lezcano , LKML , Rob Herring , Thomas Gleixner , arm-soc List-Id: devicetree@vger.kernel.org cHQuLCA4IGx1dCAyMDE5IG8gMTM6MzcgU2VraGFyIE5vcmkgPG5zZWtoYXJAdGkuY29tPiBuYXBp c2HFgihhKToKPgo+IE9uIDA4LzAyLzE5IDY6MDQgUE0sIEJhcnRvc3ogR29sYXN6ZXdza2kgd3Jv dGU6Cj4gPiBwdC4sIDggbHV0IDIwMTkgbyAxMzowNiBTZWtoYXIgTm9yaSA8bnNla2hhckB0aS5j b20+IG5hcGlzYcWCKGEpOgo+ID4+Cj4gPj4gT24gMDQvMDIvMTkgMTA6NDcgUE0sIEJhcnRvc3og R29sYXN6ZXdza2kgd3JvdGU6Cj4gPj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRhdmluY2lfdGlt ZXJfY2ZnIGRhODUwX3RpbWVyX2NmZyA9IHsKPiA+Pj4gKyAgICAgLnJlZyA9IHsKPiA+Pj4gKyAg ICAgICAgICAgICAuc3RhcnQgICAgICAgICAgPSBEQThYWF9USU1FUjY0UDBfQkFTRSwKPiA+Pj4g KyAgICAgICAgICAgICAuZW5kICAgICAgICAgICAgPSBEQThYWF9USU1FUjY0UDBfQkFTRSArIFNa XzRLLAo+ID4+Cj4gPj4gU1pfNEsgLSAxCj4gPj4KPiA+PiBUaGlzIHNob3VsZCBoYXZlIHByZXZl bnRlZCB3YXRjaGRvZyB0aW1lciBmcm9tIGdldHRpbmcgcmVnaXN0ZXJlZC4KPiA+Pgo+ID4+IFRo YW5rcywKPiA+PiBTZWtoYXIKPiA+Cj4gPiBNeSBjbG9ja3NvdXJjZSBkcml2ZXIgZG9lc24ndCBj YWxsIHJlcXVlc3RfcmVnaW9uKCkgc28gYSBzdWJzZXF1ZW50Cj4gPiBkZXZtX2lvcmVtYXBfcmVz b3VyY2UoKSBpbiB0aGUgd2F0Y2hkb2cgZHJpdmVyIHdvdWxkIHN0aWxsIHN1Y2NlZWQuIEkKPiA+ IG5vdyBmaXhlZCBib3RoIHRoZSBtaXNzaW5nIGNhbGwgYW5kIHRoZSB2YWx1ZSBoZXJlLgo+Cj4g QWgsIGdvdCBpdC4gUGVyaGFwcyBhIGNhbGwgdG8gcmVxdWVzdF9yZWdpb24oKSBzaG91bGQgYmUg YWRkZWQgdG8gY2F0Y2gKPiBpc3N1ZXM/Cj4KClllcywgdGhhdCdzIHdoYXQgSSBtZWFudCBieSAi Zml4aW5nIHRoZSBtaXNzaW5nIGNhbGwiLiBJdCB3aWxsIGJlCnRoZXJlIGluIHYzLiBBY3R1YWxs eSB0aGUga2VybmVsIHNlZW1zIHRvIGJlIG1pc3NpbmcgYSBub24tbWFuYWdlZAppb3JlbWFwX3Jl c291cmNlKCkgaGVscGVyLiBNYXliZSBJIHNob3VsZCBhZGQgaXQgYXMgd2VsbC4KCkJhcnQKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK