From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B47BC12002 for ; Fri, 16 Jul 2021 08:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D1E5611AC for ; Fri, 16 Jul 2021 08:14:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236777AbhGPIRX (ORCPT ); Fri, 16 Jul 2021 04:17:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236342AbhGPIRX (ORCPT ); Fri, 16 Jul 2021 04:17:23 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8375C06175F for ; Fri, 16 Jul 2021 01:14:28 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id t186so13536639ybf.2 for ; Fri, 16 Jul 2021 01:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/LTJmXuzBUFzzcssWYYOL1YI3GgpOb+6Dm26cGPPXco=; b=lvllShBY36EhoOvyLflbD5SqvOHgXlVRd0BND8GkTXJkU0XDztOrsBdYYXiTmhqSOd Ucd3uDXyzfss9cTJeDLQrjV+KVg/tZASDlFHiZYvP3Ryx18Cl8fO14fPpBoWu3IX/lQ2 536emUH59DeCudBg/WAYvZu7ZJuAvY4Z6I4YjUjyMKKtg5KJMQSc7Hb/Yr9dnTAfR6V+ miWBK+WZA77U9YjJ0bwdX5ZnPPrk/nQ5h2qWuRXw/P7LFscG0cAuTbLbLN7xOoKjuvBn ByiK0ogNfAvpFTXC+tOoIZEEgbMBaHLrvYt6YHQNesOKBrMKwIA7ZUn3fz3S6bF15B2f pYpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/LTJmXuzBUFzzcssWYYOL1YI3GgpOb+6Dm26cGPPXco=; b=bxRvFJ8UHBkXJ6ElPjctA0UIhBl4gIYbU8OA4Zn7tEWx0ZPloo94UnLJL4Ixr50E0U FiJ6/QVJPjQlHTj+LjcCNgPMtdmiSFqBfnAc4mGCPG6SGlG6TP7H/QfrcZ3A/f0YDk13 g5z90U/dDoRTqoHIZLwD0kBLsJdkxm9+kmip3OU+xdnLZgUPc7faQ6P/VhyL0B5aLHu4 FAoUx3XFGsVlhq2rkNTKxmYhUshkp2awdjdmlnFL2KI9Lu4mXxFFW/GX/tCDPnEwNiz8 tFoJF/26Xka4KYf0mmY0SoitMOMjQQPbZyB9Kt92/+JsucbvsSUXpORDpOAXgQ1IR3ZV /ipA== X-Gm-Message-State: AOAM532EgJgHujepDQfGR0wiQxvDaLCo4ToG4nMC3dfohAutatyh15GA xlR3LA+LEEowDPEBHDpgVafrH5sUOowAFLoRb8vo9A== X-Google-Smtp-Source: ABdhPJzoiSlV4UPQgTJnY+HNihGEEyHLw/Ci9EaV/2UUCc0BH7/mPrhygI6wJGknqNifMEX/RADCpvfFm1B0j8OBZzQ= X-Received: by 2002:a25:1804:: with SMTP id 4mr11086581yby.157.1626423267892; Fri, 16 Jul 2021 01:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20210715191141.430307-1-linus.walleij@linaro.org> In-Reply-To: <20210715191141.430307-1-linus.walleij@linaro.org> From: Bartosz Golaszewski Date: Fri, 16 Jul 2021 10:14:17 +0200 Message-ID: Subject: Re: [PATCH 1/3 v6] gpio: pcf857x: Name instance after dev_name() To: Linus Walleij Cc: Sekhar Nori , arm-soc , linux-gpio Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Jul 15, 2021 at 9:13 PM Linus Walleij wrote: > > Put the label on this gpio_chip from the dev_name() instead of > the client name. > > The client name will be pcf8574 etc for all instances even if > there are several chips on a system. > > This manifests on the DaVinci DM6467 (non-devicetree) which > will contain 3 different pcf8574 devices that as a result cannot > be told apart because they are all named "pcf8574", affecting > the GPIO descriptor tables which need a unique label per chip. > > By passing in .dev_name in the struct i2c_board_info we can > explicitly name each instance and use that to discern the chips > when using board files. > > Cc: Sekhar Nori > Cc: Bartosz Golaszewski > Signed-off-by: Linus Walleij > --- > ChangeLog v5->v6: > - Rebase on v5.14-rc1 > ChangeLog ->v5: > - New patch to deal with the chip label > --- > drivers/gpio/gpio-pcf857x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c > index b7568ee33696..2271ec86e414 100644 > --- a/drivers/gpio/gpio-pcf857x.c > +++ b/drivers/gpio/gpio-pcf857x.c > @@ -311,7 +311,7 @@ static int pcf857x_probe(struct i2c_client *client, > if (status < 0) > goto fail; > > - gpio->chip.label = client->name; > + gpio->chip.label = dev_name(&client->dev); > > gpio->client = client; > i2c_set_clientdata(client, gpio); > -- > 2.31.1 > Reviewed-by: Bartosz Golaszewski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2D0C636CA for ; Fri, 16 Jul 2021 08:16:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A41FE611C0 for ; Fri, 16 Jul 2021 08:16:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A41FE611C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VfdOJGeHbhjbUV94IJWSOjNBqzCZ1UKe6MmhHDEv1Ug=; b=oc+q6hE8r5ilre jGyXts7FO929KzuqfGaz4WdahuM9nSBQuW1Nzo/9SI+s3Qr8ZUS1mLBA6cYdkSnP6zOLTyRcH1bnR bdKOYh8J+V6jjcFTl5fQC4WMK7wUCZKOqL5/qBLfdNmko1IfifziM+Zs97O5qpQ4x7aYrgwnw6bo9 c8RhGyT/7m6ySLr3NyauGTjnp2Evdt4FvtAYod7D0YKnfp2u0kfVVL0vNeYBrYO0QZ4zpKi6By+FH cgHOIXLpGHumEgh/7aigRtTvJGYU1EfUaKFW5BqkMCJksEGs+yAEd4KCIkxj1r3anjjeODIbqkbfV jtNYeWov2xVZQUYl7fng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4IzS-003f7S-7S; Fri, 16 Jul 2021 08:14:34 +0000 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4IzO-003f6l-2y for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 08:14:32 +0000 Received: by mail-yb1-xb31.google.com with SMTP id p22so13529660yba.7 for ; Fri, 16 Jul 2021 01:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/LTJmXuzBUFzzcssWYYOL1YI3GgpOb+6Dm26cGPPXco=; b=lvllShBY36EhoOvyLflbD5SqvOHgXlVRd0BND8GkTXJkU0XDztOrsBdYYXiTmhqSOd Ucd3uDXyzfss9cTJeDLQrjV+KVg/tZASDlFHiZYvP3Ryx18Cl8fO14fPpBoWu3IX/lQ2 536emUH59DeCudBg/WAYvZu7ZJuAvY4Z6I4YjUjyMKKtg5KJMQSc7Hb/Yr9dnTAfR6V+ miWBK+WZA77U9YjJ0bwdX5ZnPPrk/nQ5h2qWuRXw/P7LFscG0cAuTbLbLN7xOoKjuvBn ByiK0ogNfAvpFTXC+tOoIZEEgbMBaHLrvYt6YHQNesOKBrMKwIA7ZUn3fz3S6bF15B2f pYpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/LTJmXuzBUFzzcssWYYOL1YI3GgpOb+6Dm26cGPPXco=; b=m8Hf8yW6UT2Xev6ZF3lJ2gO1DDCG1XiEiNrooQ7zafswDY0sOzd9pXQpClKEAcpfH1 CJYRRWDZI8MpvuySFd0aN+LBEgc4SjX4pwA8OjNta1PsVPq5+evPIPF/Lb54udJAUGqw DBRgm8QJGIDZ5tplT6DmRZWAr2eZ6s0Dhj0ZRmubv/WhSgCq+ZGjoE8Al2c42v1H+XZW np51w0X/HDFQMlmlaHavyXaqaVR0pI5oaCu8XEpg/NqOjQRAOD4PkzxNJK00LCthLSCV 3jmloHaNR9duk2LNHFG5GIlVIKAl82uyaYHqyKYj63KFUpSPICEiHKJVcZFfpwLDH2Xp KoKA== X-Gm-Message-State: AOAM533ksIIiT0WCNtc5xW65SXHhiAOhaaAOWPfu4zc7NLfDE6AiktsE LyheuRR28+waWcCqP2MCXEwr4Lgz/6tJoxHnwJTv+Q== X-Google-Smtp-Source: ABdhPJzoiSlV4UPQgTJnY+HNihGEEyHLw/Ci9EaV/2UUCc0BH7/mPrhygI6wJGknqNifMEX/RADCpvfFm1B0j8OBZzQ= X-Received: by 2002:a25:1804:: with SMTP id 4mr11086581yby.157.1626423267892; Fri, 16 Jul 2021 01:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20210715191141.430307-1-linus.walleij@linaro.org> In-Reply-To: <20210715191141.430307-1-linus.walleij@linaro.org> From: Bartosz Golaszewski Date: Fri, 16 Jul 2021 10:14:17 +0200 Message-ID: Subject: Re: [PATCH 1/3 v6] gpio: pcf857x: Name instance after dev_name() To: Linus Walleij Cc: Sekhar Nori , arm-soc , linux-gpio X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_011430_213519_ADA48D40 X-CRM114-Status: GOOD ( 22.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 9:13 PM Linus Walleij wrote: > > Put the label on this gpio_chip from the dev_name() instead of > the client name. > > The client name will be pcf8574 etc for all instances even if > there are several chips on a system. > > This manifests on the DaVinci DM6467 (non-devicetree) which > will contain 3 different pcf8574 devices that as a result cannot > be told apart because they are all named "pcf8574", affecting > the GPIO descriptor tables which need a unique label per chip. > > By passing in .dev_name in the struct i2c_board_info we can > explicitly name each instance and use that to discern the chips > when using board files. > > Cc: Sekhar Nori > Cc: Bartosz Golaszewski > Signed-off-by: Linus Walleij > --- > ChangeLog v5->v6: > - Rebase on v5.14-rc1 > ChangeLog ->v5: > - New patch to deal with the chip label > --- > drivers/gpio/gpio-pcf857x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c > index b7568ee33696..2271ec86e414 100644 > --- a/drivers/gpio/gpio-pcf857x.c > +++ b/drivers/gpio/gpio-pcf857x.c > @@ -311,7 +311,7 @@ static int pcf857x_probe(struct i2c_client *client, > if (status < 0) > goto fail; > > - gpio->chip.label = client->name; > + gpio->chip.label = dev_name(&client->dev); > > gpio->client = client; > i2c_set_clientdata(client, gpio); > -- > 2.31.1 > Reviewed-by: Bartosz Golaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel