From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D253C433E0 for ; Wed, 10 Feb 2021 13:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0966264E77 for ; Wed, 10 Feb 2021 13:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbhBJN0U (ORCPT ); Wed, 10 Feb 2021 08:26:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbhBJN0P (ORCPT ); Wed, 10 Feb 2021 08:26:15 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3809C061756 for ; Wed, 10 Feb 2021 05:25:33 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id y18so2923178edw.13 for ; Wed, 10 Feb 2021 05:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a5P3pXqsbExwoBP/miAImNEdFWZXxnHrDvNJnbzyXCU=; b=dOPtjQucHUQBnPjtYZ6SUrbg/sixrKkmgFF2h4JYMQnw/WPBs5hZfAEOazfKi1N8OA nNHL+QhlgZmPibA9meGj1nzLhnMZ6E60gGy8HHfHAkmdH+rJPqnb+56inCFiJqrA8jWI eCVn9vwqgzMFKNdxOkVxRVeMe9mfTAAybqeGShTNgRMiwsUzAJatyDktIPkcLTDJT6gD OWtSfGmAafaO3rKQzqtAzbph+4pt+0UZS7V79jDtIIIqHHL2/Z3TQFRUIdlqcfIoKYGw sc2R+cnnJljZcSU+Bra491nqkXMmpPrR9YljVQihJse7PKwDCqCXaKqnGd5EqsEErtfQ WYvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a5P3pXqsbExwoBP/miAImNEdFWZXxnHrDvNJnbzyXCU=; b=dS7OViRtj2OUr90GyBU6T2YWOVPpuEvhX2RH6kEKYkPjejjk1Ybf2HpaG3si2mNUZi mLlmVGqj8yTbAMoIJbHnoJvjbl7naS0ewws1knhD0fHt40yemDRrUYrWVJbOXxUJHhur nBVDklTADZZ5AHoZrqEC9Y6r64kduj4QaiN1fF474itBrg0ViSgAPvbsHTWPl4WwXs7j rOsuH+iIq9+Dca2GOSnlpihY+TjOhCfAT2AY51YGjyswOeAyRgKMGpRRCSduzt1zub7v H8yY0LwJHEguCmqdRzsDQ0XUrzFR0jOM/os11fYJQF0yj16bbUNCEtOf8Gg7F5FOLpD1 3M0Q== X-Gm-Message-State: AOAM530+39LJe1t99HnQJDm/dcu66JKhSYlhMsKHI6gYx3eCWOkDodiZ 1xQjpLjOz4MjENb/ECaz08Cy6jV8sFP6xtAf71bayA== X-Google-Smtp-Source: ABdhPJx0XjOijGpI4Y3SIRmENJCxby/axDriiAPKWAWAH1+8PiBt6viO3sEYajqmpp9hEQdUYN9THF+FyETxh470V+s= X-Received: by 2002:a50:fe11:: with SMTP id f17mr3135651edt.88.1612963532354; Wed, 10 Feb 2021 05:25:32 -0800 (PST) MIME-Version: 1.0 References: <20210208145153.422093-1-geert+renesas@glider.be> In-Reply-To: <20210208145153.422093-1-geert+renesas@glider.be> From: Bartosz Golaszewski Date: Wed, 10 Feb 2021 14:25:21 +0100 Message-ID: Subject: Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally To: Geert Uytterhoeven Cc: Anson Huang , Shawn Guo , Sascha Hauer , Linus Walleij , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-gpio , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven wrote: > > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS, > and ask the user in case of compile-testing. > > Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS") > Signed-off-by: Geert Uytterhoeven > --- > drivers/gpio/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5fdf526fe973da38..412728ff2ab45c0d 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -442,8 +442,9 @@ config GPIO_MXC > select GENERIC_IRQ_CHIP > > config GPIO_MXS > - def_bool y > + bool "Freescale MXS GPIO support" if COMPILE_TEST > depends on ARCH_MXS || COMPILE_TEST > + default y if ARCH_MXS > select GPIO_GENERIC > select GENERIC_IRQ_CHIP > > -- > 2.25.1 > Applied, thanks! Bartosz