All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-doc <linux-doc@vger.kernel.org>
Subject: Re: [PATCH] Documentation: gpio: remove duplicated lines
Date: Fri, 10 May 2019 12:15:38 +0200	[thread overview]
Message-ID: <CAMpxmJVL3KLqgu9oRQOFmdAHq1jDbCCXxxq=cE1XyxX83zNgzg@mail.gmail.com> (raw)
In-Reply-To: <20190510090339.17211-1-luca@lucaceresoli.net>

pt., 10 maj 2019 o 11:03 Luca Ceresoli <luca@lucaceresoli.net> napisał(a):
>
> The 'default (active high)' lines are repeated twice. Avoid people stare at
> their screens looking for differences.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  Documentation/driver-api/gpio/consumer.rst | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/driver-api/gpio/consumer.rst b/Documentation/driver-api/gpio/consumer.rst
> index 5e4d8aa68913..23d68c321c5c 100644
> --- a/Documentation/driver-api/gpio/consumer.rst
> +++ b/Documentation/driver-api/gpio/consumer.rst
> @@ -283,8 +283,6 @@ To summarize::
>    gpiod_set_value(desc, 1);          default (active high)  high
>    gpiod_set_value(desc, 0);          active low             high
>    gpiod_set_value(desc, 1);          active low             low
> -  gpiod_set_value(desc, 0);          default (active high)  low
> -  gpiod_set_value(desc, 1);          default (active high)  high
>    gpiod_set_value(desc, 0);          open drain             low
>    gpiod_set_value(desc, 1);          open drain             high impedance
>    gpiod_set_value(desc, 0);          open source            high impedance
> --
> 2.21.0
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

  reply	other threads:[~2019-05-10 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10  9:03 [PATCH] Documentation: gpio: remove duplicated lines Luca Ceresoli
2019-05-10 10:15 ` Bartosz Golaszewski [this message]
2019-05-24 11:27 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMpxmJVL3KLqgu9oRQOFmdAHq1jDbCCXxxq=cE1XyxX83zNgzg@mail.gmail.com' \
    --to=bgolaszewski@baylibre.com \
    --cc=corbet@lwn.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.