From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302AbdB1L4J (ORCPT ); Tue, 28 Feb 2017 06:56:09 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:34920 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883AbdB1Lzl (ORCPT ); Tue, 28 Feb 2017 06:55:41 -0500 MIME-Version: 1.0 In-Reply-To: <6b392a4a-2de8-9981-ad40-ca7201bf813d@ti.com> References: <1487771027-7763-1-git-send-email-bgolaszewski@baylibre.com> <1487771027-7763-4-git-send-email-bgolaszewski@baylibre.com> <20170227225209.26oieqwbafqjga2a@rob-hp-laptop> <6b392a4a-2de8-9981-ad40-ca7201bf813d@ti.com> From: Bartosz Golaszewski Date: Tue, 28 Feb 2017 12:00:02 +0100 Message-ID: Subject: Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property To: Sekhar Nori Cc: Rob Herring , David Lechner , Kevin Hilman , Michael Turquette , Patrick Titiano , Laurent Pinchart , Mark Rutland , arm-soc , LKML , linux-devicetree Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-02-28 6:36 GMT+01:00 Sekhar Nori : > On Tuesday 28 February 2017 04:22 AM, Rob Herring wrote: >> On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote: >>> Add an optional property - enable-gpios - which can be used to specify >>> the GPIOs that must be requested to select the vpif functionality. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> index df7182a..23c5405 100644 >>> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> @@ -13,6 +13,9 @@ Required properties: >>> - reg: physical base address and length of the registers set for the device; >>> - interrupts: should contain IRQ line for the VPIF >>> >>> +Optional properties: >>> +- enable-gpios: phandle of the GPIOs used to select the vpif functionality >> >> What does this control exactly? The GPIOs belong in the node they are >> connected to and having GPIOs routed to this block seems strange. > > The DA850 EVM board implements on-board muxing which lets the video > input (via VPIF) to be routed to a TVP5147 (video decoder) for composite > input or to a camera header. There are other mux options which use the > same VPIF SoC pins (RMII ethernet or character LCD). > > There is a three-to-eight demux on the board which drives enable signals > to buffers letting you choose from these options. > > From your response, it looks like you want the enable-gpios property to > be in the TVP5147 or camera node. That does make sense to me. > Wouldn't that cause races again? The TVP5147 ADC is probed from within the vpif driver as a media subdev (after initialize_vpif(), v4l2_device_register(), irq requests etc.). Thanks, Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartosz Golaszewski Subject: Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Date: Tue, 28 Feb 2017 12:00:02 +0100 Message-ID: References: <1487771027-7763-1-git-send-email-bgolaszewski@baylibre.com> <1487771027-7763-4-git-send-email-bgolaszewski@baylibre.com> <20170227225209.26oieqwbafqjga2a@rob-hp-laptop> <6b392a4a-2de8-9981-ad40-ca7201bf813d@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6b392a4a-2de8-9981-ad40-ca7201bf813d@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sekhar Nori Cc: Mark Rutland , Rob Herring , David Lechner , linux-devicetree , Kevin Hilman , Michael Turquette , LKML , Laurent Pinchart , Patrick Titiano , arm-soc List-Id: devicetree@vger.kernel.org 2017-02-28 6:36 GMT+01:00 Sekhar Nori : > On Tuesday 28 February 2017 04:22 AM, Rob Herring wrote: >> On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote: >>> Add an optional property - enable-gpios - which can be used to specify >>> the GPIOs that must be requested to select the vpif functionality. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> index df7182a..23c5405 100644 >>> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> @@ -13,6 +13,9 @@ Required properties: >>> - reg: physical base address and length of the registers set for the device; >>> - interrupts: should contain IRQ line for the VPIF >>> >>> +Optional properties: >>> +- enable-gpios: phandle of the GPIOs used to select the vpif functionality >> >> What does this control exactly? The GPIOs belong in the node they are >> connected to and having GPIOs routed to this block seems strange. > > The DA850 EVM board implements on-board muxing which lets the video > input (via VPIF) to be routed to a TVP5147 (video decoder) for composite > input or to a camera header. There are other mux options which use the > same VPIF SoC pins (RMII ethernet or character LCD). > > There is a three-to-eight demux on the board which drives enable signals > to buffers letting you choose from these options. > > From your response, it looks like you want the enable-gpios property to > be in the TVP5147 or camera node. That does make sense to me. > Wouldn't that cause races again? The TVP5147 ADC is probed from within the vpif driver as a media subdev (after initialize_vpif(), v4l2_device_register(), irq requests etc.). Thanks, Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 From: bgolaszewski@baylibre.com (Bartosz Golaszewski) Date: Tue, 28 Feb 2017 12:00:02 +0100 Subject: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property In-Reply-To: <6b392a4a-2de8-9981-ad40-ca7201bf813d@ti.com> References: <1487771027-7763-1-git-send-email-bgolaszewski@baylibre.com> <1487771027-7763-4-git-send-email-bgolaszewski@baylibre.com> <20170227225209.26oieqwbafqjga2a@rob-hp-laptop> <6b392a4a-2de8-9981-ad40-ca7201bf813d@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017-02-28 6:36 GMT+01:00 Sekhar Nori : > On Tuesday 28 February 2017 04:22 AM, Rob Herring wrote: >> On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote: >>> Add an optional property - enable-gpios - which can be used to specify >>> the GPIOs that must be requested to select the vpif functionality. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> index df7182a..23c5405 100644 >>> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >>> @@ -13,6 +13,9 @@ Required properties: >>> - reg: physical base address and length of the registers set for the device; >>> - interrupts: should contain IRQ line for the VPIF >>> >>> +Optional properties: >>> +- enable-gpios: phandle of the GPIOs used to select the vpif functionality >> >> What does this control exactly? The GPIOs belong in the node they are >> connected to and having GPIOs routed to this block seems strange. > > The DA850 EVM board implements on-board muxing which lets the video > input (via VPIF) to be routed to a TVP5147 (video decoder) for composite > input or to a camera header. There are other mux options which use the > same VPIF SoC pins (RMII ethernet or character LCD). > > There is a three-to-eight demux on the board which drives enable signals > to buffers letting you choose from these options. > > From your response, it looks like you want the enable-gpios property to > be in the TVP5147 or camera node. That does make sense to me. > Wouldn't that cause races again? The TVP5147 ADC is probed from within the vpif driver as a media subdev (after initialize_vpif(), v4l2_device_register(), irq requests etc.). Thanks, Bartosz