From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADCFC433DF for ; Fri, 5 Jun 2020 10:13:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0A252053B for ; Fri, 5 Jun 2020 10:13:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="lh0QXYFb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbgFEKNg (ORCPT ); Fri, 5 Jun 2020 06:13:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgFEKNg (ORCPT ); Fri, 5 Jun 2020 06:13:36 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F45C08C5C3 for ; Fri, 5 Jun 2020 03:13:36 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id fc4so4420325qvb.1 for ; Fri, 05 Jun 2020 03:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Kr1JN+TH7Urs24hNJJNmKRJutOEkby8+/R/7dSIUOhw=; b=lh0QXYFb7xG25Uk7dHuFKvyGcg5gMlqONXEIaW2e0MxVOjg/8jMAUN+oSWodCl3VN7 pqV0fs0ur1TtYQARI7xzaQERgGbUP3obbscqqxqDjie2jgsxqoFCLc2MmrEFKI8C0ZLS g2Dv4om99HSPjZUZIoC1RDS7WZmIpWWfZfZI7pAB4zmmkdih866YGmuNvVCPVDtK6XmW zgIC7UQPpg86NkUu6ihS+tXO/Yjs3eIi6Dba92KM56D8PXNcLcOrs28FFERzMW4q3PRu JtnJe1CliTNnXElhLu/Mo8pyDQ0cwxpxbR3DsKQxXepdefyJ+ajccLtLaG4ZNqU+AW3k xQGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Kr1JN+TH7Urs24hNJJNmKRJutOEkby8+/R/7dSIUOhw=; b=Z0Yrqm/tb1agZkeROXQyYg5M5wt6ITzKqUtd6XzBEGNUOIrMM9qmyxPseW8MO8CXgQ 1WiiUqLmt2D96NI81j+amq+GnrfhIC9iJy60RfXbafwdpg4x8G/JMSBjwn+XS40eKFgV KsuAWwYV0UZXbGXdS38IaMG1nN7eE1lWKJuOJLT91wlloKT+PFIU47iDChuwoViJa6Ry kBO6N1/sytFh406aQSM7bljtz3waVwZjkKl83fiRaXz30ZmMeNyfDmnBiSdYMH8rzHRI g4Svh9GB7avtyzf1TJQgg+aQBRqhK0Ihh4LpAMq3R9+7+SO21wYgkGXE6NjgN5jr3Wi/ HMzA== X-Gm-Message-State: AOAM530WgvQ1OTs4Y6jthgoVtsVD63g2/aWdl/v2AWO2M/LscsfwkYhl LGXmof2eiSF1pYAqpJupv/WpNb+AJj8ANepS0MkVcg== X-Google-Smtp-Source: ABdhPJzm8HG3M6WTMQOrJHazy7H0iVOZBUpaPCcEyaWl+9AsyOE8s4RugnfVJeEtkN9BA4F1BaEeEyRXtGVkr9ePDk0= X-Received: by 2002:ad4:55b4:: with SMTP id f20mr8785464qvx.148.1591352015116; Fri, 05 Jun 2020 03:13:35 -0700 (PDT) MIME-Version: 1.0 References: <20200604175515.GA1076951@bjorn-Precision-5520> In-Reply-To: From: Bartosz Golaszewski Date: Fri, 5 Jun 2020 12:13:24 +0200 Message-ID: Subject: Re: [PATCH] gpio:asm28xx-18xx: new driver To: =?UTF-8?B?UmljaGFyZCBIc3Uo6Kix6IKy5b2wKQ==?= Cc: Bartosz Golaszewski , Bjorn Helgaas , Richard Hsu , =?UTF-8?B?WWQgVHNlbmco5pu+6KOV6YGUKQ==?= , =?UTF-8?B?SmVzc2UxIENoYW5nKOW8teWci+WZqCk=?= , Linus Walleij , Bjorn Helgaas , kbuild test robot , "kbuild-all@lists.01.org" , linux-gpio , "linux-pci@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org pt., 5 cze 2020 o 12:02 Richard Hsu(=E8=A8=B1=E8=82=B2=E5=BD=B0) napisa=C5=82(a): > > Hi Bjorn Helgass, > Thanks for your detailed explanation. Richard, please format your e-mails correctly for the mailing list. I already directed you to the documentation on patch submission in the linux kernel source. Also: don't top-post. > Hi Bartosz Golaszewski, > I am grateful for your suggestion. The driver of bridge is a pci bus = driver. It isn't written by us and is more complex. I have zero knowledge o= f > the PCI sub-system, and perhaps it(pci bus driver) don't use gpio subsys= tem with /sys/class/gpio/(sysfs interface) that I need. I just follow the o= ther driver(gpio-amd8111.c)'s > framework and maybe it can be used again. Thank you > The gpio-amd8111 driver does in fact do what you try to copy here but it doesn't mean it's correct. It's quite possible that 8 years ago we didn't know any better and merged it as it is. It doesn't justify doing the same now with a new driver, especially since Bjorn explained in detail why it's wrong. Rather, we should try to fix gpio-amd8111 instead. Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7210450549526564469==" MIME-Version: 1.0 From: Bartosz Golaszewski To: kbuild-all@lists.01.org Subject: Re: [PATCH] gpio:asm28xx-18xx: new driver Date: Fri, 05 Jun 2020 12:13:24 +0200 Message-ID: In-Reply-To: List-Id: --===============7210450549526564469== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable pt., 5 cze 2020 o 12:02 Richard Hsu(=E8=A8=B1=E8=82=B2=E5=BD=B0) napisa=C5=82(a): > > Hi Bjorn Helgass, > Thanks for your detailed explanation. Richard, please format your e-mails correctly for the mailing list. I already directed you to the documentation on patch submission in the linux kernel source. Also: don't top-post. > Hi Bartosz Golaszewski, > I am grateful for your suggestion. The driver of bridge is a pci bus = driver. It isn't written by us and is more complex. I have zero knowledge of > the PCI sub-system, and perhaps it(pci bus driver) don't use gpio subsys= tem with /sys/class/gpio/(sysfs interface) that I need. I just follow the o= ther driver(gpio-amd8111.c)'s > framework and maybe it can be used again. Thank you > The gpio-amd8111 driver does in fact do what you try to copy here but it doesn't mean it's correct. It's quite possible that 8 years ago we didn't know any better and merged it as it is. It doesn't justify doing the same now with a new driver, especially since Bjorn explained in detail why it's wrong. Rather, we should try to fix gpio-amd8111 instead. Bartosz --===============7210450549526564469==--