From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B98C433FE for ; Wed, 22 Sep 2021 09:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E1F561211 for ; Wed, 22 Sep 2021 09:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234414AbhIVJr3 (ORCPT ); Wed, 22 Sep 2021 05:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234381AbhIVJr2 (ORCPT ); Wed, 22 Sep 2021 05:47:28 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F05EDC061756 for ; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id i132so7820211qke.1 for ; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bTthP8lbagoNgD4znkkkPcaT2q+h8fGmYWbFuWXoDrQ=; b=IWHUjcdXwzYzIZEw0LJMOVNcxFzxts7J5SwUd4EoNozkeV9qZ4BmaoI2p4SW6AVAIv pLx/v01w2QMqzU9DQegqZZ7VaYeBr8oN5Yj90pYLRrlIUouBY6EDACJVwIoTv/04mH6C dduy5DsXXdVgwah75k/WJzgJLoCbrGdPowzKhaLgT0eJtIMmAgEVoElmpvJqTB1GNrmh gMxbm6gGc1R2hNP/fQXCDqVBGrq3GM6kT+ccApCizLZL5rDuAAUaDmtmoY6mX0DWeIMX 5z9Mps2n/SaMjCT/qYLVY0DFTLYpMBxO1yb76Z0FnotqC9ITeXUxvtjatVbqRKLZp2Bt QxdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bTthP8lbagoNgD4znkkkPcaT2q+h8fGmYWbFuWXoDrQ=; b=wkUsvEzacLSqoST4KyaJeKdh5WRR7+j0QoopEeQ3bzfXzf8ohvdgD+kOoK8+00Qua0 BjWy/Uj5zPUl/Dp/EAxU+l29U40ZflZQCrCcAIJMQXaCddAfX6+UN1ENwCpGWvnk8PRd w52KQvUWDnP+qalxkz5Rcj4v1qRE7dsTRwM2sW6JhKB1gtXedP9IUNmw3YWsmJHbBLGR wzimCtgiN2xmtpnUpClB83BGVY1B/J5BEAN4Fv3sFNgBxLqXnXwVcyZuFC7tzXcxHgJj dLcTSOHa2r0B2+yQJd9AuWY247WqCEiqQAcC1Kc7Di4UDUUm28AuHLQyiDROqv1SFN+p kkHQ== X-Gm-Message-State: AOAM533hu12kzjWD1gyF59cyIPqYMyqBu4zFG6qJxBJBopb85nZIe/w9 tcS+em4ZY2QeCyEVoQuUXmkLvro7RkVhS3Q9TLdorw== X-Google-Smtp-Source: ABdhPJz1dWLmkTK19qnONV6Gew86lZTBWocxC61DECZPcAD2oPCv39vXAZxXVu5i/CJbZwh1QCWRFftDyNRigk96mqo= X-Received: by 2002:a25:7146:: with SMTP id m67mr43663441ybc.353.1632303958187; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) MIME-Version: 1.0 References: <20210913224926.1260726-1-heiko@sntech.de> <20210913224926.1260726-2-heiko@sntech.de> In-Reply-To: <20210913224926.1260726-2-heiko@sntech.de> From: Bartosz Golaszewski Date: Wed, 22 Sep 2021 11:45:47 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/rockchip: extended debounce support is only available on v2 To: Heiko Stuebner Cc: Linus Walleij , Jianqun Xu , linux-gpio , arm-soc , "open list:ARM/Rockchip SoC..." , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner wrote: > > The gpio driver runs into issues on v1 gpio blocks, as the db_clk > and the whole extended debounce support is only ever defined on v2. > So checking for the IS_ERR on the db_clk is not enough, as it will > be NULL on v1. > > Fix this by adding the needed condition for v2 first before checking > the existence of the db_clk. > > This caused my rk3288-veyron-pinky to enter a reboot loop when it > tried to enable the power-key as adc-key device. > > Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller") > Signed-off-by: Heiko Stuebner > --- Queued for fixes. Thanks! Bart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A4AC433FE for ; Wed, 22 Sep 2021 09:46:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 668E1610D1 for ; Wed, 22 Sep 2021 09:46:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 668E1610D1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FdwmpGpyXFXx+CHm1ZQznIMMiqu3IgiVZaAY+iYWnyo=; b=LbXYehkqsDvW/W hPUwz/SyWsLRtahzGHl+I0BKwmLpL0ObXkmLsllbjOFzdk446D+1LqwO0kKf9mKk+MICbLueRAHoG 6rCXzU/WSUm3arZR38VHc894cMQrF99kynZeM2k/5w2Amsi/qrGS9ZWd+mztZjUdFA5o1WgLYvrWB pciiLRrrrBkgyZhWIgCZEW5Y92MN6pdPO3ySYAfYoZCWMB3btZ2DOCEH76vsMTteXyWqM7KS2X95L aLQKUdFGDy/F1ioN7sL9HyxU1Vmb5pjYHVtrK8fHhrVScal7jiMJiMgMjPO1r4Ji0gbhSlCmUsQ0s ZrsDB7ZoLhAamfyKZrXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSypR-007clw-9K; Wed, 22 Sep 2021 09:46:13 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSypD-007cht-J6 for linux-rockchip@lists.infradead.org; Wed, 22 Sep 2021 09:46:01 +0000 Received: by mail-qk1-x735.google.com with SMTP id 194so7296614qkj.11 for ; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bTthP8lbagoNgD4znkkkPcaT2q+h8fGmYWbFuWXoDrQ=; b=IWHUjcdXwzYzIZEw0LJMOVNcxFzxts7J5SwUd4EoNozkeV9qZ4BmaoI2p4SW6AVAIv pLx/v01w2QMqzU9DQegqZZ7VaYeBr8oN5Yj90pYLRrlIUouBY6EDACJVwIoTv/04mH6C dduy5DsXXdVgwah75k/WJzgJLoCbrGdPowzKhaLgT0eJtIMmAgEVoElmpvJqTB1GNrmh gMxbm6gGc1R2hNP/fQXCDqVBGrq3GM6kT+ccApCizLZL5rDuAAUaDmtmoY6mX0DWeIMX 5z9Mps2n/SaMjCT/qYLVY0DFTLYpMBxO1yb76Z0FnotqC9ITeXUxvtjatVbqRKLZp2Bt QxdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bTthP8lbagoNgD4znkkkPcaT2q+h8fGmYWbFuWXoDrQ=; b=xwFWURvu4o2IhRiIM3YI4fBSf/+kt1cs7Cl91OLrfYZULiiDpJehQOD7qQhGX4NgoE UqhlwIH7n2ewF9lYvDBhihb9WWJVBwU2Rp5WTUU6ICllMWxU1CKuntu3Q/vNx/95ZPGB 8TlTlx33/67tkdzjrU9tU+RDk1E3dNyR11sCGkMCCrUboKz5EPTBwcw+B0efvrdvtWaZ v33bzyZdoMd08UcZljGL6VrfOHHw/ipO1IxBUwAk0EoaU/mFQlqqjgpNNi5pPD9mTj2j AvqjGqAnN68QRNAIuxzKFQFCbDl7p5s6EwiTFqakeznELKJKloUSqbNjBxkfB3UKRvtp u+pA== X-Gm-Message-State: AOAM530gt3ARbRM6X64dgmviTBcGYWX9jOauqe6Zymow9jrVYD53yLHt OFCQUjFpC0tIlwU6jtKJBzD8UqEzwzbYJ1SMBKlu0w== X-Google-Smtp-Source: ABdhPJz1dWLmkTK19qnONV6Gew86lZTBWocxC61DECZPcAD2oPCv39vXAZxXVu5i/CJbZwh1QCWRFftDyNRigk96mqo= X-Received: by 2002:a25:7146:: with SMTP id m67mr43663441ybc.353.1632303958187; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) MIME-Version: 1.0 References: <20210913224926.1260726-1-heiko@sntech.de> <20210913224926.1260726-2-heiko@sntech.de> In-Reply-To: <20210913224926.1260726-2-heiko@sntech.de> From: Bartosz Golaszewski Date: Wed, 22 Sep 2021 11:45:47 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/rockchip: extended debounce support is only available on v2 To: Heiko Stuebner Cc: Linus Walleij , Jianqun Xu , linux-gpio , arm-soc , "open list:ARM/Rockchip SoC..." , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_024559_720147_FD00DEE2 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner wrote: > > The gpio driver runs into issues on v1 gpio blocks, as the db_clk > and the whole extended debounce support is only ever defined on v2. > So checking for the IS_ERR on the db_clk is not enough, as it will > be NULL on v1. > > Fix this by adding the needed condition for v2 first before checking > the existence of the db_clk. > > This caused my rk3288-veyron-pinky to enter a reboot loop when it > tried to enable the power-key as adc-key device. > > Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller") > Signed-off-by: Heiko Stuebner > --- Queued for fixes. Thanks! Bart _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 466EAC433EF for ; Wed, 22 Sep 2021 09:48:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B1961100 for ; Wed, 22 Sep 2021 09:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08B1961100 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BKtFw6zpGGJRUkV4MJhutx1prOuthD2EBjdCmzhyibU=; b=eVDtevLP7e7a9M aGIfupBuSBAS4j8Gqxe4xCz6kKdtbxTII3/RrG7wIrW0matieP1azJr7kgVQcQe2cPNq/sgRMoteG YY9kDQhkHLX4o00aNWUj7xyy2O9J7V1IIOXnjFUNbw8oJFBzgmOIKbHSGwW7PEDCYiqZQQJiU+kPn 7hHsmHDgnQ97aapp6pwMKhjQmvPImIYh42jeCemz7ahMsUeXQlXxG4tx1VwamXKcDEJ/GcjvYQkwg 34EZGrT01sCqwbgfcUHQOlgcZhDVGk21KnxbvHi0lNjFgB2Sst3eIJNXe/RjByg+cdzhXVseONgFO pr941hll1g/mFANwC+Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSypI-007cjs-6N; Wed, 22 Sep 2021 09:46:04 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSypD-007chu-J5 for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 09:46:01 +0000 Received: by mail-qk1-x735.google.com with SMTP id b65so7210537qkc.13 for ; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bTthP8lbagoNgD4znkkkPcaT2q+h8fGmYWbFuWXoDrQ=; b=IWHUjcdXwzYzIZEw0LJMOVNcxFzxts7J5SwUd4EoNozkeV9qZ4BmaoI2p4SW6AVAIv pLx/v01w2QMqzU9DQegqZZ7VaYeBr8oN5Yj90pYLRrlIUouBY6EDACJVwIoTv/04mH6C dduy5DsXXdVgwah75k/WJzgJLoCbrGdPowzKhaLgT0eJtIMmAgEVoElmpvJqTB1GNrmh gMxbm6gGc1R2hNP/fQXCDqVBGrq3GM6kT+ccApCizLZL5rDuAAUaDmtmoY6mX0DWeIMX 5z9Mps2n/SaMjCT/qYLVY0DFTLYpMBxO1yb76Z0FnotqC9ITeXUxvtjatVbqRKLZp2Bt QxdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bTthP8lbagoNgD4znkkkPcaT2q+h8fGmYWbFuWXoDrQ=; b=11jAy+3j+duUVVdbTe+vWkED+4yBQ3kF/KbA/AdlgNRCobKf/Qj6GRMcsC3PRQqyOj +6BcFUSOQVoWSVTboQctxiSFFvT2K1Po+hTwbtplBLGrvSIv2QSwMnwR418rqOplvQ5v CKqcu92nZm4vUFKQW1BWBfU0hqxINtlONjLVcnmg9wllov0AsB0KwwJUxjZHRZjKx+ns eqIXVvVfYWG0fMX/ZsZF2airtnMe6sUfIc3e6Ke32xQf4+EGH0zkdIu2sXRiEiHv5vyD bcLw0lqc3/pNEaAFrzptetpeTYmdasp8ojmUzv8Nj/ZQGHYroEPLKA66pWTigN5JCJMk Juew== X-Gm-Message-State: AOAM533Zoc9gDXQDzlVprWCTH2T/kgkIBPEIZzUtcZ3l/TsyZQVQRDs3 wFlb+UPzmBBeCZLu+vP73pUH27iMhAttNmLwy4tTGFAkXuA= X-Google-Smtp-Source: ABdhPJz1dWLmkTK19qnONV6Gew86lZTBWocxC61DECZPcAD2oPCv39vXAZxXVu5i/CJbZwh1QCWRFftDyNRigk96mqo= X-Received: by 2002:a25:7146:: with SMTP id m67mr43663441ybc.353.1632303958187; Wed, 22 Sep 2021 02:45:58 -0700 (PDT) MIME-Version: 1.0 References: <20210913224926.1260726-1-heiko@sntech.de> <20210913224926.1260726-2-heiko@sntech.de> In-Reply-To: <20210913224926.1260726-2-heiko@sntech.de> From: Bartosz Golaszewski Date: Wed, 22 Sep 2021 11:45:47 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/rockchip: extended debounce support is only available on v2 To: Heiko Stuebner Cc: Linus Walleij , Jianqun Xu , linux-gpio , arm-soc , "open list:ARM/Rockchip SoC..." , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_024559_717308_507E721F X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner wrote: > > The gpio driver runs into issues on v1 gpio blocks, as the db_clk > and the whole extended debounce support is only ever defined on v2. > So checking for the IS_ERR on the db_clk is not enough, as it will > be NULL on v1. > > Fix this by adding the needed condition for v2 first before checking > the existence of the db_clk. > > This caused my rk3288-veyron-pinky to enter a reboot loop when it > tried to enable the power-key as adc-key device. > > Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller") > Signed-off-by: Heiko Stuebner > --- Queued for fixes. Thanks! Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel