From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A47FC433E0 for ; Tue, 26 Jan 2021 05:25:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24EAA22795 for ; Tue, 26 Jan 2021 05:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbhAZFZt (ORCPT ); Tue, 26 Jan 2021 00:25:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727277AbhAYJzk (ORCPT ); Mon, 25 Jan 2021 04:55:40 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3831EC061352 for ; Mon, 25 Jan 2021 01:44:03 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id bx12so14390645edb.8 for ; Mon, 25 Jan 2021 01:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EKLMKnkstet3NWkC7zAKLu7Avtb2ZmMVXQ+VJfE7jwI=; b=qXRyadwd8FejHhWhL/mHFh0bUcyEUBMMnHkyF3Ab4dETWY3Nw0ywxFJ3WzClhzsaZW 9Y9mgew1tQ0Ay6EozD+OQlJXtk6VWQzPwluLRBkNaUnpCzKfTdBSMcpzK8Z5O2Ve+FTz SHHI3qrFhOvVTeJaXTSA6r5cxXW+C4vKQL8CUvJtupZQbSAxSqaR2Na6IlZuoVcTlffc L5WXcVwtE7arYZRLCLcVAACM+FwJQtrFooN/L01UG7nr8OtmwW/A64Yew3Rs65lJMN7J hSytpKBIZpapf83jksv5Nk79pDobvGyjq35yuOoNbF742HSbm0GC42wsKSPnqhQJFomb DVkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EKLMKnkstet3NWkC7zAKLu7Avtb2ZmMVXQ+VJfE7jwI=; b=sdsgFBOiIjPE6Ck8uKdhq9/H7Vw0LJwZrCNUxZFAT8X10Csy+EKAOxwGxWpmv6qZF3 w0+QEIo5u0Dr/RaYU1M9yWj+jx24pwdUOSKv//aj23JW5jlnySHtzrcgEcThGU9k3YIF G38VLo6ejDhl0qDfISmD5Lo0fqm3aTrm6z1vIP+Ss07vUYUG1hfBA44f3Ni//WuwndPj I6+Crm8Rnz0gfFArcon+RbIYAAbEKd1OWvN+vio+HykVuJ5tB23lwPZ5kN9oSh3dIU8x in2V5kbpto2JTA5cBN5U8uLYcxYpjHN1OjOjc3UBmbF9R2YfSwrKLotattOrpTtuGzwD u1og== X-Gm-Message-State: AOAM531K7vAfjHXuSPKtSEYmUGlUxN0Y/2Tk78Gi86C22A8+qzUPwOnA ZvaHR4N5tCTkLEW/3Ix6cJOCvMgGZR45Jd2nLCwzSg== X-Google-Smtp-Source: ABdhPJwaJgoAymqk6k9f9KmhdwfEU8ljgtUOr3PqrtmdVbzbw0NT6bHHmw5XnnMxAXCQ8FJybKBSYCp6RcAFKPCwfOc= X-Received: by 2002:a50:b742:: with SMTP id g60mr806323ede.113.1611567842009; Mon, 25 Jan 2021 01:44:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bartosz Golaszewski Date: Mon, 25 Jan 2021 10:43:50 +0100 Message-ID: Subject: Re: [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements To: Baruch Siach Cc: Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lee Jones , Linus Walleij , Andrew Lunn , Gregory Clement , Russell King , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio , arm-soc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Jan 20, 2021 at 5:16 PM Baruch Siach wrote: > > This series adds a few related fixes to the pwm .apply and .get_state > callbacks. > > The first patch was originally part of the series adding Armada 8K/7K pwm > support. I split it out to a separate series following review comments fr= om > Uwe Kleine-K=C3=B6nig who spotted a few more issues. There is no dependen= cy between > this and the Armada 8K/7K series. > > v5: > > * Drop a patch applied to the gpio tree > > * Fix patch 4/4 description typo (Uwe) > > * Reduce the number of multiplications (Uwe) > > * Add spaces around '+' (Uwe) > > * Use '1ULL' instead of explicit cast to reduce verbosity > > * Add Linus' Reviewed-by tags to patches that are unchanged since v2 > > v4: > > * Take advantage of zero value being treated as 2^32 by hardware. Rewri= te > patch 5/5 (Uwe). > > v3: > > * Improve patch 3/5 description (Uwe) > > * Add more Reviewed-by tags from Uwe > > v2: > > Address Uwe Kleine-K=C3=B6nig comments. > > * Improve patch 1/5 summary line > > * Add more information to patch 1/5 description > > * Add more information to patch 2/5 description > > * Don't round period/duty_cycle up in .apply (patch 3/5) > > * Expand the comment in path 5/5 based on RMK's analysis of hardware > behaviour > > * Add Uwe's Reviewed-by tags > > Baruch Siach (4): > gpio: mvebu: improve pwm period calculation accuracy > gpio: mvebu: make pwm .get_state closer to idempotent > gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX > gpio: mvebu: improve handling of pwm zero on/off values > > drivers/gpio/gpio-mvebu.c | 47 +++++++++++++++++++++------------------ > 1 file changed, 25 insertions(+), 22 deletions(-) > > -- > 2.29.2 > Series applied, thanks a lot for the improvements! And thanks to Uwe and Russel for the reviews. Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9858C433DB for ; Mon, 25 Jan 2021 09:46:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B1C7224DE for ; Mon, 25 Jan 2021 09:46:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B1C7224DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hQOKsyBJIOlDEBv+4eUfrU1O6aUp5hp1BXlHF9WywpE=; b=mnWAY9L9CbDdL9bRNg3MxPp5J FrWcdQLmEewXn/qyOWjxZfvh6UoaeigDOhaplcPh0G8OnSq18jVVBAn/FCrPOqzI+330LIAyHHOBX OAF3gbEF9mXwq5illDy53NSpWqYmf+mI805iIouNcDuE6NziZYyJmEHoLkcuWmp90CT9pjvG+7h3B S9oaSEu8E1nonAul9YhobNmFhYtHM7s1Ua9IkfjCcGvLgaVIk8HYDBFDDCabVHp5OeLLyl1rVKRmR TF1r9LyYOpKZYEV/P5oKopRFBJJKEek3e/Xfc6eNWAa6kVsiulc57vgOU4e8epMmTqENJoklTC3tr KkL8x5mEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yPo-0002is-Kn; Mon, 25 Jan 2021 09:44:08 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yPl-0002iU-B0 for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 09:44:07 +0000 Received: by mail-ed1-x535.google.com with SMTP id b21so14412630edy.6 for ; Mon, 25 Jan 2021 01:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EKLMKnkstet3NWkC7zAKLu7Avtb2ZmMVXQ+VJfE7jwI=; b=qXRyadwd8FejHhWhL/mHFh0bUcyEUBMMnHkyF3Ab4dETWY3Nw0ywxFJ3WzClhzsaZW 9Y9mgew1tQ0Ay6EozD+OQlJXtk6VWQzPwluLRBkNaUnpCzKfTdBSMcpzK8Z5O2Ve+FTz SHHI3qrFhOvVTeJaXTSA6r5cxXW+C4vKQL8CUvJtupZQbSAxSqaR2Na6IlZuoVcTlffc L5WXcVwtE7arYZRLCLcVAACM+FwJQtrFooN/L01UG7nr8OtmwW/A64Yew3Rs65lJMN7J hSytpKBIZpapf83jksv5Nk79pDobvGyjq35yuOoNbF742HSbm0GC42wsKSPnqhQJFomb DVkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EKLMKnkstet3NWkC7zAKLu7Avtb2ZmMVXQ+VJfE7jwI=; b=MVtcfq5IimOja5rigSrfsXPdcXpy3Tijq2EGt4URvNmZmKp6WdB2Sd0CtLMdXyEPqb BzO5HfehhIifjmy4eQZn4jdlVOBqqtPN9SuzD3J3i+Gcr3+cmVmSPEFXsWFs3d9nCbkM UYIQyusHiRo4FBMNp5RTsD/GPLvmk0qUIohLzMHVI16/NRZTOKFdycj+1vc9WDdFVdjG d65dDOdcUD67lxxRSVHUCiwoQ4csSdTkjTy0pBb44WwYEgG0+fJNDXKJGZsm8tJ9sfBi 180UGjvjrDwQNdvW9XJ/tWB0U35FvG8C3LoTt/9Be2Bb0J+mmurmlcCIgCICcbNdfpoZ U9aQ== X-Gm-Message-State: AOAM531BDjkJHlyjPc9rkggB8ZEQHSbDZW9ee9M8FPbStuo3hqXhuvgW 1/71w2gsPvluLCbn6VXwNm0etlMlDeSdpLV2sojX7Q== X-Google-Smtp-Source: ABdhPJwaJgoAymqk6k9f9KmhdwfEU8ljgtUOr3PqrtmdVbzbw0NT6bHHmw5XnnMxAXCQ8FJybKBSYCp6RcAFKPCwfOc= X-Received: by 2002:a50:b742:: with SMTP id g60mr806323ede.113.1611567842009; Mon, 25 Jan 2021 01:44:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bartosz Golaszewski Date: Mon, 25 Jan 2021 10:43:50 +0100 Message-ID: Subject: Re: [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements To: Baruch Siach X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_044405_513960_401418F3 X-CRM114-Status: GOOD ( 19.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sascha Hauer , linux-pwm@vger.kernel.org, Linus Walleij , Chris Packham , Russell King , linux-gpio , Thierry Reding , Thomas Petazzoni , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Ralph Sennhauser , Lee Jones , Gregory Clement , arm-soc , Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKYW4gMjAsIDIwMjEgYXQgNToxNiBQTSBCYXJ1Y2ggU2lhY2ggPGJhcnVjaEB0a29z LmNvLmlsPiB3cm90ZToKPgo+IFRoaXMgc2VyaWVzIGFkZHMgYSBmZXcgcmVsYXRlZCBmaXhlcyB0 byB0aGUgcHdtIC5hcHBseSBhbmQgLmdldF9zdGF0ZQo+IGNhbGxiYWNrcy4KPgo+IFRoZSBmaXJz dCBwYXRjaCB3YXMgb3JpZ2luYWxseSBwYXJ0IG9mIHRoZSBzZXJpZXMgYWRkaW5nIEFybWFkYSA4 Sy83SyBwd20KPiBzdXBwb3J0LiBJIHNwbGl0IGl0IG91dCB0byBhIHNlcGFyYXRlIHNlcmllcyBm b2xsb3dpbmcgcmV2aWV3IGNvbW1lbnRzIGZyb20KPiBVd2UgS2xlaW5lLUvDtm5pZyB3aG8gc3Bv dHRlZCBhIGZldyBtb3JlIGlzc3Vlcy4gVGhlcmUgaXMgbm8gZGVwZW5kZW5jeSBiZXR3ZWVuCj4g dGhpcyBhbmQgdGhlIEFybWFkYSA4Sy83SyBzZXJpZXMuCj4KPiB2NToKPgo+ICAgKiBEcm9wIGEg cGF0Y2ggYXBwbGllZCB0byB0aGUgZ3BpbyB0cmVlCj4KPiAgICogRml4IHBhdGNoIDQvNCBkZXNj cmlwdGlvbiB0eXBvIChVd2UpCj4KPiAgICogUmVkdWNlIHRoZSBudW1iZXIgb2YgbXVsdGlwbGlj YXRpb25zIChVd2UpCj4KPiAgICogQWRkIHNwYWNlcyBhcm91bmQgJysnIChVd2UpCj4KPiAgICog VXNlICcxVUxMJyBpbnN0ZWFkIG9mIGV4cGxpY2l0IGNhc3QgdG8gcmVkdWNlIHZlcmJvc2l0eQo+ Cj4gICAqIEFkZCBMaW51cycgUmV2aWV3ZWQtYnkgdGFncyB0byBwYXRjaGVzIHRoYXQgYXJlIHVu Y2hhbmdlZCBzaW5jZSB2Mgo+Cj4gdjQ6Cj4KPiAgICogVGFrZSBhZHZhbnRhZ2Ugb2YgemVybyB2 YWx1ZSBiZWluZyB0cmVhdGVkIGFzIDJeMzIgYnkgaGFyZHdhcmUuIFJld3JpdGUKPiAgICAgcGF0 Y2ggNS81IChVd2UpLgo+Cj4gdjM6Cj4KPiAgICogSW1wcm92ZSBwYXRjaCAzLzUgZGVzY3JpcHRp b24gKFV3ZSkKPgo+ICAgKiBBZGQgbW9yZSBSZXZpZXdlZC1ieSB0YWdzIGZyb20gVXdlCj4KPiB2 MjoKPgo+IEFkZHJlc3MgVXdlIEtsZWluZS1Lw7ZuaWcgY29tbWVudHMuCj4KPiAgICogSW1wcm92 ZSBwYXRjaCAxLzUgc3VtbWFyeSBsaW5lCj4KPiAgICogQWRkIG1vcmUgaW5mb3JtYXRpb24gdG8g cGF0Y2ggMS81IGRlc2NyaXB0aW9uCj4KPiAgICogQWRkIG1vcmUgaW5mb3JtYXRpb24gdG8gcGF0 Y2ggMi81IGRlc2NyaXB0aW9uCj4KPiAgICogRG9uJ3Qgcm91bmQgcGVyaW9kL2R1dHlfY3ljbGUg dXAgaW4gLmFwcGx5IChwYXRjaCAzLzUpCj4KPiAgICogRXhwYW5kIHRoZSBjb21tZW50IGluIHBh dGggNS81IGJhc2VkIG9uIFJNSydzIGFuYWx5c2lzIG9mIGhhcmR3YXJlCj4gICAgIGJlaGF2aW91 cgo+Cj4gICAqIEFkZCBVd2UncyBSZXZpZXdlZC1ieSB0YWdzCj4KPiBCYXJ1Y2ggU2lhY2ggKDQp Ogo+ICAgZ3BpbzogbXZlYnU6IGltcHJvdmUgcHdtIHBlcmlvZCBjYWxjdWxhdGlvbiBhY2N1cmFj eQo+ICAgZ3BpbzogbXZlYnU6IG1ha2UgcHdtIC5nZXRfc3RhdGUgY2xvc2VyIHRvIGlkZW1wb3Rl bnQKPiAgIGdwaW86IG12ZWJ1OiBkb24ndCBsaW1pdCBwd20gcGVyaW9kL2R1dHlfY3ljbGUgdG8g VUlOVF9NQVgKPiAgIGdwaW86IG12ZWJ1OiBpbXByb3ZlIGhhbmRsaW5nIG9mIHB3bSB6ZXJvIG9u L29mZiB2YWx1ZXMKPgo+ICBkcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jIHwgNDcgKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl cnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPgo+IC0tCj4gMi4yOS4yCj4KClNlcmllcyBhcHBs aWVkLCB0aGFua3MgYSBsb3QgZm9yIHRoZSBpbXByb3ZlbWVudHMhIEFuZCB0aGFua3MgdG8gVXdl CmFuZCBSdXNzZWwgZm9yIHRoZSByZXZpZXdzLgoKQmFydG9zegoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=