All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
	Tomasz Figa <tfiga@chromium.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] dt-binding: eeprom: at24: add supply properties
Date: Thu, 24 Oct 2019 08:22:29 +0200	[thread overview]
Message-ID: <CAMpxmJW_HQnL8i5FnKcVUs=ZyrnaFe6X+oqG38-v=O05d5vNxw@mail.gmail.com> (raw)
In-Reply-To: <20191018082557.3696-2-bibby.hsieh@mediatek.com>

pt., 18 paź 2019 o 10:26 Bibby Hsieh <bibby.hsieh@mediatek.com> napisał(a):
>
> In some platforms, they disable the power-supply of eeprom and i2c due
> to power consumption reduction.
>
> This patch add two supply properties: vcc-supply, i2c-supply.
>
> Changes since v1:
>  - change supply name
>  - rebase to next
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index e8778560d966..578487a5d9b7 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -167,6 +167,14 @@ properties:
>      minimum: 1
>      maximum: 8
>
> +  vcc-supply:
> +    description:
> +      phandle of the regulator that provides the supply voltage.
> +
> +  i2c-sypply:
> +    description:
> +      phandle to the regulator that provides power to i2c.
> +

Something was bothering me about this patch so I came back to take a
look. Can you explain what i2c actually stands for in this doc? I hope
I'm misinterpreting something and it isn't that the driver disables
the regulator powering the i2c bus controller?

Bart

>  required:
>    - compatible
>    - reg
> --
> 2.18.0
>

  parent reply	other threads:[~2019-10-24  6:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  8:25 [PATCH v4] misc: eeprom: at24: support pm_runtime control Bibby Hsieh
2019-10-18  8:25 ` [PATCH v2] dt-binding: eeprom: at24: add supply properties Bibby Hsieh
2019-10-18 10:07   ` Bartosz Golaszewski
2019-10-24  6:22   ` Bartosz Golaszewski [this message]
2019-10-24  7:01     ` Tomasz Figa
2019-10-24  8:40       ` Bartosz Golaszewski
2019-10-24  9:32         ` Tomasz Figa
2019-10-25 21:10           ` Rob Herring
2019-10-26 12:05             ` Bartosz Golaszewski
2019-10-28  2:36               ` Bibby Hsieh
2019-11-07 14:32                 ` Tomasz Figa
2019-10-24  6:48   ` Peter Rosin
2019-10-18  9:24 ` [PATCH v4] misc: eeprom: at24: support pm_runtime control Tomasz Figa
2019-10-18 10:11   ` Bartosz Golaszewski
2019-10-22  2:25   ` Bibby Hsieh
2019-10-21 16:53 ` Bartosz Golaszewski
2019-10-22  2:23   ` Bibby Hsieh
2019-10-22  7:26   ` Tomasz Figa
2019-10-22  9:00     ` Bartosz Golaszewski
2019-10-22 10:33       ` Tomasz Figa
2019-10-22 11:19         ` Mark Brown
2019-10-22 12:13           ` Bartosz Golaszewski
2019-10-22 15:03             ` Mark Brown
2019-10-22 15:42               ` Bartosz Golaszewski
2019-10-22 16:33                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMpxmJW_HQnL8i5FnKcVUs=ZyrnaFe6X+oqG38-v=O05d5vNxw@mail.gmail.com' \
    --to=bgolaszewski@baylibre.com \
    --cc=bibby.hsieh@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.