All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>, Vignesh R <vigneshr@ti.com>,
	Yong Li <yong.b.li@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent
Date: Thu, 8 Sep 2016 16:16:19 +0200	[thread overview]
Message-ID: <CAMpxmJWdMx2mHN4bWueRAcNMCLGVZr_MkQ2uvpkoBG6MnntgfQ@mail.gmail.com> (raw)
In-Reply-To: <1473337770.11323.95.camel@linux.intel.com>

2016-09-08 14:29 GMT+02:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Thu, 2016-09-08 at 15:27 +0300, Andy Shevchenko wrote:
>> On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote:
>> >
>> > The register offset defines for the pca953x and pca957x expander
>> > families should have the same names to better reflect their similar
>> > purposes.
>>
>
> And one more question. If it is done in datasheet as is used currently
> in the driver I would leave it to be aligned with official
> documentation.
>

Right, the current names seem to come from the datasheet register
table. I'll drop this patch in v6.

Thanks,
Bartosz

      reply	other threads:[~2016-09-08 14:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 10:48 [PATCH v5 0/6] gpio: pca953x: code refactoring Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 1/6] gpio: pca953x: code shrink Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 2/6] gpio: pca953x: refactor pca953x_write_regs() Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 3/6] gpio: pca953x: refactor pca953x_read_regs() Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 4/6] gpio: pca953x: remove an unused variable Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 5/6] gpio: pca953x: coding style fixes Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 6/6] gpio: pca953x: make the define names consistent Bartosz Golaszewski
2016-09-08 12:27   ` Andy Shevchenko
2016-09-08 12:29     ` Bartosz Golaszewski
2016-09-08 12:29     ` Andy Shevchenko
2016-09-08 14:16       ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMpxmJWdMx2mHN4bWueRAcNMCLGVZr_MkQ2uvpkoBG6MnntgfQ@mail.gmail.com \
    --to=bgolaszewski@baylibre.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --cc=yong.b.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.