All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP
@ 2021-06-25  8:37 Johannes Berg
  2021-06-25 10:16 ` Bartosz Golaszewski
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2021-06-25  8:37 UTC (permalink / raw)
  To: linux-gpio
  Cc: Linus Walleij, Bartosz Golaszewski, Dmitry Baryshkov,
	Andrew Lunn, linux-um, Johannes Berg, kernel test robot

From: Johannes Berg <johannes.berg@intel.com>

Both of these drivers use ioport_map(), so they need to
depend on HAS_IOPORT_MAP. Otherwise, they cannot be built
even with COMPILE_TEST on architectures without an ioport
implementation, such as ARCH=um.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 drivers/gpio/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 1dd0ec6727fd..3c69b785cb79 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1383,6 +1383,7 @@ config GPIO_TPS68470
 config GPIO_TQMX86
 	tristate "TQ-Systems QTMX86 GPIO"
 	depends on MFD_TQMX86 || COMPILE_TEST
+	depends on HAS_IOPORT_MAP
 	select GPIOLIB_IRQCHIP
 	help
 	  This driver supports GPIO on the TQMX86 IO controller.
@@ -1450,6 +1451,7 @@ menu "PCI GPIO expanders"
 config GPIO_AMD8111
 	tristate "AMD 8111 GPIO driver"
 	depends on X86 || COMPILE_TEST
+	depends on HAS_IOPORT_MAP
 	help
 	  The AMD 8111 south bridge contains 32 GPIO pins which can be used.
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP
  2021-06-25  8:37 [PATCH] drivers: gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP Johannes Berg
@ 2021-06-25 10:16 ` Bartosz Golaszewski
  0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-06-25 10:16 UTC (permalink / raw)
  To: Johannes Berg
  Cc: linux-gpio, Linus Walleij, Dmitry Baryshkov, Andrew Lunn,
	linux-um, Johannes Berg, kernel test robot

On Fri, Jun 25, 2021 at 10:37 AM Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> From: Johannes Berg <johannes.berg@intel.com>
>
> Both of these drivers use ioport_map(), so they need to
> depend on HAS_IOPORT_MAP. Otherwise, they cannot be built
> even with COMPILE_TEST on architectures without an ioport
> implementation, such as ARCH=um.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  drivers/gpio/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 1dd0ec6727fd..3c69b785cb79 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1383,6 +1383,7 @@ config GPIO_TPS68470
>  config GPIO_TQMX86
>         tristate "TQ-Systems QTMX86 GPIO"
>         depends on MFD_TQMX86 || COMPILE_TEST
> +       depends on HAS_IOPORT_MAP
>         select GPIOLIB_IRQCHIP
>         help
>           This driver supports GPIO on the TQMX86 IO controller.
> @@ -1450,6 +1451,7 @@ menu "PCI GPIO expanders"
>  config GPIO_AMD8111
>         tristate "AMD 8111 GPIO driver"
>         depends on X86 || COMPILE_TEST
> +       depends on HAS_IOPORT_MAP
>         help
>           The AMD 8111 south bridge contains 32 GPIO pins which can be used.
>
> --
> 2.31.1
>

Applied, thanks!

Bart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-25 10:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25  8:37 [PATCH] drivers: gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP Johannes Berg
2021-06-25 10:16 ` Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.