From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011F6C433B4 for ; Fri, 21 May 2021 12:46:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4834613C8 for ; Fri, 21 May 2021 12:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233900AbhEUMsA (ORCPT ); Fri, 21 May 2021 08:48:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232170AbhEUMr7 (ORCPT ); Fri, 21 May 2021 08:47:59 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A32F4C061574 for ; Fri, 21 May 2021 05:46:32 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id y2so27267246ybq.13 for ; Fri, 21 May 2021 05:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uJtv8tO+srMCLhjCuMBBHQBC6gQTo/DB8dTOrmtQwz0=; b=u3Q+sm3on6BmPGIfpRvuXdbC9eMKxaBuvgYy1JWnnzsycj2cZfrZU371lePTA11gtu +SE8wjEYS/h6moT8fj80cqELiBU9lIcOjUu7wN1poP1BOvEYLD52cImhNzreVJApnRJZ vXk7Vg5oXpnj/qUiaAThRHYJKPqPnKCtpTsVzsVPSdISWQaTzxIupYxa5U2p9c+9+6QA c9MU/drup9paSSjoteh8IbFJHeOpLLKGCboKFwNUAObbMrxoJiBTL5xWl9eioou7ZmbE XEJuZZsBZzzA/SY7dj8PcotdPEIfLOSA4uxuLMReaUCNlChAvXgK3qEry3bnmfIW4CyC DsGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uJtv8tO+srMCLhjCuMBBHQBC6gQTo/DB8dTOrmtQwz0=; b=Mo8L+DFi39BKeEjo6fGHnDsDI2+bYN3XIvVeYwBtEZsRKq9gYxBJ68ygPXIUWoS8/g hIo6CklNXTLGyUgTXGxOqSx2ipXIl6QKzEedOksPspOoglv20dxMSXJiAjK/XYxGQh1f MbkyO1JeQ/PO+9LgF1GD8uTEDMpjx1Jw+h3SHpLp0tjOcHYVxJUr7P+0WdMh+oNY4Pe7 G9vKO1Eg0AftK4zVlKatq7e1KFlXg+1Bs+PulqdTrrHVjU5VSFT3dQBgbN1tXIpTrDui c4nYdDrG6Llu/gyLIwpVTWWiPo0xrcL+63KDs60dKimvCBjOvBvkstzcNLTkp+iPSv7V r0ZQ== X-Gm-Message-State: AOAM530aQK/tDrNSV92BowrM3xuZoZVs527C31QxyAyjAg4HoDB2kGvS irgdc87Ql46y2pqCXfHgrbw3tDCAAOLingkv4/S9pQ== X-Google-Smtp-Source: ABdhPJwo1Fd1OhhBBCEBsJ5ei5vOtm0WPuwFHnpGY6cC1UHbm4x8mSHDgVoSMHyd+1f34eFkkO5eRsYDpPANBBfQc/o= X-Received: by 2002:a05:6902:1026:: with SMTP id x6mr13499261ybt.23.1621601191892; Fri, 21 May 2021 05:46:31 -0700 (PDT) MIME-Version: 1.0 References: <20210514092332.19966-1-aardelean@deviqon.com> In-Reply-To: <20210514092332.19966-1-aardelean@deviqon.com> From: Bartosz Golaszewski Date: Fri, 21 May 2021 14:46:21 +0200 Message-ID: Subject: Re: [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe To: Alexandru Ardelean Cc: linux-gpio , LKML , Linus Walleij , Support Opensource Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, May 14, 2021 at 11:23 AM Alexandru Ardelean wrote: > > The platform_set_drvdata() call is only useful if we need to retrieve back > the private information. > Since the driver doesn't do that, it's not useful to have it. > > If this is removed, we can also just do a direct return on > devm_gpiochip_add_data(). We don't need to print that this call failed as > there are other ways to log/see this during probe. > > Signed-off-by: Alexandru Ardelean > --- > drivers/gpio/gpio-da9055.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c > index 6ad0c37b862e..49446a030f10 100644 > --- a/drivers/gpio/gpio-da9055.c > +++ b/drivers/gpio/gpio-da9055.c > @@ -133,7 +133,6 @@ static int da9055_gpio_probe(struct platform_device *pdev) > { > struct da9055_gpio *gpio; > struct da9055_pdata *pdata; > - int ret; > > gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL); > if (!gpio) > @@ -146,15 +145,7 @@ static int da9055_gpio_probe(struct platform_device *pdev) > if (pdata && pdata->gpio_base) > gpio->gp.base = pdata->gpio_base; > > - ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio); > - if (ret < 0) { > - dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret); > - return ret; > - } > - > - platform_set_drvdata(pdev, gpio); > - > - return 0; > + return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio); > } > > static struct platform_driver da9055_gpio_driver = { > -- > 2.31.1 > Patch applied, thanks! Bart