All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2 5/5] gpio: aggregator: Remove trailing comma in terminator entries
Date: Fri, 22 Jan 2021 11:46:47 +0100	[thread overview]
Message-ID: <CAMpxmJXYJ+fanuHbEQ159ajLH=BoEfdmnqRUm=Zhqw=1GCOivw@mail.gmail.com> (raw)
In-Reply-To: <20210120214547.89770-5-andriy.shevchenko@linux.intel.com>

On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Remove trailing comma in terminator entries to avoid potential
> expanding an array behind it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpio-aggregator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c
> index 40a081b095fb..0cab833fbd81 100644
> --- a/drivers/gpio/gpio-aggregator.c
> +++ b/drivers/gpio/gpio-aggregator.c
> @@ -244,7 +244,7 @@ static DRIVER_ATTR_WO(delete_device);
>  static struct attribute *gpio_aggregator_attrs[] = {
>         &driver_attr_new_device.attr,
>         &driver_attr_delete_device.attr,
> -       NULL,
> +       NULL
>  };
>  ATTRIBUTE_GROUPS(gpio_aggregator);
>
> @@ -518,7 +518,7 @@ static const struct of_device_id gpio_aggregator_dt_ids[] = {
>          * Add GPIO-operated devices controlled from userspace below,
>          * or use "driver_override" in sysfs
>          */
> -       {},
> +       {}
>  };
>  MODULE_DEVICE_TABLE(of, gpio_aggregator_dt_ids);
>  #endif
> --
> 2.29.2
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

  parent reply	other threads:[~2021-01-22 10:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 21:45 [PATCH v2 1/5] lib/cmdline_kunit: add a new test case for get_options() Andy Shevchenko
2021-01-20 21:45 ` [PATCH v2 2/5] lib/cmdline: Update documentation to reflect behaviour Andy Shevchenko
2021-01-22 11:12   ` Bartosz Golaszewski
2021-01-20 21:45 ` [PATCH v2 3/5] lib/cmdline: Allow get_options() to take 0 to validate the input Andy Shevchenko
2021-01-22 11:15   ` Bartosz Golaszewski
2021-01-22 12:13     ` Andy Shevchenko
2021-01-20 21:45 ` [PATCH v2 4/5] gpio: aggregator: Replace isrange() by using get_options() Andy Shevchenko
2021-01-21 13:17   ` Linus Walleij
2021-01-22 10:47   ` Bartosz Golaszewski
2021-01-20 21:45 ` [PATCH v2 5/5] gpio: aggregator: Remove trailing comma in terminator entries Andy Shevchenko
2021-01-21 13:17   ` Linus Walleij
2021-01-21 17:09     ` Andy Shevchenko
2021-01-22 10:46       ` Bartosz Golaszewski
2021-01-22 10:46   ` Bartosz Golaszewski [this message]
2021-01-22 10:50   ` Geert Uytterhoeven
2021-01-22 11:11 ` [PATCH v2 1/5] lib/cmdline_kunit: add a new test case for get_options() Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMpxmJXYJ+fanuHbEQ159ajLH=BoEfdmnqRUm=Zhqw=1GCOivw@mail.gmail.com' \
    --to=bgolaszewski@baylibre.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.