From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E530FC433F5 for ; Thu, 23 Sep 2021 08:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6BE6124E for ; Thu, 23 Sep 2021 08:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239857AbhIWIMT (ORCPT ); Thu, 23 Sep 2021 04:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237996AbhIWIMS (ORCPT ); Thu, 23 Sep 2021 04:12:18 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44AF5C061757 for ; Thu, 23 Sep 2021 01:10:47 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id i132so19564851qke.1 for ; Thu, 23 Sep 2021 01:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1gg3dsSGVNcrvv3pRU06f1hq0fAMhtx1ktCnDl3V9Uw=; b=TlD70pmCUi7mEY5kGm4HRXI/fVhnJ8UCGL/T7dV4eopq1Qa3qgTxPmnOcmvRffCAxM boj0Kh51FNQTHrL7RT7dQDnkzprGxQJd8H/xP0pY7LJgI6u782XIrsqH17CeiFzo0eMu JB9umPI3pS31e0mib/ieVNHJ29w7EZYN6PGEW76yv+2wSS2EM3LPcW6/27+hTgaI7gwh tXncCOBzWOrkMVLfNJKozihaLHtJYUPQMVig05oTlOu25hiqBz43SlDkV165iweQ/SS8 GgjhVh0K6uPt9Y4N7sPXZUgu3Db8moGgSHR7ufHOTb9mH+54h7U4mQamVWc/YaOSvmrU I2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1gg3dsSGVNcrvv3pRU06f1hq0fAMhtx1ktCnDl3V9Uw=; b=J8kp983o0ZVs5yZkoDwLa0f4EX5IDPS58Rp1wSDQuNCw9RoxiuY7XoUGGIFKFsaDqS xygzjgNAUg9KferdSBs7r30B7Px4D6kwC0y1GWXbgXIrrCAi3MOsaVr4KCZ0NV0vSbHs Om0cH9AvCMSLM49pR+OwozQqdk01X/XVI7rYu0iqRm3QYvs4vQ0+tLrpAHNQFrQa9HaS R0cuyhg+SpulaYh78MNKBUJow01rQCR7rF2DEUUDShfkEJD6m/IHfh8LzVdL2DNivLnZ UzK3LFqKgJcGhSVPdTs7YhCh02387pZInzO9+YvwEy+abLXARBTTldtotuTutPnuI3JO ReUQ== X-Gm-Message-State: AOAM531WkPHOgzJdi7BpoKgn6480BfVRAhm7ZCsmqWHfNsX2mT93RonO avUwShKroHfE+Mxa4seWGDsVmFMVSj0EEs1lLpKt0Q== X-Google-Smtp-Source: ABdhPJzl47I6W4T7o0+dQTSaJ68pEUavxfNjv+tG8P8ZoKJDBgVU40dNKlSLPFyJA3Ad8aXcLSTmGGxbWl2B5joI9P0= X-Received: by 2002:a5b:783:: with SMTP id b3mr3845515ybq.328.1632384646402; Thu, 23 Sep 2021 01:10:46 -0700 (PDT) MIME-Version: 1.0 References: <20210922135319.3128153-1-piyush.mehta@xilinx.com> In-Reply-To: <20210922135319.3128153-1-piyush.mehta@xilinx.com> From: Bartosz Golaszewski Date: Thu, 23 Sep 2021 10:10:35 +0200 Message-ID: Subject: Re: [PATCH V4 0/3] gpio: modepin: Add driver support for modepin GPIO controller To: Piyush Mehta Cc: Arnd Bergmann , Zou Wei , Greg KH , Linus Walleij , Michal Simek , wendy.liang@xilinx.com, Nobuhiro Iwamatsu , Rob Herring , rajan.vaja@xilinx.com, linux-gpio , linux-devicetree , git , Srinivas Goud , arm-soc , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Sep 22, 2021 at 3:53 PM Piyush Mehta wrote: > > This patch adds support for the zynqmp modepin GPIO controller and > documented for the same. GPIO modepin driver set and get the value and > status of the PS_MODE pin, based on device-tree pin configuration. > These four-bits boot-mode pins are dedicated configurable as input/output. > After the stabilization of the system,these mode pins are sampled. > > To access GPIO pins, added Xilinx ZynqMP firmware MDIO API support to > set and get PS_MODE pins value and status. These APIs are interface > APIs, between the mode pin controller driver and low-level API. > > --- > Changes in v2: > - Added Xilinx ZynqMP firmware MMIO API support to set and get pin > value and status. > - DT Documentation- Addressed review comments: Update commit message > - Modepin driver- Addressed review comments: > - Update APIs > - Removed unwanted variables > - Handle return path for probe function > > Review Comments: > https://lore.kernel.org/linux-arm-kernel/20210624205055.GA1961487@robh.at.kernel.org/T/#u > > Changes in v3: > - Update example in dt-bindings documentation > - Update probe function return value > - Remove unnecessary print and header file > > Review Comments: > https://lore.kernel.org/linux-arm-kernel/20210805174219.3000667-1-piyush.mehta@xilinx.com/#t > > Changes in v4: > - Added input pin read status in modepin_gpio_get_value. > - Updated modepin control bit for out configuration. > > Review Comments: > https://lore.kernel.org/linux-arm-kernel/554508f5-8cb5-3840-9f61-f6cd6e5745d2@xilinx.com/T/#u > --- > > Piyush Mehta (3): > firmware: zynqmp: Add MMIO read and write support for PS_MODE pin > dt-bindings: gpio: zynqmp: Add binding documentation for modepin > gpio: modepin: Add driver support for modepin GPIO controller > > .../bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml | 43 ++++++ > drivers/firmware/xilinx/zynqmp.c | 46 ++++++ > drivers/gpio/Kconfig | 12 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-zynqmp-modepin.c | 162 +++++++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 14 ++ > 6 files changed, 278 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml > create mode 100644 drivers/gpio/gpio-zynqmp-modepin.c > > -- > 2.7.4 > Series queued for next. Thanks! Bart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE28C433EF for ; Thu, 23 Sep 2021 08:12:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89B4561242 for ; Thu, 23 Sep 2021 08:12:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 89B4561242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ClFCB/a0ZyJ3qffYtsBiTiOtUHjQitO9UuDccgiPj3Y=; b=mY4Rv6SeFuq69U 4lPaTp7r6U1yqWGlQ51zaMprcc4UMhLRvoGD1Fmb9PJI0uwA/DIk7f9vM7R3v5iXDrNWMwzucaKaS Tc2fTm5rnPINFUik7X3RBLGYUZfEa46Pkp7Z2Bq+sUQcRR8Oy4BGSJz8f3M2uwSoM8JJlxa7vWRW2 Zfs796mzk+fGjLc1VcxaaopzVsmAwyR3wl7Hu13Z+xuOwsOryAjIsHGR2opmlB5AWHZYeB2NrnZMB 0yDqjdvLqCWaPHLT0dCbA9gI+PeN+5846n38vfwSwalvRkZ2o4uoDaCAIfEfSYIFTwzRtA+yTQtW0 h0MjwenrPwcRTQ2STZZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTJoj-00AbFM-1Q; Thu, 23 Sep 2021 08:10:53 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTJod-00AbDO-Qw for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 08:10:50 +0000 Received: by mail-qk1-x732.google.com with SMTP id 73so19393746qki.4 for ; Thu, 23 Sep 2021 01:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1gg3dsSGVNcrvv3pRU06f1hq0fAMhtx1ktCnDl3V9Uw=; b=TlD70pmCUi7mEY5kGm4HRXI/fVhnJ8UCGL/T7dV4eopq1Qa3qgTxPmnOcmvRffCAxM boj0Kh51FNQTHrL7RT7dQDnkzprGxQJd8H/xP0pY7LJgI6u782XIrsqH17CeiFzo0eMu JB9umPI3pS31e0mib/ieVNHJ29w7EZYN6PGEW76yv+2wSS2EM3LPcW6/27+hTgaI7gwh tXncCOBzWOrkMVLfNJKozihaLHtJYUPQMVig05oTlOu25hiqBz43SlDkV165iweQ/SS8 GgjhVh0K6uPt9Y4N7sPXZUgu3Db8moGgSHR7ufHOTb9mH+54h7U4mQamVWc/YaOSvmrU I2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1gg3dsSGVNcrvv3pRU06f1hq0fAMhtx1ktCnDl3V9Uw=; b=XrYEzm3eCZKqmhcTNgvDIYd1T1BMleeNwvdwevVR2vgXZPs0JHE758+j6Bpc657zrd NLy6V2/DsuGT4VI+JQf9JsExov/jx2J59Y5MqiOWxi670Jz9kfeKLPNcn/pF+0l7L/FE K5b7eQAp/Tn7nplR8l6Mpkz1TjtHxWrEmCHtW1t/Nk8ullyLacg6CJL8YqfhGVT9JvqP 8smVlMYHW0KZzujrdhjYyLv2/NFf2YSErw2fxJDsahQ+x8hyTpMyktU9CDq2kgLmidFv Ym4BlC4XRzkcf60lLjPmNF73tfwaY5H+Izux+FjY+nDw5qeY4uERWUCgQHxT+a57vg/1 AAOA== X-Gm-Message-State: AOAM532WLCgJeNrmuYgyxFnLbg81Gf70GJgMZnLm2cb3ygwSeRZYn80P 5GpOoLo8bm24NFrgN6KSs2MQJvoGw7SSLaJJtQ42CQ== X-Google-Smtp-Source: ABdhPJzl47I6W4T7o0+dQTSaJ68pEUavxfNjv+tG8P8ZoKJDBgVU40dNKlSLPFyJA3Ad8aXcLSTmGGxbWl2B5joI9P0= X-Received: by 2002:a5b:783:: with SMTP id b3mr3845515ybq.328.1632384646402; Thu, 23 Sep 2021 01:10:46 -0700 (PDT) MIME-Version: 1.0 References: <20210922135319.3128153-1-piyush.mehta@xilinx.com> In-Reply-To: <20210922135319.3128153-1-piyush.mehta@xilinx.com> From: Bartosz Golaszewski Date: Thu, 23 Sep 2021 10:10:35 +0200 Message-ID: Subject: Re: [PATCH V4 0/3] gpio: modepin: Add driver support for modepin GPIO controller To: Piyush Mehta Cc: Arnd Bergmann , Zou Wei , Greg KH , Linus Walleij , Michal Simek , wendy.liang@xilinx.com, Nobuhiro Iwamatsu , Rob Herring , rajan.vaja@xilinx.com, linux-gpio , linux-devicetree , git , Srinivas Goud , arm-soc , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_011047_987759_8969C880 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 22, 2021 at 3:53 PM Piyush Mehta wrote: > > This patch adds support for the zynqmp modepin GPIO controller and > documented for the same. GPIO modepin driver set and get the value and > status of the PS_MODE pin, based on device-tree pin configuration. > These four-bits boot-mode pins are dedicated configurable as input/output. > After the stabilization of the system,these mode pins are sampled. > > To access GPIO pins, added Xilinx ZynqMP firmware MDIO API support to > set and get PS_MODE pins value and status. These APIs are interface > APIs, between the mode pin controller driver and low-level API. > > --- > Changes in v2: > - Added Xilinx ZynqMP firmware MMIO API support to set and get pin > value and status. > - DT Documentation- Addressed review comments: Update commit message > - Modepin driver- Addressed review comments: > - Update APIs > - Removed unwanted variables > - Handle return path for probe function > > Review Comments: > https://lore.kernel.org/linux-arm-kernel/20210624205055.GA1961487@robh.at.kernel.org/T/#u > > Changes in v3: > - Update example in dt-bindings documentation > - Update probe function return value > - Remove unnecessary print and header file > > Review Comments: > https://lore.kernel.org/linux-arm-kernel/20210805174219.3000667-1-piyush.mehta@xilinx.com/#t > > Changes in v4: > - Added input pin read status in modepin_gpio_get_value. > - Updated modepin control bit for out configuration. > > Review Comments: > https://lore.kernel.org/linux-arm-kernel/554508f5-8cb5-3840-9f61-f6cd6e5745d2@xilinx.com/T/#u > --- > > Piyush Mehta (3): > firmware: zynqmp: Add MMIO read and write support for PS_MODE pin > dt-bindings: gpio: zynqmp: Add binding documentation for modepin > gpio: modepin: Add driver support for modepin GPIO controller > > .../bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml | 43 ++++++ > drivers/firmware/xilinx/zynqmp.c | 46 ++++++ > drivers/gpio/Kconfig | 12 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-zynqmp-modepin.c | 162 +++++++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 14 ++ > 6 files changed, 278 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml > create mode 100644 drivers/gpio/gpio-zynqmp-modepin.c > > -- > 2.7.4 > Series queued for next. Thanks! Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel