All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nir Soffer <nirsof@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Nir Soffer <nsoffer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests
Date: Mon, 6 Feb 2017 16:25:02 +0200	[thread overview]
Message-ID: <CAMr-obtbdiSJb0zqOsdptJSv2PgcOANMEB_BYj2rg42mPjH8Sg@mail.gmail.com> (raw)
In-Reply-To: <20170206102019.GC5377@lemon.lan>

This was created by mistake with --no-thread and no cover letter, I
was confused by the instructions in the wiki, warning not to send
multiple patches in the same thread.

I already sent v4 and v5 properly.

Thanks for the comments,
Nir

On Mon, Feb 6, 2017 at 12:20 PM, Fam Zheng <famz@redhat.com> wrote:
> On Sat, 01/28 05:59, Nir Soffer wrote:
>> From: Nir Soffer <nsoffer@redhat.com>
>>
>> Add regression tests checking that qemu-io fail with non-zero exit code
>> when reading non-existing file or using the wrong format.
>>
>> Signed-off-by: Nir Soffer <nirsof@gmail.com>
>
> This message is not correctly threaded as a reply to a v3 cover letter, and it's
> hard to review. Please check your git command lines comform to the instructions
> in
>
> http://wiki.qemu-project.org/Contribute/SubmitAPatch#Submitting_your_Patches
>
> Particularly, --cover-letter and --thread should be used in git-format-email.
>
> Fam

  reply	other threads:[~2017-02-06 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28  3:59 [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests Nir Soffer
2017-02-06 10:20 ` Fam Zheng
2017-02-06 14:25   ` Nir Soffer [this message]
2017-02-06 14:41     ` Fam Zheng
2017-01-30 11:55 [Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure Nir Soffer
2017-01-30 11:55 ` [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests Nir Soffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMr-obtbdiSJb0zqOsdptJSv2PgcOANMEB_BYj2rg42mPjH8Sg@mail.gmail.com \
    --to=nirsof@gmail.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=nsoffer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.