From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3B1C4BA24 for ; Thu, 27 Feb 2020 09:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8241B2467F for ; Thu, 27 Feb 2020 09:26:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vXS4LjAi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728655AbgB0J0D (ORCPT ); Thu, 27 Feb 2020 04:26:03 -0500 Received: from mail-vk1-f194.google.com ([209.85.221.194]:39173 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728624AbgB0J0D (ORCPT ); Thu, 27 Feb 2020 04:26:03 -0500 Received: by mail-vk1-f194.google.com with SMTP id t129so533898vkg.6 for ; Thu, 27 Feb 2020 01:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XKhO1AQ00NQAb2mxlmISdfwyHlX7vjWtP3qsga5GwBM=; b=vXS4LjAiJ4ELHEh0mx10EpqmGWL50wYXysbYgFM+seolegvNnlf5VJqjAoEKOUsvFW g17Y+FeGDY4QEdlF6PX+PaPR8ITq4lBCgFq8HK7duF4qLDT+yoXc8seyiBcUR5G6j2pD 5Tjus1dZRJ4eMJJlMQdVlmik+/GYDMxON8suKoZfE+dqwii+R/v9eKhZC9RruGLOsoCW cSkPM+TX+x9Pfz97h8ZKdXixr+iciwtrlBpMpoJ4SMB6xyyhBoCPozJcJBD6uSJEDEye XN1c5cr26sozJ5DbiYr+lxvGuLyma6R5yIIPT7+cesZmnV/cqYDr0X8Kr4gbgoh9SKov P6pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XKhO1AQ00NQAb2mxlmISdfwyHlX7vjWtP3qsga5GwBM=; b=eEOA4T+KZWadOxKJcqxuuLHjgFawH4Lu4nQXHrsUazWUxV3FRROFxDg4UjUIjMKwBM bn8AvktamKVtS2wutqG7XZ09NBPPcvpXhbErmOTnWtu91aBHdzhOUGUMHxkhSX/tKANN o9Fm+LoSrxy4t5E5YwXUtrdKzZTu6mZYoktjxl7vt7AQR2d4lC0n04bB9tRageRtvQUO jTM+Poe9omS7xf52ed6BPSxlLS10M970EGaeyZKhn+XyjUEJk47ThTvg+rziS1PFfDeN fyXHtfTMZOxvLaU2RK9BPJQ0G2j9zfxy5UrgroEjxsaoScYW3OtC4YxrVCU0K9CJEQ09 vM6A== X-Gm-Message-State: APjAAAXK1VUtmLSLjOQefVrEChJG3+6b8xtxH/C+gb0z56bVgTAF5A1m hfTfmFtLG8TZAppHZXme4P04dTXbez+L6JellMw= X-Google-Smtp-Source: APXvYqwY+o2PgZpq0I8t22A/4AUUHc81pvfiagrPCAYKch0tsrlsBLxiPNwwpiA0Ygx+eqlwBwwzb6M/3tfbf1YWCjA= X-Received: by 2002:a1f:b6d7:: with SMTP id g206mr2114238vkf.8.1582795560965; Thu, 27 Feb 2020 01:26:00 -0800 (PST) MIME-Version: 1.0 References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-5-kyan@google.com> In-Reply-To: <20191119060610.76681-5-kyan@google.com> From: Justin Capella Date: Thu, 27 Feb 2020 01:25:50 -0800 Message-ID: Subject: Re: [PATCH v11 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Johannes Berg , linux-wireless , make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name, Yibo Zhao , John Crispin , lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com, Kan Yan Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > ieee80211_report_used_skb(). As an optimisation, we also subtract the > airtime on regular TX completion, zeroing out the value stored in the > packet afterwards, to avoid having to do an expensive lookup of the station > from the packet data on every packet. > > This patch does *not* include any mechanism to wake a throttled TXQ again, > on the assumption that this will happen anyway as a side effect of whatever > freed the skb (most commonly a TX completion). I recall a recent patch for ath10k sdio that disabled tx acknowledgement for performance gains and am wondering if that will be problematic? Presumably not since it would be caught at the dequeue, but thought I'd ask-- wondering what the effect of failed tx's or block acknowledgement is on this stuff I'll need to study the code some more https://lore.kernel.org/linux-wireless/0101016eb1903db0-ef7063b4-0f42-4a01-8886-327541e6c1a4-000000@us-west-2.amazonses.com/T/#t