From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH v6 09/13] rockchip: rk3399: Add Nanopc T4 board support Date: Tue, 7 May 2019 17:58:23 +0530 Message-ID: References: <20190427114852.7608-1-jagan@amarulasolutions.com> <20190427114852.7608-10-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Paul Kocialkowski Cc: Tom Rini , U-Boot-Denx , linux-rockchip@lists.infradead.org, Akash Gajjar , Manivannan Sadhasivam , linux-amarula List-Id: linux-rockchip.vger.kernel.org T24gVHVlLCBNYXkgNywgMjAxOSBhdCAyOjQyIFBNIFBhdWwgS29jaWFsa293c2tpCjxwYXVsLmtv Y2lhbGtvd3NraUBib290bGluLmNvbT4gd3JvdGU6Cj4KPiBIaSwKPgo+IE9uIFNhdCwgMjAxOS0w NC0yNyBhdCAxNzoxOCArMDUzMCwgSmFnYW4gVGVraSB3cm90ZToKPiA+IGRpZmYgLS1naXQgYS9i b2FyZC9yb2NrY2hpcC9ldmJfcmszMzk5L01BSU5UQUlORVJTIGIvYm9hcmQvcm9ja2NoaXAvZXZi X3JrMzM5OS9NQUlOVEFJTkVSUwo+ID4gaW5kZXggYWU0MzgwNWE2YS4uNTkxN2FiYjljMSAxMDA2 NDQKPiA+IC0tLSBhL2JvYXJkL3JvY2tjaGlwL2V2Yl9yazMzOTkvTUFJTlRBSU5FUlMKPiA+ICsr KyBiL2JvYXJkL3JvY2tjaGlwL2V2Yl9yazMzOTkvTUFJTlRBSU5FUlMKPiA+IEBAIC02LDYgKzYs MTIgQEAgRjogICAgICBpbmNsdWRlL2NvbmZpZ3MvZXZiX3JrMzM5OS5oCj4gPiAgRjogICAgICBj b25maWdzL2V2Yi1yazMzOTlfZGVmY29uZmlnCj4gPiAgRjogICAgICBjb25maWdzL2ZpcmVmbHkt cmszMzk5X2RlZmNvbmZpZwo+ID4KPiA+ICtOQU5PUEMtVDQKPiA+ICtNOiAgIEphZ2FuIFRla2kg PGphZ2FuQGFtYXJ1bGFzb2x1dGlvbnMuY29tPgo+ID4gK1M6ICAgTWFpbnRhaW5lZAo+ID4gK0Y6 ICAgY29uZmlncy9uYW5vcGljLXQ0LXJrMzM5OV9kZWZjb25maWcKPiA+ICtGOiAgIGFyY2gvYXJt L2R0cy9yazMzOTktbmFub3BpYy10NC11LWJvb3QuZHRzaQo+ID4gKwo+Cj4gTWhoLCBJIGZlZWwg bGlrZSBlYWNoIG5ldyBib2FyZCB0aGF0IHlvdSBhcmUgaW50cm9kdWNpbmcgc2hvdWxkIGhhdmUK PiBpdHMgb3duIGJvYXJkIGRpcmVjdG9yeSAtLSB0aGlzIGJvYXJkIGlzIGRlZmluaXRlbHkgbm90 IGEgcmszMzk5IGV2Ygo+IG1hZGUgYnkgcm9ja2NoaXAsIGJ1dCBhbm90aGVyIGJvYXJkLgoKVGhl IGJlaGF2aW9yIG9mIGFsbCB0aGVzZSBhZGRlZCBib2FyZHMgcmVtYWlucyBzaW1pbGFyIGxpa2Ug ZXZiLCBzbwppbnN0ZWFkIG9mIGFkZGluZyBzZXBhcmF0ZSBib2FyZCBkaXJlY3Rvcnkgd2l0aCBy ZWR1bmRhbnQgY29kZSB0aGlzCnBhdGNoIHVzZXMgZXhpc3Rpbmcgc3R1ZmYuIElkZWEgaXMgdG8g bWFrZSBjb21tb24gYm9hcmQgZGlyZWN0b3J5IGFzCnJrMzM5OSwgdGhhdCBoYXZlIHNlcGFyYXRl IHJld29yayBwbGFuZWQuCgo+Cj4gSSBoYXZlIGFscmVhZHkgcGF0Y2hlcyB0byBzcGxpdCB0aGF0 IGZvciB0aGUgZmlyZWZseS1yazMzOTksIGJ1dCBJCj4gY2Fubm90IHJlYWxseSB0ZXN0IHRoZW0g b3V0c2lkZSBvZiBidWlsZGluZy4KCkRvIHlvdSBoYXZlIGFueSBzcGVjaWZpYyBib2FyZCBjb2Rl IGZvciB0aGlzIGZpcmVmbHksIEkgd291bGQgc3VnZ2VzdAp0byBrZWVwIHVzZSBldmIgc2luY2Ug bW9zdCBvZiB0aGUgcGVyaXBoZXJhbCBoYW5kbGluZyBpbiByb2NrY2hpcCBkb25lCnZpYSBkdCBz byB3ZSBjYW4gZ28tYWhlYWQgdy9vIHNlcGFyYXRpbmcgdGhlIGJvYXJkIGNvZGUgYXRsZWFzdCBm b3IKdGhlc2UgYm9hcmRzLgoKPgo+ID4gIE5BTk9QSS1NNAo+ID4gIE06ICAgSmFnYW4gVGVraSA8 amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+Cj4gPiAgUzogICBNYWludGFpbmVkCj4gPiBkaWZm IC0tZ2l0IGEvY29uZmlncy9uYW5vcGMtdDQtcmszMzk5X2RlZmNvbmZpZyBiL2NvbmZpZ3MvbmFu b3BjLXQ0LXJrMzM5OV9kZWZjb25maWcKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRl eCAwMDAwMDAwMDAwLi43YmE0Zjg1NDg1Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9jb25m aWdzL25hbm9wYy10NC1yazMzOTlfZGVmY29uZmlnCj4gPiBAQCAtMCwwICsxLDU4IEBACj4KPiBB bHNvIEkgZG9uJ3Qgc2VlIHdoaWNoIFRBUkdFVCBpcyBzZWxlY3RlZCBoZXJlLCBpcyB0aGVyZSBh IGZhbGxiYWNrIG9uCj4gdGhlIFJLMzM5OSBFVkIgZm9yIHRoZSByazMzOTkgcGxhdGZvcm0/CgpJ dCB3aWxsIHNlbGVjdCB0aGUgRVZCIGZyb20gbWFjaC1yb2NrY2hpcCBieSBkZWZhdWx0LCBpZSBy ZWFzb24gSQpkaWRuJ3QgbWVudGlvbmVkIGV4cGxpY2l0bHkuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClUtQm9vdCBtYWlsaW5nIGxpc3QKVS1Cb290QGxp c3RzLmRlbnguZGUKaHR0cHM6Ly9saXN0cy5kZW54LmRlL2xpc3RpbmZvL3UtYm9vdAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Tue, 7 May 2019 17:58:23 +0530 Subject: [U-Boot] [PATCH v6 09/13] rockchip: rk3399: Add Nanopc T4 board support In-Reply-To: References: <20190427114852.7608-1-jagan@amarulasolutions.com> <20190427114852.7608-10-jagan@amarulasolutions.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 7, 2019 at 2:42 PM Paul Kocialkowski wrote: > > Hi, > > On Sat, 2019-04-27 at 17:18 +0530, Jagan Teki wrote: > > diff --git a/board/rockchip/evb_rk3399/MAINTAINERS b/board/rockchip/evb_rk3399/MAINTAINERS > > index ae43805a6a..5917abb9c1 100644 > > --- a/board/rockchip/evb_rk3399/MAINTAINERS > > +++ b/board/rockchip/evb_rk3399/MAINTAINERS > > @@ -6,6 +6,12 @@ F: include/configs/evb_rk3399.h > > F: configs/evb-rk3399_defconfig > > F: configs/firefly-rk3399_defconfig > > > > +NANOPC-T4 > > +M: Jagan Teki > > +S: Maintained > > +F: configs/nanopic-t4-rk3399_defconfig > > +F: arch/arm/dts/rk3399-nanopic-t4-u-boot.dtsi > > + > > Mhh, I feel like each new board that you are introducing should have > its own board directory -- this board is definitely not a rk3399 evb > made by rockchip, but another board. The behavior of all these added boards remains similar like evb, so instead of adding separate board directory with redundant code this patch uses existing stuff. Idea is to make common board directory as rk3399, that have separate rework planed. > > I have already patches to split that for the firefly-rk3399, but I > cannot really test them outside of building. Do you have any specific board code for this firefly, I would suggest to keep use evb since most of the peripheral handling in rockchip done via dt so we can go-ahead w/o separating the board code atleast for these boards. > > > NANOPI-M4 > > M: Jagan Teki > > S: Maintained > > diff --git a/configs/nanopc-t4-rk3399_defconfig b/configs/nanopc-t4-rk3399_defconfig > > new file mode 100644 > > index 0000000000..7ba4f85485 > > --- /dev/null > > +++ b/configs/nanopc-t4-rk3399_defconfig > > @@ -0,0 +1,58 @@ > > Also I don't see which TARGET is selected here, is there a fallback on > the RK3399 EVB for the rk3399 platform? It will select the EVB from mach-rockchip by default, ie reason I didn't mentioned explicitly.