From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE45C49EA7 for ; Thu, 24 Jun 2021 12:32:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 786CD6054E for ; Thu, 24 Jun 2021 12:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbhFXMfJ (ORCPT ); Thu, 24 Jun 2021 08:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbhFXMfI (ORCPT ); Thu, 24 Jun 2021 08:35:08 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31962C061756 for ; Thu, 24 Jun 2021 05:32:49 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id mj3so1826876ejb.4 for ; Thu, 24 Jun 2021 05:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=VT4Xbs/6+8YEG5ok69Cp66JqzZQH90fw7I76MXbLk3uomJANwnomPoo574oC5hjoQ4 EKQdDKf9yDx4L7r2cF62JOT40zbd68qIkBdugdNROO5ALrOarxqS15JpQUzu+iBlP/bO FZoTBAM7u3HhTjWJ9SuTe5GD1eTpfsr8wdQVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=qi5XZnzttGnLVTvP1IDTHj5ftkSXyhRSjcX8MlfTKpQUjlUn8lXvm4wHeLFzab1G38 2ABK7LqLRgdAi1hRlI9DkHFWdVEFyN32ZLsYVoV5a/lAiPVR7c1MuGUd+nTNlQRJwIdX 10qsxtVnUlXuQp/BZ0pSsNIdVuMWlIDzlCnhgReg/h9nXwBEvTpM9iw20QhnBkSzSPy1 SDWitJpZ+IJZVRlAADOLuJAHPuaINllcwW08j4NSStucarxvfnTz/pbTqic1NLWCR81t jUzXi8oCZl7UtG8ojLQ0iPukpxaAwhtIFdpKUgzuP/5dRoQRJ8E1kuXC6ZXBXFKyrESl y0UA== X-Gm-Message-State: AOAM533MhOCmHWkuhzZPgHlNlU7AfCZGnWz2UERPpwsZv2aa+f/uhru7 SjajaEkfhAmH0cFjIubXIuURyN8o1/5GTfQFKFeiQw== X-Google-Smtp-Source: ABdhPJy9346wJ7pgPh41de3TKx9jGsDYkXgGD+VTQowScqmus3DWBHWMTQtjBZGWKBfvb/2N8Rflzvh3mC8Utrm9SqA= X-Received: by 2002:a17:906:718b:: with SMTP id h11mr5091976ejk.418.1624537967775; Thu, 24 Jun 2021 05:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 24 Jun 2021 18:02:36 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > that driver instead of adding a new one for the same IP core ? > > > > > > Yes. there was an attempt from Michael in this direction: > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > Thanks for the reference, I will check it out and see I can send any > > updated versions wrt my i.MX8MM platform. > > Thanks. > > I had a brief look at the exynos driver, and I think it should be turned > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > Is there someone from Samsung who could assist, at least to test the > changes ? I have hardware to verify it on i.MX8MM but from exynos I don't have any contact from Samsung to suggest or test. Maybe I can add Tomasz Figa while sending the changes? I understand that there are 2 key implementations. 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM flow with LCDIF doesn't have component_ops (make sure it works with exynos platform first) 2. Sec DSIM Bridge driver common cross Exynos and i.MX8MM platform drivers or only one Sec DSIM bridge driver to handle both the platforms by differentiating compatible and driver data Any more suggestions would be appreciated? Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EAA7C48BDF for ; Thu, 24 Jun 2021 12:34:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66CC0600EF for ; Thu, 24 Jun 2021 12:34:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66CC0600EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vg2KIN86lPL0pw2uDr++5bG3qrH7zY8oCgDtb2SaERw=; b=snbuMuzMvLsLlP iW7+/udacqp3mHDVjc4AecccVwb+YYmqNIw2dtJHdspkoVr/yoFY3oCip5wSljVva0WUFHmvU3R7c CGDKOd+eCrKWsUyiZpmJSaj6XHtzfLIqjchMbJ68vlbc7Dmz1BJXqXypCtr7Dd6x+fd8lwYX1mZge u0oLc7X7sOpNCVrmVrj8bepiNTxuOKKAh/TwRE3d9GaGzxvXaDW996TI87xfed+8qOl4uoixRXxcU LR8YyW3am+jHdXwkv63qm/1WImNKR1CMbl/xr/86aXjYFM0kMiww/m3wubpUqNxE0t7VBba4lOIym sIsCc6zf7LvBxzC+a0Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwOXO-00EcGU-14; Thu, 24 Jun 2021 12:32:54 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwOXJ-00EcEt-6b for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 12:32:51 +0000 Received: by mail-ej1-x636.google.com with SMTP id hz1so9297641ejc.1 for ; Thu, 24 Jun 2021 05:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=VT4Xbs/6+8YEG5ok69Cp66JqzZQH90fw7I76MXbLk3uomJANwnomPoo574oC5hjoQ4 EKQdDKf9yDx4L7r2cF62JOT40zbd68qIkBdugdNROO5ALrOarxqS15JpQUzu+iBlP/bO FZoTBAM7u3HhTjWJ9SuTe5GD1eTpfsr8wdQVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=avT7fUuHmshLFArBYELoBVN2uVV1ob3aX9/7OROkbj4JTTXLT7F/OeUNfI2qQt3qPk eMuEALIyzjGlIoni/4x0WfwoHAoIOVXHjcnQPl2v3s6izwhV4yC1MYovFj+4UaiVjkNB u0L6MYY2EEgjlIYbkFo7RDOVnI7GkZ6etLw5Iecwbw5ZeVtwN9om0BiaiI+qJYf8OsMA wL2AnF35Gw6OAkh87Jdks68jKD/ko911ziqcb7oZ4OhDMIkqlM/Ysy+KlF8OpuU/wdNI CCW+zRpjq5kIwTKqHEYdWZeAlt/524Lqw4FIEQaQOraosm7g+Uj2ZDwtbz0ls5cSOW3K I8Kg== X-Gm-Message-State: AOAM530lhF8KsgfSkDUgLMDean2d9JLQ1QZ7SOdC2NPcq3LmMSNR1cKO bBKc24K4RrEnyOrhltmEQH/ECB6XmvoG+p6j5KarFQ== X-Google-Smtp-Source: ABdhPJy9346wJ7pgPh41de3TKx9jGsDYkXgGD+VTQowScqmus3DWBHWMTQtjBZGWKBfvb/2N8Rflzvh3mC8Utrm9SqA= X-Received: by 2002:a17:906:718b:: with SMTP id h11mr5091976ejk.418.1624537967775; Thu, 24 Jun 2021 05:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 24 Jun 2021 18:02:36 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_053249_690576_9A4CC9DF X-CRM114-Status: GOOD ( 24.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > that driver instead of adding a new one for the same IP core ? > > > > > > Yes. there was an attempt from Michael in this direction: > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > Thanks for the reference, I will check it out and see I can send any > > updated versions wrt my i.MX8MM platform. > > Thanks. > > I had a brief look at the exynos driver, and I think it should be turned > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > Is there someone from Samsung who could assist, at least to test the > changes ? I have hardware to verify it on i.MX8MM but from exynos I don't have any contact from Samsung to suggest or test. Maybe I can add Tomasz Figa while sending the changes? I understand that there are 2 key implementations. 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM flow with LCDIF doesn't have component_ops (make sure it works with exynos platform first) 2. Sec DSIM Bridge driver common cross Exynos and i.MX8MM platform drivers or only one Sec DSIM bridge driver to handle both the platforms by differentiating compatible and driver data Any more suggestions would be appreciated? Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB73C49EA6 for ; Thu, 24 Jun 2021 12:32:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6FAF6054E for ; Thu, 24 Jun 2021 12:32:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6FAF6054E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F04B6EB79; Thu, 24 Jun 2021 12:32:50 +0000 (UTC) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F1676EB04 for ; Thu, 24 Jun 2021 12:32:49 +0000 (UTC) Received: by mail-ej1-x631.google.com with SMTP id hc16so9182940ejc.12 for ; Thu, 24 Jun 2021 05:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=VT4Xbs/6+8YEG5ok69Cp66JqzZQH90fw7I76MXbLk3uomJANwnomPoo574oC5hjoQ4 EKQdDKf9yDx4L7r2cF62JOT40zbd68qIkBdugdNROO5ALrOarxqS15JpQUzu+iBlP/bO FZoTBAM7u3HhTjWJ9SuTe5GD1eTpfsr8wdQVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=qSSJ4LKStroQrkXPLo7YGmgXjm6jjxNLwq5A3mAIfuZq5vQpW7epS5MkFxEXxe6Sb3 0iQXsJgsYuuxfDs7dacchTXX796c6zGFjCh0nukIFYXW1iy4ZmYxnbaUHIHzxsl3ETHx PRjtYJADsbNejkUPD9/x1WfpgDZn5YkGVb3uaAmmr2Y9ONahMjgmxTuV36w0bZcTC4T7 jqNPcOq6RM34EF2LsJshdoK2xkJ9C4hEG/r6+qmE77NE0fN3VUv/Udr04qgAPFIWNQvR CH75GTnmu0DEzRXSE9Qv5UNXDpWn6IPVOa86WBCfVwOQPrgQXxNJ+JEtv8LUlweUECNI BcmA== X-Gm-Message-State: AOAM530CWizs8pcHBYcHACgclDbt85o9nEgIZTOVKX9R/o95Qz8AkExs W0MG/Tk0XQGbF7dJiXylcDH7xq57JLkJYejE1V+r0A== X-Google-Smtp-Source: ABdhPJy9346wJ7pgPh41de3TKx9jGsDYkXgGD+VTQowScqmus3DWBHWMTQtjBZGWKBfvb/2N8Rflzvh3mC8Utrm9SqA= X-Received: by 2002:a17:906:718b:: with SMTP id h11mr5091976ejk.418.1624537967775; Thu, 24 Jun 2021 05:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 24 Jun 2021 18:02:36 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , Sascha Hauer , Michael Tretter , Robert Foss , linux-kernel , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Shawn Guo , Fancy Fang , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > that driver instead of adding a new one for the same IP core ? > > > > > > Yes. there was an attempt from Michael in this direction: > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > Thanks for the reference, I will check it out and see I can send any > > updated versions wrt my i.MX8MM platform. > > Thanks. > > I had a brief look at the exynos driver, and I think it should be turned > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > Is there someone from Samsung who could assist, at least to test the > changes ? I have hardware to verify it on i.MX8MM but from exynos I don't have any contact from Samsung to suggest or test. Maybe I can add Tomasz Figa while sending the changes? I understand that there are 2 key implementations. 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM flow with LCDIF doesn't have component_ops (make sure it works with exynos platform first) 2. Sec DSIM Bridge driver common cross Exynos and i.MX8MM platform drivers or only one Sec DSIM bridge driver to handle both the platforms by differentiating compatible and driver data Any more suggestions would be appreciated? Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6F2C49EA5 for ; Thu, 24 Jun 2021 12:32:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DF6F613FE for ; Thu, 24 Jun 2021 12:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DF6F613FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CQXQrEpRViQg5YtrYih7kXi/r+xV94+BohywG1AWc/Y=; b=M29X1JRP1tmBCO Ovauk0VPqsSksNiaXAoZbbGtLEoDXnX0IBgomW/nZVyISwWIjuV6jZSGzbQ2lIQyI14FP+UqQvCoI /sLqRBW3qo5GbSmtOVPiHY7Ou3d2tXq4h0o0qtW0UmSnI9jXtkjoDhd/RtbHl/QRUN1SoYGZgmcbv Cm0UCnPzPWZaSn1EONOT8DAEhCxs9WNgS9rVbhXn5dvmTL68nfCGXtH/sOtmgzLhtf5FxynlCt0P1 w8RA4/1OEoUQOaUn/ezAEZdbjGbgaOdZbUrLGz0WRJTWKTRGqz70AE9IXyrpUNzTZ3JjHSfIaXn6a 594O0SOyffUo1AiqTeow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwOXM-00EcGL-Kx; Thu, 24 Jun 2021 12:32:52 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwOXJ-00EcEs-5a for linux-phy@lists.infradead.org; Thu, 24 Jun 2021 12:32:51 +0000 Received: by mail-ej1-x630.google.com with SMTP id ot9so8263332ejb.8 for ; Thu, 24 Jun 2021 05:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=VT4Xbs/6+8YEG5ok69Cp66JqzZQH90fw7I76MXbLk3uomJANwnomPoo574oC5hjoQ4 EKQdDKf9yDx4L7r2cF62JOT40zbd68qIkBdugdNROO5ALrOarxqS15JpQUzu+iBlP/bO FZoTBAM7u3HhTjWJ9SuTe5GD1eTpfsr8wdQVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=QDpmDOhavTUcvKewJ37ec1BifqEir1v9ZHn34unzJZ7z6B7xYUdjDknQsEQ6YCEv4+ yA2WGhIG7xrJLewwioRZohS9y2Eaej8coXOjjywqJPHje4z+VJeEGnTAhRSgKw7Qamll 0FZBV/golOKewkji3WHi62tWxOjvIR3yu6HugqOHyMFOl9nRTCpjlLnrolNf6c/n/6cf PcTJE4j1A0xEMsu++Onm26/I31q15dpndqF3cB/UMrs4pSF/sdAx9j9Mb+O93ZLRIkd+ xqUXU+JLLZx15tIYXCO7lJX3nSZEYCbkmMG/F1azFVVeTW53Nhxti9pT3Z5Mnx29sCK+ p50w== X-Gm-Message-State: AOAM532DqaNwQW8BZlaeU9NotSDgKYqRD0AGuuH5s381vo7isDje44oT M7BSx5hfz0ZFvs97/gRZl3odK5BqoCygGAT7cF9J3g== X-Google-Smtp-Source: ABdhPJy9346wJ7pgPh41de3TKx9jGsDYkXgGD+VTQowScqmus3DWBHWMTQtjBZGWKBfvb/2N8Rflzvh3mC8Utrm9SqA= X-Received: by 2002:a17:906:718b:: with SMTP id h11mr5091976ejk.418.1624537967775; Thu, 24 Jun 2021 05:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 24 Jun 2021 18:02:36 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_053249_690754_05F7FFF0 X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Laurent, On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > that driver instead of adding a new one for the same IP core ? > > > > > > Yes. there was an attempt from Michael in this direction: > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > Thanks for the reference, I will check it out and see I can send any > > updated versions wrt my i.MX8MM platform. > > Thanks. > > I had a brief look at the exynos driver, and I think it should be turned > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > Is there someone from Samsung who could assist, at least to test the > changes ? I have hardware to verify it on i.MX8MM but from exynos I don't have any contact from Samsung to suggest or test. Maybe I can add Tomasz Figa while sending the changes? I understand that there are 2 key implementations. 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM flow with LCDIF doesn't have component_ops (make sure it works with exynos platform first) 2. Sec DSIM Bridge driver common cross Exynos and i.MX8MM platform drivers or only one Sec DSIM bridge driver to handle both the platforms by differentiating compatible and driver data Any more suggestions would be appreciated? Jagan. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy