All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] sf: remove spi-flash chip names from SPL binary
Date: Wed, 31 Oct 2018 12:05:05 +0530	[thread overview]
Message-ID: <CAMty3ZAJC2e6rMdKOKC8Lxbw4jYmNLOLoEZU9i-HJYrjp8A6Vg@mail.gmail.com> (raw)
In-Reply-To: <20181007071601.12302-1-simon.k.r.goldschmidt@gmail.com>

On Sun, Oct 7, 2018 at 12:46 PM Simon Goldschmidt
<simon.k.r.goldschmidt@gmail.com> wrote:
>
> The table of spi flash chips 'spi_flash_ids' currently
> includes chip names. The only usage of these is to
> print the name when the chip is probed.
>
> Since this message is not shown in SPL, we can remove
> the names from the SPL binary.
>
> Removing the chip names saves ~890 Byte from the SPL
> binary in my configuration (socfpga_socrates_defconfig,
> MACRONIX, SPANSION and STMICRO enabled).

I'm not still quite happy with this change, other than reducing the
size which introduces many ifdef's what would you benefits with this
890bytes? do you have any room to add any key features in SPL?

  reply	other threads:[~2018-10-31  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-07  7:16 [U-Boot] [PATCH v2] sf: remove spi-flash chip names from SPL binary Simon Goldschmidt
2018-10-31  6:35 ` Jagan Teki [this message]
2018-10-31  7:00   ` Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMty3ZAJC2e6rMdKOKC8Lxbw4jYmNLOLoEZU9i-HJYrjp8A6Vg@mail.gmail.com \
    --to=jagan@amarulasolutions.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.