All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: U-Boot-Denx <u-boot@lists.denx.de>, Tom Rini <trini@konsulko.com>,
	 Priyanka Jain <priyanka.jain@nxp.com>,
	Simon Glass <sjg@chromium.org>, Heiko Schocher <hs@denx.de>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	Patrice CHOTARD <patrice.chotard@foss.st.com>,
	 Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH u-boot-dm + u-boot-spi v4 00/10] Support SPI NORs and OF partitions in `mtd list`
Date: Wed, 26 May 2021 22:28:34 +0530	[thread overview]
Message-ID: <CAMty3ZAewz1+1VtKZnBqzaSjMWwzRCr05rG3ThajFpBZh+2ZTA@mail.gmail.com> (raw)
In-Reply-To: <20210526120826.8045-1-marek.behun@nic.cz>

On Wed, May 26, 2021 at 5:39 PM Marek Behún <marek.behun@nic.cz> wrote:
>
> Hello,
>
> this is v4 of patchset that adds support for U-Boot to parse MTD
> partitions from device-tree, and also improves support for SPI NOR
> access via the `mtd` command.
>
> Small rebase was needed since last version.
>
> Finally passing CI since LTO is now merged and can optimize away the
> code increase. CI at https://github.com/u-boot/u-boot/pull/55
>
> Changes since v3:
> - rebased against current master (removed first patch, not needed
>   anymore)
> - check for CONFIG_OF_CONTROL in addition to CONFIG_DM, since we are
>   also using ofnode_* functions
> - match mtd's name in a separate function to make code more readable.
>   Also add non-DM version of this name matching function, since #if
>   macro must be used (otherwise CI will fail for configurations with
>   disabled DM)
> - addressed Simon's comments about using IS_ENABLED instead of #ifdefs
> - added Miquel's Reviewed-by and Patrice's Tested-by to the whole series
>
> Changes since v2:
> - addressed Pali's comments in patch that adds partition parsing (4/7 in
>   this version): no check for whether the `compatible` property is
>   present in a partition node and added comment explaining mask flags)
> - added 4 more patches:
>   1) adding ofnode_get_path() function
>   2) printing OF path in `mtd list`
>   3) in `mtd read <name> ...`, <name> can now also be DM's device name
>      or OF path
>   4) the fact from 3) is added to `mtd help`
>
> Changes since v1:
> - added tests of ofnode_get_addr_size_index() and
>   ofnode_get_addr_size_index_notrans() as requested by Simon
> - the last patch now probes SPI NORs in both versions of
>   mtd_probe_devices(), that is when MTDPARTS is enabled or disabled
>
> Marek
>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Priyanka Jain <priyanka.jain@nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice CHOTARD <patrice.chotard@foss.st.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Marek Behún (10):
>   dm: core: add non-translating version of ofnode_get_addr_size_index()
>   dm: core: add ofnode_get_path()
>   mtd: add support for parsing partitions defined in OF
>   mtd: spi-nor: allow registering multiple MTDs when DM is enabled
>   mtd: spi-nor: fill-in mtd->dev member
>   mtd: remove mtd_probe() function
>   mtd: probe SPI NOR devices in mtd_probe_devices()
>   cmd: mtd: print device OF path in listing
>   mtd: compare also with OF path and device name in get_mtd_device_nm()
>   cmd: mtd: expand <name> argument definition in command help
>
>  cmd/mtd.c                      |   9 ++-
>  drivers/core/ofnode.c          |  44 ++++++++++-
>  drivers/mtd/mtd-uclass.c       |  15 ----
>  drivers/mtd/mtd_uboot.c        | 129 ++++++++++++++++++++-------------
>  drivers/mtd/mtdcore.c          |  35 +++++++++
>  drivers/mtd/mtdpart.c          |  63 ++++++++++++++++
>  drivers/mtd/spi/sf_internal.h  |   4 +-
>  drivers/mtd/spi/sf_mtd.c       |  19 ++++-
>  drivers/mtd/spi/sf_probe.c     |   6 +-
>  drivers/mtd/spi/spi-nor-core.c |   1 +
>  drivers/mtd/spi/spi-nor-tiny.c |   1 +
>  include/dm/ofnode.h            |  27 +++++++
>  include/linux/mtd/mtd.h        |  10 +++
>  include/mtd.h                  |   1 -
>  test/dm/ofnode.c               |  26 +++++++
>  15 files changed, 315 insertions(+), 75 deletions(-)

This series have some conflicts wrt my series about MTD UCLASS
migration. Does this bypass that series?

Jagan.

  parent reply	other threads:[~2021-05-26 16:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 12:08 [PATCH u-boot-dm + u-boot-spi v4 00/10] Support SPI NORs and OF partitions in `mtd list` Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 01/10] dm: core: add non-translating version of ofnode_get_addr_size_index() Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 02/10] dm: core: add ofnode_get_path() Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 03/10] mtd: add support for parsing partitions defined in OF Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 04/10] mtd: spi-nor: allow registering multiple MTDs when DM is enabled Marek Behún
2021-07-07 23:54   ` Masami Hiramatsu
2021-07-08 14:15     ` Marek Behún
2021-07-08 14:56       ` Tom Rini
2021-07-09  0:19       ` Masami Hiramatsu
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 05/10] mtd: spi-nor: fill-in mtd->dev member Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 06/10] mtd: remove mtd_probe() function Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 07/10] mtd: probe SPI NOR devices in mtd_probe_devices() Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 08/10] cmd: mtd: print device OF path in listing Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 09/10] mtd: compare also with OF path and device name in get_mtd_device_nm() Marek Behún
2021-05-26 12:08 ` [PATCH u-boot-dm + u-boot-spi v4 10/10] cmd: mtd: expand <name> argument definition in command help Marek Behún
2021-05-26 16:58 ` Jagan Teki [this message]
2021-05-26 17:54   ` [PATCH u-boot-dm + u-boot-spi v4 00/10] Support SPI NORs and OF partitions in `mtd list` Marek Behún
2021-05-26 18:04     ` Jagan Teki
2021-06-02 14:03       ` Marek Behún
2021-06-24 11:36 ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMty3ZAewz1+1VtKZnBqzaSjMWwzRCr05rG3ThajFpBZh+2ZTA@mail.gmail.com \
    --to=jagan@amarulasolutions.com \
    --cc=hs@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=miquel.raynal@bootlin.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@st.com \
    --cc=priyanka.jain@nxp.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.