From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6A8C63793 for ; Thu, 22 Jul 2021 07:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EC6E61279 for ; Thu, 22 Jul 2021 07:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230399AbhGVHNb (ORCPT ); Thu, 22 Jul 2021 03:13:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbhGVHNa (ORCPT ); Thu, 22 Jul 2021 03:13:30 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3103BC061575 for ; Thu, 22 Jul 2021 00:54:06 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id l26so5635187eda.10 for ; Thu, 22 Jul 2021 00:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=heGQ4sEU/tcxYGYCH9nVmqIF3VXGFcDHuA5EFudXLOI=; b=buD/WBZbanBwdOA+/TO17KV/J3rYmYlKv1VLdOZDhuWbAuHHYJaHq/0xYZdYRCwvO6 t+CpHyfb+cKkK0Lxo8VWaUu4WOgt5ymWoVG8qFP0IMXa2ViCt9NE53JGQRyUsyEFwo5f 4rwshKRq2sOmOx9wAuOhfynJ33Tu0/Bm3MJ04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=heGQ4sEU/tcxYGYCH9nVmqIF3VXGFcDHuA5EFudXLOI=; b=R9KF4OrHX+O698dtwi70i2O57bLmHpTksNSpN2Jgky6v21dQb7OJYJS+YPIOIJG0zf E0e5W//VSTtKGAFeabcMAYz1bK+wc0I4qqVFMTksrTerTDMDXbr9QPYbfNRJficKJ29Z st36eFSdsNvgw1WkNDcqSYCx5/rnbdhW4iYn040V9i95bIdytqyh9vIncd8lm/5F+uxV 1rGMZ8FmQyXP+6QYUBXtXlpfM9tGanRcrn/c9qZYk03xwSk95H8lhSB6xzXgT41PbMaS O21nRWrOjvbs18E9Aiz2W5ebe1J9Q3CvMHaXwpRNdCyYZWeDjZot3wMEK+DvlCjtGHr5 y+sw== X-Gm-Message-State: AOAM532/rCf6Ueyo67I8i0FjbGddFwHnpTPkqwfyYUAalKKa8axEe/YC P4arWV4Z+OR9C4fMYOHRAux1GWD3yhIfeDa6EuLWMg== X-Google-Smtp-Source: ABdhPJywGnLozfLI+UYKok/2rOKWLwbeYIpdC4Lmv6hjc/+htpEJDm1YdNGlgyx/wnehdHFfXEzTifwl480+4uuSqTo= X-Received: by 2002:a05:6402:144f:: with SMTP id d15mr52935243edx.27.1626940444767; Thu, 22 Jul 2021 00:54:04 -0700 (PDT) MIME-Version: 1.0 References: <20210720134525.563936-1-maxime@cerno.tech> <20210720134525.563936-6-maxime@cerno.tech> In-Reply-To: <20210720134525.563936-6-maxime@cerno.tech> From: Jagan Teki Date: Thu, 22 Jul 2021 13:23:53 +0530 Message-ID: Subject: Re: [PATCH 05/10] drm/panel: Create attach and detach callbacks To: Maxime Ripard Cc: Robert Foss , Andrzej Hajda , Daniel Vetter , David Airlie , Sam Ravnborg , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Thierry Reding , Laurent Pinchart , linux-kernel , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > In order to make the probe order expectation more consistent between > bridges, let's create attach and detach hooks for the panels as well to > match what is there for bridges. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_panel.c | 20 ++++++++++++++++++++ > include/drm/drm_panel.h | 6 ++++++ > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index f634371c717a..23bca798a2f3 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -223,6 +223,26 @@ int drm_panel_get_modes(struct drm_panel *panel, > } > EXPORT_SYMBOL(drm_panel_get_modes); > > +int drm_panel_attach(struct drm_panel *panel) > +{ > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->attach) > + return panel->funcs->attach(panel); > + > + return -EOPNOTSUPP; Most of the panel drivers won't require panel attach/detach API's so we need to handle those cases as well if we didn't already. Thanks, Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B50C6377D for ; Thu, 22 Jul 2021 07:54:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8561961221 for ; Thu, 22 Jul 2021 07:54:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8561961221 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC2656E82C; Thu, 22 Jul 2021 07:54:07 +0000 (UTC) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by gabe.freedesktop.org (Postfix) with ESMTPS id 435646E82C for ; Thu, 22 Jul 2021 07:54:06 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id h2so5655779edt.3 for ; Thu, 22 Jul 2021 00:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=heGQ4sEU/tcxYGYCH9nVmqIF3VXGFcDHuA5EFudXLOI=; b=buD/WBZbanBwdOA+/TO17KV/J3rYmYlKv1VLdOZDhuWbAuHHYJaHq/0xYZdYRCwvO6 t+CpHyfb+cKkK0Lxo8VWaUu4WOgt5ymWoVG8qFP0IMXa2ViCt9NE53JGQRyUsyEFwo5f 4rwshKRq2sOmOx9wAuOhfynJ33Tu0/Bm3MJ04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=heGQ4sEU/tcxYGYCH9nVmqIF3VXGFcDHuA5EFudXLOI=; b=HwFdZXnQBZ6XqMbnrek5S6LLnW+APReamJYXpOknkyx6F5aNXTAsCZdQgrbMufaUhY rUVjZb4YuaxgSn75RPvlMZ0c6wpldWP0NSHyj/Lcx9W9wVZbDb+6uWyAE1CqnG4138EY 3IGBu0B3K5Gme/EYgOe17+kiyS5BtVon1FF6QviaCiShDZ0IJHQ55yCU/LyhC0Q+fSJa w3KkEQThAiOJjYop1q/Z1SamPXUawATyYIJw4QiRXtWMpyr9Y5YkAidK/edRdtMHxgIT MCQlXJi6ai75+Rxk+B5c8jxdoh6BLQ4+cNnSxCkrzaTN/ooEwlo/yzWoum9eUNu83Qu8 1Z+A== X-Gm-Message-State: AOAM531Vp/I5IFBEX9ivI2+tXAGvQ0MZ8l/wICtP8dIJocb6OeeizDI0 Ch5ZdFs+LuzL+aA33CFdlVRsCn9BUDdKPznOXk19eA== X-Google-Smtp-Source: ABdhPJywGnLozfLI+UYKok/2rOKWLwbeYIpdC4Lmv6hjc/+htpEJDm1YdNGlgyx/wnehdHFfXEzTifwl480+4uuSqTo= X-Received: by 2002:a05:6402:144f:: with SMTP id d15mr52935243edx.27.1626940444767; Thu, 22 Jul 2021 00:54:04 -0700 (PDT) MIME-Version: 1.0 References: <20210720134525.563936-1-maxime@cerno.tech> <20210720134525.563936-6-maxime@cerno.tech> In-Reply-To: <20210720134525.563936-6-maxime@cerno.tech> From: Jagan Teki Date: Thu, 22 Jul 2021 13:23:53 +0530 Message-ID: Subject: Re: [PATCH 05/10] drm/panel: Create attach and detach callbacks To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , dri-devel , Jonas Karlman , linux-kernel , Robert Foss , Andrzej Hajda , Thierry Reding , Jernej Skrabec , Thomas Zimmermann , Daniel Vetter , Sam Ravnborg , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > In order to make the probe order expectation more consistent between > bridges, let's create attach and detach hooks for the panels as well to > match what is there for bridges. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_panel.c | 20 ++++++++++++++++++++ > include/drm/drm_panel.h | 6 ++++++ > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index f634371c717a..23bca798a2f3 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -223,6 +223,26 @@ int drm_panel_get_modes(struct drm_panel *panel, > } > EXPORT_SYMBOL(drm_panel_get_modes); > > +int drm_panel_attach(struct drm_panel *panel) > +{ > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->attach) > + return panel->funcs->attach(panel); > + > + return -EOPNOTSUPP; Most of the panel drivers won't require panel attach/detach API's so we need to handle those cases as well if we didn't already. Thanks, Jagan.