From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH 00/92] ram: rk3399: Add LPDDR4 support Date: Wed, 12 Jun 2019 21:00:44 +0530 Message-ID: References: <20190611145135.21399-1-jagan@amarulasolutions.com> <349AB0AF-4DEE-4BC8-8FEF-B3DBD34564E4@theobroma-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Philipp Tomsich Cc: YouMin Chen , U-Boot-Denx , Akash Gajjar , "open list:ARM/Rockchip SoC..." , linux-amarula List-Id: linux-rockchip.vger.kernel.org T24gVHVlLCBKdW4gMTEsIDIwMTkgYXQgODozNiBQTSBQaGlsaXBwIFRvbXNpY2gKPHBoaWxpcHAu dG9tc2ljaEB0aGVvYnJvbWEtc3lzdGVtcy5jb20+IHdyb3RlOgo+Cj4KPgo+ID4gT24gMTEuMDYu MjAxOSwgYXQgMTc6MDMsIEphZ2FuIFRla2kgPGphZ2FuQGFtYXJ1bGFzb2x1dGlvbnMuY29tPiB3 cm90ZToKPiA+Cj4gPiBPbiBUdWUsIEp1biAxMSwgMjAxOSBhdCA4OjIzIFBNIFBoaWxpcHAgVG9t c2ljaAo+ID4gPHBoaWxpcHAudG9tc2ljaEB0aGVvYnJvbWEtc3lzdGVtcy5jb20+IHdyb3RlOgo+ ID4+Cj4gPj4KPiA+Pgo+ID4+PiBPbiAxMS4wNi4yMDE5LCBhdCAxNjo1MCwgSmFnYW4gVGVraSA8 amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+IHdyb3RlOgo+ID4+Pgo+ID4+PiBZZXMsIGl0IGNh biBiZSBwb3NzaWJsZSB0byBicmVhayB0aGlzIHNlcmllcyBpbnRvIG11bHRpcGxlIHN1YiBzZXJp ZXMKPiA+Pj4gYnV0IGlkZWEgaGVyZSBpcyB0byBtYXJrIGFsbCB0aGUgcmVxdWlyZWQgY2hhbmdl cyB0byBzdXBwb3J0IExQRERSNAo+ID4+PiBpbiByazMzOTkgaW4gb25lIHNldC4gaWYgcmVxdWly ZWQgd2UgY2FuIGJyZWFrIGl0IGZyb20gbmV4dCB2ZXJzaW9ucy4KPiA+Pj4KPiA+Pj4gVGhpcyBp cyB0aGUgaW5pdGlhbCBzZXQgZm9yIHN1cHBvcnRpbmcgTFBERFI0IHdpdGggYXNzb2NpYXRlZAo+ ID4+PiBmZWF0dXJlcy4KPiA+Pj4KPiA+Pj4gVGhhbmtzIHRvCj4gPj4+IC0gWW91TWluIENoZW4K PiA+Pj4gLSBBa2FzaCBHYWpqYXIKPiA+Pj4gLSBLZXZlciBZYW5nCj4gPj4+IGZvciBzdXBwb3J0 aW5nIGFsbCB0aGUgaGVscCBvbiB0aGlzIHdvcmsuCj4gPj4+Cj4gPj4+IE9uIHN1bW1hcnkgdGhp cyBzZXJpZXMgc3VwcG9ydAo+ID4+PiAtIENvZGUgd2FybmluZyBhbmQgZml4ZXMKPiA+Pj4gLSBy YW5rIGRldGVjdGlvbiwgdGhpcyB3b3VsZCByZXF1aXJlZCB0byBwcm9iZSBzaW5nbGUgY2hhbm5l bAo+ID4+PiBzZHJhbSBjb25maWd1cmVkIGluIE5hbm9QSS1ORU80Cj4gPj4+IC0gTFBERFI0IHN1 cHBvcnQsIHRlc3RlZCBpbiBSb2NrcHJvNjQgYW5kIFJvY2stUEktNAo+ID4+Pgo+ID4+PiBwYXRj aCAwMDAxIC0gMDAzMzogZml4IGNvZGUgd2FybmluZ3MsIHByaW50cywgbmV3IG1hY3Jvcwo+ID4+ Pgo+ID4+PiBwYXRjaCAwMDM0IC0gMDA1MTogcmFuayBkZXRlY3Rpb24sIHNkcmFtIGRlYnVnIGNv ZGUKPiA+Pj4KPiA+Pj4gcGF0Y2ggMDA1MjogVXNlIEREUjMtMTgwMCBvbiBOYW5vUEktTkVPNAo+ ID4+Pgo+ID4+PiBwYXRjaCAwMDUzIC0gMDA4OTogbHBkZHI0IHN1cHBvcnQKPiA+Pj4KPiA+Pj4g cGF0Y2ggMDA5MDogTFBERFI0LTEwMCB0aW1pbmdzCj4gPj4+Cj4gPj4+IHBhdGNoIDAwOTE6IFVz ZSBMUEREUjQtMTAwIG9uIFJvY2twcm82NAo+ID4+Pgo+ID4+PiBwYXRjaCAwMDkyOiBVc2UgTFBE RFI0LTEwMCBvbiBSb2NrLVBJIDQKPiA+Pj4KPiA+Pj4gTm90ZTogUHVtYSByazMzOTkgaGFzIFNQ TCBzaXplIG92ZXJmbG93LCBiZXR0ZXIgdG8gZW5hYmxlIFRQTAo+ID4+PiBmb3IgdGhpcyBib2Fy ZC4KPiA+Pgo+ID4+IFdlIG5lZWQgdG8ga2VlcCBQdW1hIG9uIGEgU1BMLW9ubHkgY29uZmlndXJh dGlvbiBmb3IgdGhlIHRpbWUgYmVpbmcuCj4gPj4gUGxlYXNlIG1ha2Ugc3VyZSB0aGF0IHRoZSBM UEREUjQgY29kZSBpcyBhbiBvcHRpb25hbCBmZWF0dXJlIHRoYXQgZG9lcyBub3QKPiA+PiBpbmNy ZWFzZSB0aGUgRFJBTS1kcml2ZXIgc2l6ZSBmb3IgYm9hcmRzIHRoYXQgZG9u4oCZdCBuZWVkL3dh bnQgaXQuCj4gPgo+ID4gV2UgaGF2ZSBmZXcgYm9hcmRzIGRvIGhhdmUgVFBMLXJ1bm5hYmxlLCB3 b3VsZCBiZSBhbnkgdGVjaG5pY2FsIGlzc3VlCj4gPiB0byBzd2l0Y2ggcHVtYSB0byBUUEw/IGJl Y2F1c2Ugd2UgaGF2ZSBscGRkcjQgY29kZSBwYXJ0IG9mIGV4aXN0aW5nCj4gPiBkcml2ZXIgaXRz ZWxmIGFuZCBpdCByZXF1aXJlIGV4dHJhIGlmZGVmIHRvIGNvbnNpZGVyIHdoaWNoIGluZGVlZCBs b29rCj4gPiBhd2Z1bCBmcm9tIGNvZGUgcG9pbnQtb2Ytdmlldy4KPgo+IE91ciBzZWN1cmUgYm9v dCBwcm9jZXNzIChpLmUuIHNpZ25pbmcgdG9vbHMpIGN1cnJlbnRseSBkZXBlbmRzIG9uIHRoaXMg YW5kCj4gdGhlIGNoYW5nZW92ZXIgd29u4oCZdCBiZSBxdWlja+KApgoKTm90IHNvIHF1aWNrLCB3 ZSBoYXZlIHRpbWUgdGlsbCBNVy4gaXNuJ3QgaXQgcG9zc2libGU/IGVuYWJsaW5nIHNlY3VyZQp0 b29scyBpbiBib3RoIFRQTCBhbmQgU1BMIG9yIFRQTC1hbG9uZSB3b3VsZCBiZSBtZWFuaW5nZnVs IHRyYWlsLiB3aGF0CmRvIHlvdSB0aGluaz8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KVS1Cb290IG1haWxpbmcgbGlzdApVLUJvb3RAbGlzdHMuZGVueC5k ZQpodHRwczovL2xpc3RzLmRlbnguZGUvbGlzdGluZm8vdS1ib290Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Wed, 12 Jun 2019 21:00:44 +0530 Subject: [U-Boot] [PATCH 00/92] ram: rk3399: Add LPDDR4 support In-Reply-To: References: <20190611145135.21399-1-jagan@amarulasolutions.com> <349AB0AF-4DEE-4BC8-8FEF-B3DBD34564E4@theobroma-systems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Tue, Jun 11, 2019 at 8:36 PM Philipp Tomsich wrote: > > > > > On 11.06.2019, at 17:03, Jagan Teki wrote: > > > > On Tue, Jun 11, 2019 at 8:23 PM Philipp Tomsich > > wrote: > >> > >> > >> > >>> On 11.06.2019, at 16:50, Jagan Teki wrote: > >>> > >>> Yes, it can be possible to break this series into multiple sub series > >>> but idea here is to mark all the required changes to support LPDDR4 > >>> in rk3399 in one set. if required we can break it from next versions. > >>> > >>> This is the initial set for supporting LPDDR4 with associated > >>> features. > >>> > >>> Thanks to > >>> - YouMin Chen > >>> - Akash Gajjar > >>> - Kever Yang > >>> for supporting all the help on this work. > >>> > >>> On summary this series support > >>> - Code warning and fixes > >>> - rank detection, this would required to probe single channel > >>> sdram configured in NanoPI-NEO4 > >>> - LPDDR4 support, tested in Rockpro64 and Rock-PI-4 > >>> > >>> patch 0001 - 0033: fix code warnings, prints, new macros > >>> > >>> patch 0034 - 0051: rank detection, sdram debug code > >>> > >>> patch 0052: Use DDR3-1800 on NanoPI-NEO4 > >>> > >>> patch 0053 - 0089: lpddr4 support > >>> > >>> patch 0090: LPDDR4-100 timings > >>> > >>> patch 0091: Use LPDDR4-100 on Rockpro64 > >>> > >>> patch 0092: Use LPDDR4-100 on Rock-PI 4 > >>> > >>> Note: Puma rk3399 has SPL size overflow, better to enable TPL > >>> for this board. > >> > >> We need to keep Puma on a SPL-only configuration for the time being. > >> Please make sure that the LPDDR4 code is an optional feature that does not > >> increase the DRAM-driver size for boards that don’t need/want it. > > > > We have few boards do have TPL-runnable, would be any technical issue > > to switch puma to TPL? because we have lpddr4 code part of existing > > driver itself and it require extra ifdef to consider which indeed look > > awful from code point-of-view. > > Our secure boot process (i.e. signing tools) currently depends on this and > the changeover won’t be quick… Not so quick, we have time till MW. isn't it possible? enabling secure tools in both TPL and SPL or TPL-alone would be meaningful trail. what do you think?