From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C65ECC43381 for ; Mon, 11 Mar 2019 14:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 872962173C for ; Mon, 11 Mar 2019 14:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="N9m7QtGa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbfCKOeF (ORCPT ); Mon, 11 Mar 2019 10:34:05 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:39876 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbfCKOeF (ORCPT ); Mon, 11 Mar 2019 10:34:05 -0400 Received: by mail-io1-f67.google.com with SMTP id x3so4193854ior.6 for ; Mon, 11 Mar 2019 07:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PuDy07zjfmgQGY7yoGUjNkjH8AXSJgbX0uTI8815zOk=; b=N9m7QtGa9YQUzI1PE++BJNRXtJeKszr88G0bbEXxKxaE0mYGrV2RUlmiQMdl/hjgj1 ZAvpnHWQq7F2Kaj62k9ka0ZMZpmaqZxK0G1ghWrrzCSBdxdCH7Sq8jh/ATCJdAsZMd29 F5QBNNHZUyyLX4N47B1w8mu+oe2e3BvtH+s5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PuDy07zjfmgQGY7yoGUjNkjH8AXSJgbX0uTI8815zOk=; b=MkdURuy81vguhX7gnbj64nJzykYzVjVY/HWW1zCT1N/SXawe9p2Y2wo+57wWtAlh1H ghaBqJp5Liy+8C3bBqzWoU1tah4rDZ/ibaq8/ZCx5tBcqhRPFNUDFigCzqGSspZg43OA rubrS5ENbYS7l7RxAuoVdKi379ZCrOI9unQBS1uq57M2f1BIIJ2fli8IWQh23kZ2wxAm farCwajiQ11ge8GrOL0AL9owbYlQzplcValwJGCkMA5wkbU09C1got1i1DT/MDtElSrG caGt95q+zQGVYTA4qKsSc7RsjnV1q3YkEko/uvsFEsWQYCs2oiZ3RlCiaa+RuNXectT6 BCWg== X-Gm-Message-State: APjAAAUlmdUkWXst4UyRQMByhOrwKISEiKUlP3mtiCbqFcgJ6fDgqwPU VyBiPTj0HA8l6PKTmcYmJ/rvfpYp8yh0Z042YNu7UQ== X-Google-Smtp-Source: APXvYqwiZ6qLyR3oO6lG0MJykLIi3NZKRzgjRPbDZDjbYeN/y0BlWuMFqtWeiyVtcQlqfqTtMENq8pMiuhrskac5YnQ= X-Received: by 2002:a6b:d80a:: with SMTP id y10mr9171899iob.114.1552314843606; Mon, 11 Mar 2019 07:34:03 -0700 (PDT) MIME-Version: 1.0 References: <20190303173527.31055-1-jagan@amarulasolutions.com> <20190303173527.31055-4-jagan@amarulasolutions.com> <20190304154911.s6rcx6bzal5slcjk@flea> <20190311140402.ie7abxda6pizrybj@flea> In-Reply-To: <20190311140402.ie7abxda6pizrybj@flea> From: Jagan Teki Date: Mon, 11 Mar 2019 20:03:52 +0530 Message-ID: Subject: Re: [PATCH v9 3/5] drm/sun4i: sun6i_mipi_dsi: Support vblk timing for 4-lane devices To: Maxime Ripard Cc: David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel , linux-arm-kernel , linux-kernel , linux-amarula@amarulasolutions.com, Michael Trimarchi , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 11, 2019 at 7:34 PM Maxime Ripard wrote: > > On Thu, Mar 07, 2019 at 09:33:38PM +0530, Jagan Teki wrote: > > On Mon, Mar 4, 2019 at 9:19 PM Maxime Ripard wrote: > > > > > > On Sun, Mar 03, 2019 at 11:05:25PM +0530, Jagan Teki wrote: > > > > Like other dsi setup timings, or hblk for that matter vblk would > > > > also require compute the timings based payload equation along with > > > > packet overhead. > > > > > > > > But, on the other hand vblk computation is also depends on device > > > > lane number. > > > > - for 4 lane devices, it is computed based on vtotal, packet overhead > > > > along with hblk value. > > > > - for others devices, it is simply 0 > > > > > > > > BSP code from BPI-M64-bsp is computing vblk as for 4-lane devices > > > > (from linux-sunxi > > > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > > > > > tmp = (ht*dsi_pixel_bits[format]/8)*vt-(4+dsi_hblk+2); > > > > dsi_vblk = (lane-tmp%lane); > > > > > > > > So, update the vblk timing calculation to support all type of > > > > devices. > > > > > > > > Tested on 2-lane, 4-lane MIPI-DSI LCD panels. > > > > > > You should be explaining which issue you faced, in which setup, what > > > were its symptoms and how that solution is fixing it. > > > > No, it is not a fix, didn't specify either. it is vblk timings support > > like others dsi timings. > > So it's not fixing anything, and this isn't a new feature > either. What's the point then? You can consider a feature, as comments says it's vblk support for 4-lane devices which doesn't be 0. don't know why you are asking like a first time patch since it's commented before[1] [1] https://patchwork.kernel.org/patch/10657543/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B7EAC43381 for ; Mon, 11 Mar 2019 14:34:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3782520449 for ; Mon, 11 Mar 2019 14:34:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i/BdqkCe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="N9m7QtGa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3782520449 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kW0oQ93JRyhAqjKUTgL8TwmCyFyNUW4y9OG4SZinBYs=; b=i/BdqkCeJru8mt UN94v1gRi07YA3rqcjrMXjfqKX3JJgMxPjYqzFPjgrEx+M63x8+CeAGxi0g4G8v+Xgs6yBiWqYoRX Q9WkIRwsCof0LgI1dFsrNY4x+AGzLL7G4fS9LH6vG9hkddaw3unGfWFh+kFipkKDe66I3JnkODCfW DabYmM+K+1aamO0b0SBZvZDP+HEETsOc06CJ0crvL+SYV2QM07dDjC6GMVJ0JxaGFOl4/aDRvhPb/ dBhoEr/e2v4uW6KA4AQ2F/jpWWzH7lFiF7QefFZiatmfDBfM2Rx2brk0FHAUmSV/3XFixPEfc2r1c toZI8PZGkJ+F6I47jxGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3M0G-0005LG-3Q; Mon, 11 Mar 2019 14:34:08 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3M0C-0005Kn-SR for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 14:34:06 +0000 Received: by mail-io1-xd43.google.com with SMTP id n11so3129621ioh.1 for ; Mon, 11 Mar 2019 07:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PuDy07zjfmgQGY7yoGUjNkjH8AXSJgbX0uTI8815zOk=; b=N9m7QtGa9YQUzI1PE++BJNRXtJeKszr88G0bbEXxKxaE0mYGrV2RUlmiQMdl/hjgj1 ZAvpnHWQq7F2Kaj62k9ka0ZMZpmaqZxK0G1ghWrrzCSBdxdCH7Sq8jh/ATCJdAsZMd29 F5QBNNHZUyyLX4N47B1w8mu+oe2e3BvtH+s5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PuDy07zjfmgQGY7yoGUjNkjH8AXSJgbX0uTI8815zOk=; b=QWaAKz8G27XOtYG4KwX5ZpCMcosseafLbuQXO8I/4jkR731vvH1X3LF4UNts5FuvAs hdh1lC3DFSe0LuT+mbPYCYaiziFNyVRaTbZ1PR0UtQDHE2QRebyMucJVIhAlnlKKEfKh h4p8QNZJ6Am2ConRbOXljgsyeeOq0UN9cy6gP8h6owwRINrznuS33UZk3Q6AB+/8P9C5 3DbzxX0HEorxj2Muk7I0FevCLea4XvHC8xrYWzGNkLR6GDFa4/TSofD7cPXQMXqcXoqO Z8ymqpQkcL5bRkbQxTLxNN3SaeSuNCOsp/o4Okg3Uf/STwUnUexIZk8Ucnr+iY8OhFB9 R+tA== X-Gm-Message-State: APjAAAVYXvA1TTaIriVjlM+ohzBv/0bi4Z2IzUU3yJLcsqjcgomLGe1C qsxeDVIbhOArU08bKv9rGxF6ZxYaRJSD1g/jcA2HcA== X-Google-Smtp-Source: APXvYqwiZ6qLyR3oO6lG0MJykLIi3NZKRzgjRPbDZDjbYeN/y0BlWuMFqtWeiyVtcQlqfqTtMENq8pMiuhrskac5YnQ= X-Received: by 2002:a6b:d80a:: with SMTP id y10mr9171899iob.114.1552314843606; Mon, 11 Mar 2019 07:34:03 -0700 (PDT) MIME-Version: 1.0 References: <20190303173527.31055-1-jagan@amarulasolutions.com> <20190303173527.31055-4-jagan@amarulasolutions.com> <20190304154911.s6rcx6bzal5slcjk@flea> <20190311140402.ie7abxda6pizrybj@flea> In-Reply-To: <20190311140402.ie7abxda6pizrybj@flea> From: Jagan Teki Date: Mon, 11 Mar 2019 20:03:52 +0530 Message-ID: Subject: Re: [PATCH v9 3/5] drm/sun4i: sun6i_mipi_dsi: Support vblk timing for 4-lane devices To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_073404_915035_E578028A X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-sunxi , linux-kernel , dri-devel , Chen-Yu Tsai , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 11, 2019 at 7:34 PM Maxime Ripard wrote: > > On Thu, Mar 07, 2019 at 09:33:38PM +0530, Jagan Teki wrote: > > On Mon, Mar 4, 2019 at 9:19 PM Maxime Ripard wrote: > > > > > > On Sun, Mar 03, 2019 at 11:05:25PM +0530, Jagan Teki wrote: > > > > Like other dsi setup timings, or hblk for that matter vblk would > > > > also require compute the timings based payload equation along with > > > > packet overhead. > > > > > > > > But, on the other hand vblk computation is also depends on device > > > > lane number. > > > > - for 4 lane devices, it is computed based on vtotal, packet overhead > > > > along with hblk value. > > > > - for others devices, it is simply 0 > > > > > > > > BSP code from BPI-M64-bsp is computing vblk as for 4-lane devices > > > > (from linux-sunxi > > > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > > > > > tmp = (ht*dsi_pixel_bits[format]/8)*vt-(4+dsi_hblk+2); > > > > dsi_vblk = (lane-tmp%lane); > > > > > > > > So, update the vblk timing calculation to support all type of > > > > devices. > > > > > > > > Tested on 2-lane, 4-lane MIPI-DSI LCD panels. > > > > > > You should be explaining which issue you faced, in which setup, what > > > were its symptoms and how that solution is fixing it. > > > > No, it is not a fix, didn't specify either. it is vblk timings support > > like others dsi timings. > > So it's not fixing anything, and this isn't a new feature > either. What's the point then? You can consider a feature, as comments says it's vblk support for 4-lane devices which doesn't be 0. don't know why you are asking like a first time patch since it's commented before[1] [1] https://patchwork.kernel.org/patch/10657543/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel