From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A185C433EF for ; Mon, 18 Jun 2018 12:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E13B2086A for ; Mon, 18 Jun 2018 12:58:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="mHIaJqzl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E13B2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933409AbeFRM6H (ORCPT ); Mon, 18 Jun 2018 08:58:07 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:53338 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932630AbeFRM6D (ORCPT ); Mon, 18 Jun 2018 08:58:03 -0400 Received: by mail-it0-f67.google.com with SMTP id a195-v6so11800198itd.3 for ; Mon, 18 Jun 2018 05:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TbcmZmziNvCb9QImDOzzwoJQmShc67koz9MwMnZVnf8=; b=mHIaJqzlK9JdQ4rLxnpNaJyIrl4267MooqmrOlSxNsmtiWeQ7nU8Bch3ZTZQTobKmc b6DUXM2gnmGpnWzpdXg/oRsfKErMMBUze9lVInCjtjTzxervqw1TwlRrLfZNeZpXVRQ8 HuUvK2IHULzfZ+VVUIWrYVB1rpl9jN73HlES4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TbcmZmziNvCb9QImDOzzwoJQmShc67koz9MwMnZVnf8=; b=FwHQ1cA+ztJYjWzkZ8c6+kt4mcdpcLwFbistDQq1Nc/XFRjh49qQVYAcRLjIInDZYT UHVxTl1DHnibpBnuetuMiTrluju1zK85aZu7IoHwNFd2S6WNFQFshpPfYLrgKZbFxwRp Lhe96EdnjjjEWE+XeY6MCGO4kZvTRCRx5N+IBLRQzHVGu85z4ma2MuhNhKW9k7onFiHL SEE6Knu1dzuZAAHXbziRAV9JxaMeqEnWrzxUYeYM0BO8rdNJMxdRTz9czpNU1eNh2/4L kG7ik9BZjAgdYZWRzOUgjvFuzS7cRl5E4Lsmt7Yj95bxGJRR0MLYab8G7O323NQlSMxG Mr8A== X-Gm-Message-State: APt69E1DXxWgUmC25OAEZteEHD0b6UiuCpx4KOzi05Zg21kyB2PvhUtX N5HU4eTLhxCELupHnR7rxOQKlTfqDXoJqb2VrCfilQ== X-Google-Smtp-Source: ADUXVKJ4FSrM4LAdh0OLCmQ6mYRHmI4qwbxjzOBIzC9cxi5wpfcItZynaT1N7bquugGbXFqkIAvTrcGjSi58yxWLIi8= X-Received: by 2002:a24:690f:: with SMTP id e15-v6mr9362046itc.70.1529326682870; Mon, 18 Jun 2018 05:58:02 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:89ca:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 05:58:02 -0700 (PDT) In-Reply-To: <5084905.C41JrL457O@jernej-laptop> References: <20180612200036.21483-1-jernej.skrabec@siol.net> <2742773.k39D243pH3@jernej-laptop> <5084905.C41JrL457O@jernej-laptop> From: Jagan Teki Date: Mon, 18 Jun 2018 18:28:02 +0530 Message-ID: Subject: Re: [linux-sunxi] [PATCH v2 00/27] Add support for R40 HDMI pipeline To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , David Airlie , gustavo@padovan.org, maarten.lankhorst@linux.intel.com, Sean Paul , Mark Rutland , dri-devel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 14, 2018 at 10:59 PM, Jernej =C5=A0krabec wrote: > Dne =C4=8Detrtek, 14. junij 2018 ob 19:16:46 CEST je Jagan Teki napisal(a= ): >> On Thu, Jun 14, 2018 at 8:04 PM, Jernej =C5=A0krabec > wrote: >> > Dne =C4=8Detrtek, 14. junij 2018 ob 09:12:41 CEST je Jagan Teki napisa= l(a): >> >> On Wed, Jun 13, 2018 at 1:30 AM, Jernej Skrabec >> > >> > wrote: >> >> > This series adds support for R40 HDMI pipeline. It is a bit special >> >> > than other already supported pipelines because it has additional un= it >> >> > called TCON TOP responsible for relationship configuration between >> >> > mixers, TCONs and HDMI. Additionally, it has additional gates for D= SI >> >> > and TV TCONs, TV encoder clock settings and pin muxing between LCD >> >> > and TV encoders. >> >> > >> >> > However, it seems that TCON TOP will become a norm, since newer >> >> > Allwinner SoCs like H6 also have this unit. >> >> > >> >> > I tested different possible configurations: >> >> > - mixer0 <> TCON-TV0 <> HDMI >> >> > - mixer0 <> TCON-TV1 <> HDMI >> >> > - mixer1 <> TCON-TV0 <> HDMI >> >> > - mixer1 <> TCON-TV1 <> HDMI >> >> > >> >> > Please review. >> >> > >> >> > Best regards, >> >> > Jernej >> >> > >> >> > Changes from v1: >> >> > - Split DT bindings patch and updated description >> >> > - Split HDMI PHY patch >> >> > - Move header file from TCON TOP patch to dt bindings patch >> >> > - Added Rob reviewed-by tag >> >> > - Used clk_hw_register_gate() instead of custom gate registration c= ode >> >> > - Reworked TCON TOP to be part of of-graph. Because of that, a lot = of >> >> > >> >> > new patches were added. >> >> > >> >> > - Droped mixer index quirk patch >> >> > - Reworked TCON support for TCON TOP >> >> > - Updated commit messages >> >> > >> >> > Jernej Skrabec (27): >> >> > clk: sunxi-ng: r40: Add minimal rate for video PLLs >> >> > clk: sunxi-ng: r40: Allow setting parent rate to display related >> >> > >> >> > clocks >> >> > >> >> > clk: sunxi-ng: r40: Export video PLLs >> >> > dt-bindings: display: sunxi-drm: Add TCON TOP description >> >> > drm/sun4i: Add TCON TOP driver >> >> > drm/sun4i: Fix releasing node when enumerating enpoints >> >> > drm/sun4i: Split out code for enumerating endpoints in output por= t >> >> > drm/sun4i: Add support for traversing graph with TCON TOP >> >> > drm/sun4i: Don't skip TCONs if they don't have channel 0 >> >> > dt-bindings: display: sun4i-drm: Add R40 TV TCON description >> >> > drm/sun4i: tcon: Add support for tcon-top gate >> >> > drm/sun4i: tcon: Generalize engine search algorithm >> >> > drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1 >> >> > drm/sun4i: Don't check for panel or bridge on TV TCONs >> >> > drm/sun4i: Add support for R40 TV TCON >> >> > dt-bindings: display: sun4i-drm: Add R40 mixer compatibles >> >> > drm/sun4i: Add support for R40 mixers >> >> > dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY >> >> > drm/sun4i: Enable DW HDMI PHY clock >> >> > drm/sun4i: Don't change clock bits in DW HDMI PHY driver >> >> > drm/sun4i: DW HDMI PHY: Add support for second PLL >> >> > drm/sun4i: Add support for second clock parent to DW HDMI PHY clk >> >> > >> >> > driver >> >> > >> >> > drm/sun4i: Add support for A64 HDMI PHY >> >> > drm: of: Export drm_crtc_port_mask() >> >> > drm/sun4i: DW HDMI: Expand algorithm for possible crtcs >> >> > ARM: dts: sun8i: r40: Add HDMI pipeline >> >> > ARM: dts: sun8i: r40: Enable HDMI output on BananaPi M2 Ultra >> >> >> >> Tested whole series on top of linux-next. >> >> >> >> Tested-by: Jagan Teki >> > >> > Thanks! >> >> I've V40 board, which is same as R40. I'm able to detect the HDMI but >> seems edid not detecting properly. >> >> [ 0.983007] sun4i-drm display-engine: bound 1100000.mixer (ops >> 0xc074a80c) [ 0.999043] sun4i-drm display-engine: bound 1200000.mixer >> (ops 0xc074a80c) [ 1.006229] sun4i-drm display-engine: bound >> 1c70000.tcon-top (ops 0xc074e2ac) [ 1.013609] sun4i-drm display-engin= e: >> bound 1c73000.lcd-controller (ops 0xc0747a28) >> [ 1.053988] sun8i-dw-hdmi 1ee0000.hdmi: Detected HDMI TX controller >> v1.32a with HDCP (sun8i_dw_hdmi_phy) >> [ 1.063913] sun8i-dw-hdmi 1ee0000.hdmi: registered DesignWare HDMI >> I2C bus driver >> [ 1.071683] sun4i-drm display-engine: bound 1ee0000.hdmi (ops 0xc074a= 298) >> [ 1.078484] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013= ). >> [ 1.085098] [drm] No driver support for vblank timestamp query. [ >> 1.091055] [drm] Cannot find any crtc or sizes >> [ 1.095995] [drm] Initialized sun4i-drm 1.0.0 20150629 for >> display-engine on minor 0 > > This seems like DT issue. Can you post somewhere your V40 DTSI (if it is > different to R40) and board DTS? same dtsi shared between r40 and v40, here is board dts support for HDMI[1] [1] https://paste.ubuntu.com/p/wqVz38BHrM/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH v2 00/27] Add support for R40 HDMI pipeline Date: Mon, 18 Jun 2018 18:28:02 +0530 Message-ID: References: <20180612200036.21483-1-jernej.skrabec@siol.net> <2742773.k39D243pH3@jernej-laptop> <5084905.C41JrL457O@jernej-laptop> Reply-To: jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <5084905.C41JrL457O@jernej-laptop> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , David Airlie , gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org, maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Sean Paul , Mark Rutland , dri-devel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi List-Id: devicetree@vger.kernel.org On Thu, Jun 14, 2018 at 10:59 PM, Jernej =C5=A0krabec wrote: > Dne =C4=8Detrtek, 14. junij 2018 ob 19:16:46 CEST je Jagan Teki napisal(a= ): >> On Thu, Jun 14, 2018 at 8:04 PM, Jernej =C5=A0krabec > wrote: >> > Dne =C4=8Detrtek, 14. junij 2018 ob 09:12:41 CEST je Jagan Teki napisa= l(a): >> >> On Wed, Jun 13, 2018 at 1:30 AM, Jernej Skrabec >> > >> > wrote: >> >> > This series adds support for R40 HDMI pipeline. It is a bit special >> >> > than other already supported pipelines because it has additional un= it >> >> > called TCON TOP responsible for relationship configuration between >> >> > mixers, TCONs and HDMI. Additionally, it has additional gates for D= SI >> >> > and TV TCONs, TV encoder clock settings and pin muxing between LCD >> >> > and TV encoders. >> >> > >> >> > However, it seems that TCON TOP will become a norm, since newer >> >> > Allwinner SoCs like H6 also have this unit. >> >> > >> >> > I tested different possible configurations: >> >> > - mixer0 <> TCON-TV0 <> HDMI >> >> > - mixer0 <> TCON-TV1 <> HDMI >> >> > - mixer1 <> TCON-TV0 <> HDMI >> >> > - mixer1 <> TCON-TV1 <> HDMI >> >> > >> >> > Please review. >> >> > >> >> > Best regards, >> >> > Jernej >> >> > >> >> > Changes from v1: >> >> > - Split DT bindings patch and updated description >> >> > - Split HDMI PHY patch >> >> > - Move header file from TCON TOP patch to dt bindings patch >> >> > - Added Rob reviewed-by tag >> >> > - Used clk_hw_register_gate() instead of custom gate registration c= ode >> >> > - Reworked TCON TOP to be part of of-graph. Because of that, a lot = of >> >> > >> >> > new patches were added. >> >> > >> >> > - Droped mixer index quirk patch >> >> > - Reworked TCON support for TCON TOP >> >> > - Updated commit messages >> >> > >> >> > Jernej Skrabec (27): >> >> > clk: sunxi-ng: r40: Add minimal rate for video PLLs >> >> > clk: sunxi-ng: r40: Allow setting parent rate to display related >> >> > >> >> > clocks >> >> > >> >> > clk: sunxi-ng: r40: Export video PLLs >> >> > dt-bindings: display: sunxi-drm: Add TCON TOP description >> >> > drm/sun4i: Add TCON TOP driver >> >> > drm/sun4i: Fix releasing node when enumerating enpoints >> >> > drm/sun4i: Split out code for enumerating endpoints in output por= t >> >> > drm/sun4i: Add support for traversing graph with TCON TOP >> >> > drm/sun4i: Don't skip TCONs if they don't have channel 0 >> >> > dt-bindings: display: sun4i-drm: Add R40 TV TCON description >> >> > drm/sun4i: tcon: Add support for tcon-top gate >> >> > drm/sun4i: tcon: Generalize engine search algorithm >> >> > drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1 >> >> > drm/sun4i: Don't check for panel or bridge on TV TCONs >> >> > drm/sun4i: Add support for R40 TV TCON >> >> > dt-bindings: display: sun4i-drm: Add R40 mixer compatibles >> >> > drm/sun4i: Add support for R40 mixers >> >> > dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY >> >> > drm/sun4i: Enable DW HDMI PHY clock >> >> > drm/sun4i: Don't change clock bits in DW HDMI PHY driver >> >> > drm/sun4i: DW HDMI PHY: Add support for second PLL >> >> > drm/sun4i: Add support for second clock parent to DW HDMI PHY clk >> >> > >> >> > driver >> >> > >> >> > drm/sun4i: Add support for A64 HDMI PHY >> >> > drm: of: Export drm_crtc_port_mask() >> >> > drm/sun4i: DW HDMI: Expand algorithm for possible crtcs >> >> > ARM: dts: sun8i: r40: Add HDMI pipeline >> >> > ARM: dts: sun8i: r40: Enable HDMI output on BananaPi M2 Ultra >> >> >> >> Tested whole series on top of linux-next. >> >> >> >> Tested-by: Jagan Teki >> > >> > Thanks! >> >> I've V40 board, which is same as R40. I'm able to detect the HDMI but >> seems edid not detecting properly. >> >> [ 0.983007] sun4i-drm display-engine: bound 1100000.mixer (ops >> 0xc074a80c) [ 0.999043] sun4i-drm display-engine: bound 1200000.mixer >> (ops 0xc074a80c) [ 1.006229] sun4i-drm display-engine: bound >> 1c70000.tcon-top (ops 0xc074e2ac) [ 1.013609] sun4i-drm display-engin= e: >> bound 1c73000.lcd-controller (ops 0xc0747a28) >> [ 1.053988] sun8i-dw-hdmi 1ee0000.hdmi: Detected HDMI TX controller >> v1.32a with HDCP (sun8i_dw_hdmi_phy) >> [ 1.063913] sun8i-dw-hdmi 1ee0000.hdmi: registered DesignWare HDMI >> I2C bus driver >> [ 1.071683] sun4i-drm display-engine: bound 1ee0000.hdmi (ops 0xc074a= 298) >> [ 1.078484] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013= ). >> [ 1.085098] [drm] No driver support for vblank timestamp query. [ >> 1.091055] [drm] Cannot find any crtc or sizes >> [ 1.095995] [drm] Initialized sun4i-drm 1.0.0 20150629 for >> display-engine on minor 0 > > This seems like DT issue. Can you post somewhere your V40 DTSI (if it is > different to R40) and board DTS? same dtsi shared between r40 and v40, here is board dts support for HDMI[1] [1] https://paste.ubuntu.com/p/wqVz38BHrM/ --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f66.google.com ([209.85.214.66]:55703 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932609AbeFRM6D (ORCPT ); Mon, 18 Jun 2018 08:58:03 -0400 Received: by mail-it0-f66.google.com with SMTP id 16-v6so11786611itl.5 for ; Mon, 18 Jun 2018 05:58:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5084905.C41JrL457O@jernej-laptop> References: <20180612200036.21483-1-jernej.skrabec@siol.net> <2742773.k39D243pH3@jernej-laptop> <5084905.C41JrL457O@jernej-laptop> From: Jagan Teki Date: Mon, 18 Jun 2018 18:28:02 +0530 Message-ID: Subject: Re: [linux-sunxi] [PATCH v2 00/27] Add support for R40 HDMI pipeline To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , David Airlie , gustavo@padovan.org, maarten.lankhorst@linux.intel.com, Sean Paul , Mark Rutland , dri-devel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org List-ID: On Thu, Jun 14, 2018 at 10:59 PM, Jernej =C5=A0krabec wrote: > Dne =C4=8Detrtek, 14. junij 2018 ob 19:16:46 CEST je Jagan Teki napisal(a= ): >> On Thu, Jun 14, 2018 at 8:04 PM, Jernej =C5=A0krabec > wrote: >> > Dne =C4=8Detrtek, 14. junij 2018 ob 09:12:41 CEST je Jagan Teki napisa= l(a): >> >> On Wed, Jun 13, 2018 at 1:30 AM, Jernej Skrabec >> > >> > wrote: >> >> > This series adds support for R40 HDMI pipeline. It is a bit special >> >> > than other already supported pipelines because it has additional un= it >> >> > called TCON TOP responsible for relationship configuration between >> >> > mixers, TCONs and HDMI. Additionally, it has additional gates for D= SI >> >> > and TV TCONs, TV encoder clock settings and pin muxing between LCD >> >> > and TV encoders. >> >> > >> >> > However, it seems that TCON TOP will become a norm, since newer >> >> > Allwinner SoCs like H6 also have this unit. >> >> > >> >> > I tested different possible configurations: >> >> > - mixer0 <> TCON-TV0 <> HDMI >> >> > - mixer0 <> TCON-TV1 <> HDMI >> >> > - mixer1 <> TCON-TV0 <> HDMI >> >> > - mixer1 <> TCON-TV1 <> HDMI >> >> > >> >> > Please review. >> >> > >> >> > Best regards, >> >> > Jernej >> >> > >> >> > Changes from v1: >> >> > - Split DT bindings patch and updated description >> >> > - Split HDMI PHY patch >> >> > - Move header file from TCON TOP patch to dt bindings patch >> >> > - Added Rob reviewed-by tag >> >> > - Used clk_hw_register_gate() instead of custom gate registration c= ode >> >> > - Reworked TCON TOP to be part of of-graph. Because of that, a lot = of >> >> > >> >> > new patches were added. >> >> > >> >> > - Droped mixer index quirk patch >> >> > - Reworked TCON support for TCON TOP >> >> > - Updated commit messages >> >> > >> >> > Jernej Skrabec (27): >> >> > clk: sunxi-ng: r40: Add minimal rate for video PLLs >> >> > clk: sunxi-ng: r40: Allow setting parent rate to display related >> >> > >> >> > clocks >> >> > >> >> > clk: sunxi-ng: r40: Export video PLLs >> >> > dt-bindings: display: sunxi-drm: Add TCON TOP description >> >> > drm/sun4i: Add TCON TOP driver >> >> > drm/sun4i: Fix releasing node when enumerating enpoints >> >> > drm/sun4i: Split out code for enumerating endpoints in output por= t >> >> > drm/sun4i: Add support for traversing graph with TCON TOP >> >> > drm/sun4i: Don't skip TCONs if they don't have channel 0 >> >> > dt-bindings: display: sun4i-drm: Add R40 TV TCON description >> >> > drm/sun4i: tcon: Add support for tcon-top gate >> >> > drm/sun4i: tcon: Generalize engine search algorithm >> >> > drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1 >> >> > drm/sun4i: Don't check for panel or bridge on TV TCONs >> >> > drm/sun4i: Add support for R40 TV TCON >> >> > dt-bindings: display: sun4i-drm: Add R40 mixer compatibles >> >> > drm/sun4i: Add support for R40 mixers >> >> > dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY >> >> > drm/sun4i: Enable DW HDMI PHY clock >> >> > drm/sun4i: Don't change clock bits in DW HDMI PHY driver >> >> > drm/sun4i: DW HDMI PHY: Add support for second PLL >> >> > drm/sun4i: Add support for second clock parent to DW HDMI PHY clk >> >> > >> >> > driver >> >> > >> >> > drm/sun4i: Add support for A64 HDMI PHY >> >> > drm: of: Export drm_crtc_port_mask() >> >> > drm/sun4i: DW HDMI: Expand algorithm for possible crtcs >> >> > ARM: dts: sun8i: r40: Add HDMI pipeline >> >> > ARM: dts: sun8i: r40: Enable HDMI output on BananaPi M2 Ultra >> >> >> >> Tested whole series on top of linux-next. >> >> >> >> Tested-by: Jagan Teki >> > >> > Thanks! >> >> I've V40 board, which is same as R40. I'm able to detect the HDMI but >> seems edid not detecting properly. >> >> [ 0.983007] sun4i-drm display-engine: bound 1100000.mixer (ops >> 0xc074a80c) [ 0.999043] sun4i-drm display-engine: bound 1200000.mixer >> (ops 0xc074a80c) [ 1.006229] sun4i-drm display-engine: bound >> 1c70000.tcon-top (ops 0xc074e2ac) [ 1.013609] sun4i-drm display-engin= e: >> bound 1c73000.lcd-controller (ops 0xc0747a28) >> [ 1.053988] sun8i-dw-hdmi 1ee0000.hdmi: Detected HDMI TX controller >> v1.32a with HDCP (sun8i_dw_hdmi_phy) >> [ 1.063913] sun8i-dw-hdmi 1ee0000.hdmi: registered DesignWare HDMI >> I2C bus driver >> [ 1.071683] sun4i-drm display-engine: bound 1ee0000.hdmi (ops 0xc074a= 298) >> [ 1.078484] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013= ). >> [ 1.085098] [drm] No driver support for vblank timestamp query. [ >> 1.091055] [drm] Cannot find any crtc or sizes >> [ 1.095995] [drm] Initialized sun4i-drm 1.0.0 20150629 for >> display-engine on minor 0 > > This seems like DT issue. Can you post somewhere your V40 DTSI (if it is > different to R40) and board DTS? same dtsi shared between r40 and v40, here is board dts support for HDMI[1] [1] https://paste.ubuntu.com/p/wqVz38BHrM/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: jagan@amarulasolutions.com (Jagan Teki) Date: Mon, 18 Jun 2018 18:28:02 +0530 Subject: [linux-sunxi] [PATCH v2 00/27] Add support for R40 HDMI pipeline In-Reply-To: <5084905.C41JrL457O@jernej-laptop> References: <20180612200036.21483-1-jernej.skrabec@siol.net> <2742773.k39D243pH3@jernej-laptop> <5084905.C41JrL457O@jernej-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 14, 2018 at 10:59 PM, Jernej ?krabec wrote: > Dne ?etrtek, 14. junij 2018 ob 19:16:46 CEST je Jagan Teki napisal(a): >> On Thu, Jun 14, 2018 at 8:04 PM, Jernej ?krabec > wrote: >> > Dne ?etrtek, 14. junij 2018 ob 09:12:41 CEST je Jagan Teki napisal(a): >> >> On Wed, Jun 13, 2018 at 1:30 AM, Jernej Skrabec >> > >> > wrote: >> >> > This series adds support for R40 HDMI pipeline. It is a bit special >> >> > than other already supported pipelines because it has additional unit >> >> > called TCON TOP responsible for relationship configuration between >> >> > mixers, TCONs and HDMI. Additionally, it has additional gates for DSI >> >> > and TV TCONs, TV encoder clock settings and pin muxing between LCD >> >> > and TV encoders. >> >> > >> >> > However, it seems that TCON TOP will become a norm, since newer >> >> > Allwinner SoCs like H6 also have this unit. >> >> > >> >> > I tested different possible configurations: >> >> > - mixer0 <> TCON-TV0 <> HDMI >> >> > - mixer0 <> TCON-TV1 <> HDMI >> >> > - mixer1 <> TCON-TV0 <> HDMI >> >> > - mixer1 <> TCON-TV1 <> HDMI >> >> > >> >> > Please review. >> >> > >> >> > Best regards, >> >> > Jernej >> >> > >> >> > Changes from v1: >> >> > - Split DT bindings patch and updated description >> >> > - Split HDMI PHY patch >> >> > - Move header file from TCON TOP patch to dt bindings patch >> >> > - Added Rob reviewed-by tag >> >> > - Used clk_hw_register_gate() instead of custom gate registration code >> >> > - Reworked TCON TOP to be part of of-graph. Because of that, a lot of >> >> > >> >> > new patches were added. >> >> > >> >> > - Droped mixer index quirk patch >> >> > - Reworked TCON support for TCON TOP >> >> > - Updated commit messages >> >> > >> >> > Jernej Skrabec (27): >> >> > clk: sunxi-ng: r40: Add minimal rate for video PLLs >> >> > clk: sunxi-ng: r40: Allow setting parent rate to display related >> >> > >> >> > clocks >> >> > >> >> > clk: sunxi-ng: r40: Export video PLLs >> >> > dt-bindings: display: sunxi-drm: Add TCON TOP description >> >> > drm/sun4i: Add TCON TOP driver >> >> > drm/sun4i: Fix releasing node when enumerating enpoints >> >> > drm/sun4i: Split out code for enumerating endpoints in output port >> >> > drm/sun4i: Add support for traversing graph with TCON TOP >> >> > drm/sun4i: Don't skip TCONs if they don't have channel 0 >> >> > dt-bindings: display: sun4i-drm: Add R40 TV TCON description >> >> > drm/sun4i: tcon: Add support for tcon-top gate >> >> > drm/sun4i: tcon: Generalize engine search algorithm >> >> > drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1 >> >> > drm/sun4i: Don't check for panel or bridge on TV TCONs >> >> > drm/sun4i: Add support for R40 TV TCON >> >> > dt-bindings: display: sun4i-drm: Add R40 mixer compatibles >> >> > drm/sun4i: Add support for R40 mixers >> >> > dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY >> >> > drm/sun4i: Enable DW HDMI PHY clock >> >> > drm/sun4i: Don't change clock bits in DW HDMI PHY driver >> >> > drm/sun4i: DW HDMI PHY: Add support for second PLL >> >> > drm/sun4i: Add support for second clock parent to DW HDMI PHY clk >> >> > >> >> > driver >> >> > >> >> > drm/sun4i: Add support for A64 HDMI PHY >> >> > drm: of: Export drm_crtc_port_mask() >> >> > drm/sun4i: DW HDMI: Expand algorithm for possible crtcs >> >> > ARM: dts: sun8i: r40: Add HDMI pipeline >> >> > ARM: dts: sun8i: r40: Enable HDMI output on BananaPi M2 Ultra >> >> >> >> Tested whole series on top of linux-next. >> >> >> >> Tested-by: Jagan Teki >> > >> > Thanks! >> >> I've V40 board, which is same as R40. I'm able to detect the HDMI but >> seems edid not detecting properly. >> >> [ 0.983007] sun4i-drm display-engine: bound 1100000.mixer (ops >> 0xc074a80c) [ 0.999043] sun4i-drm display-engine: bound 1200000.mixer >> (ops 0xc074a80c) [ 1.006229] sun4i-drm display-engine: bound >> 1c70000.tcon-top (ops 0xc074e2ac) [ 1.013609] sun4i-drm display-engine: >> bound 1c73000.lcd-controller (ops 0xc0747a28) >> [ 1.053988] sun8i-dw-hdmi 1ee0000.hdmi: Detected HDMI TX controller >> v1.32a with HDCP (sun8i_dw_hdmi_phy) >> [ 1.063913] sun8i-dw-hdmi 1ee0000.hdmi: registered DesignWare HDMI >> I2C bus driver >> [ 1.071683] sun4i-drm display-engine: bound 1ee0000.hdmi (ops 0xc074a298) >> [ 1.078484] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). >> [ 1.085098] [drm] No driver support for vblank timestamp query. [ >> 1.091055] [drm] Cannot find any crtc or sizes >> [ 1.095995] [drm] Initialized sun4i-drm 1.0.0 20150629 for >> display-engine on minor 0 > > This seems like DT issue. Can you post somewhere your V40 DTSI (if it is > different to R40) and board DTS? same dtsi shared between r40 and v40, here is board dts support for HDMI[1] [1] https://paste.ubuntu.com/p/wqVz38BHrM/