From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Fri, 14 Dec 2018 19:29:40 +0530 Subject: [U-Boot] [PATCH 03/16] spi: Add non DM version of SPI_MEM In-Reply-To: <94eca227-9ddd-b58e-ac95-dbe148970bb2@ti.com> References: <20181212173228.12281-1-vigneshr@ti.com> <20181212173228.12281-4-vigneshr@ti.com> <1112df41-8212-8f3e-741c-b11ee4a155d8@ti.com> <94eca227-9ddd-b58e-ac95-dbe148970bb2@ti.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Dec 14, 2018 at 4:26 PM Vignesh R wrote: > > Hi, > > On 14/12/18 3:32 PM, Jagan Teki wrote: > > On Thu, Dec 13, 2018 at 2:19 PM Vignesh R wrote: > >> > >> > >> > >> On 13/12/18 1:55 AM, Jagan Teki wrote: > >>> On Wed, Dec 12, 2018 at 11:08 PM Vignesh R wrote: > >>>> > >>>> Add non DM version of SPI_MEM to support easy migration to new SPI NOR > >>>> framework. This can be removed once DM_SPI conversion is complete. > >>> > >>> Our intention to use new driver to follow dm, why we need to support > >>> non-dm? any usecases? > >>> > >> > >> As said by others, AFAICS, DM_SPI migration is not going to be complete > >> anytime soon. There are many boards and configs that don't enable > >> DM_SPI. I propose you add a patch to print _warning during build_ for > >> boards that don't have DM_SPI enabled (like DM_MMC and DM_USB) targeting > >> v2019.07 or v2019.04 as deadline for removal. At the deadline you can > >> remove spi-mem-nodm.c along with all other non DM code in SPI core. > > > > I don't understand why DM_SPI migration came to this topic? It's a > > separate thread/issue. > > > > > I respectfully disagree. If DM_SPI migration was complete then SPI_MEM > would be available for use by all subsystem. This patch wouldn't have > been needed. I have given my comment if spi-mem handle only DM. Okay, lets move your approach of having spi-mem-nondm.c