From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756394AbdCXIdR (ORCPT ); Fri, 24 Mar 2017 04:33:17 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:34950 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755089AbdCXIck (ORCPT ); Fri, 24 Mar 2017 04:32:40 -0400 MIME-Version: 1.0 In-Reply-To: <20170324052324.GF30608@dragon> References: <1490204897-14525-1-git-send-email-jagan@openedev.com> <1490204897-14525-8-git-send-email-jagan@openedev.com> <20170324052324.GF30608@dragon> From: Jagan Teki Date: Fri, 24 Mar 2017 14:02:38 +0530 Message-ID: Subject: Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node To: Shawn Guo Cc: Jagan Teki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel , Matteo Lisi , Michael Trimarchi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2017 at 10:53 AM, Shawn Guo wrote: > On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote: >> From: Jagan Teki >> >> Add support for Sound card and related codec(via i2c1) nodes >> on Engicam Is.IoT MX6UL variant module boards. >> >> Cc: Shawn Guo >> Cc: Matteo Lisi >> Cc: Michael Trimarchi >> Signed-off-by: Jagan Teki >> --- >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++ >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 30 ++++++++++++++++++++++++++++++ >> 2 files changed, 41 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> index b149b5e..c79fa42 100644 >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> @@ -41,6 +41,17 @@ >> */ >> >> &i2c1 { >> + codec: sgtl5000@0a { > > sgtl5000: codec@a { Just to understand, why codec: sgtl5000@0a not a suitable notation? couldn't see any Documentation. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node Date: Fri, 24 Mar 2017 14:02:38 +0530 Message-ID: References: <1490204897-14525-1-git-send-email-jagan@openedev.com> <1490204897-14525-8-git-send-email-jagan@openedev.com> <20170324052324.GF30608@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170324052324.GF30608@dragon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: Jagan Teki , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel , Matteo Lisi , Michael Trimarchi List-Id: devicetree@vger.kernel.org On Fri, Mar 24, 2017 at 10:53 AM, Shawn Guo wrote: > On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote: >> From: Jagan Teki >> >> Add support for Sound card and related codec(via i2c1) nodes >> on Engicam Is.IoT MX6UL variant module boards. >> >> Cc: Shawn Guo >> Cc: Matteo Lisi >> Cc: Michael Trimarchi >> Signed-off-by: Jagan Teki >> --- >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++ >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 30 ++++++++++++++++++++++++++++++ >> 2 files changed, 41 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> index b149b5e..c79fa42 100644 >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> @@ -41,6 +41,17 @@ >> */ >> >> &i2c1 { >> + codec: sgtl5000@0a { > > sgtl5000: codec@a { Just to understand, why codec: sgtl5000@0a not a suitable notation? couldn't see any Documentation. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jagan@amarulasolutions.com (Jagan Teki) Date: Fri, 24 Mar 2017 14:02:38 +0530 Subject: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node In-Reply-To: <20170324052324.GF30608@dragon> References: <1490204897-14525-1-git-send-email-jagan@openedev.com> <1490204897-14525-8-git-send-email-jagan@openedev.com> <20170324052324.GF30608@dragon> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 24, 2017 at 10:53 AM, Shawn Guo wrote: > On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote: >> From: Jagan Teki >> >> Add support for Sound card and related codec(via i2c1) nodes >> on Engicam Is.IoT MX6UL variant module boards. >> >> Cc: Shawn Guo >> Cc: Matteo Lisi >> Cc: Michael Trimarchi >> Signed-off-by: Jagan Teki >> --- >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++ >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 30 ++++++++++++++++++++++++++++++ >> 2 files changed, 41 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> index b149b5e..c79fa42 100644 >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> @@ -41,6 +41,17 @@ >> */ >> >> &i2c1 { >> + codec: sgtl5000 at 0a { > > sgtl5000: codec at a { Just to understand, why codec: sgtl5000 at 0a not a suitable notation? couldn't see any Documentation. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India.