From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jagan Teki <jagan@amarulasolutions.com>
Date: Mon, 1 Oct 2018 17:08:30 +0530
Subject: [U-Boot] [PATCH v12 1/8] dm: drop unused helper in MTD header
In-Reply-To: <20181001120230.5937a631@xps13>
References: <20180929105830.13530-1-miquel.raynal@bootlin.com>
 <20180929105830.13530-2-miquel.raynal@bootlin.com>
 <CAMty3ZA6LAMj57hNTiu2Ds3n6m0SmgvU1a3aLPmxv1drH5dwMw@mail.gmail.com>
 <20181001120230.5937a631@xps13>
Message-ID: <CAMty3ZBYSgCUxd_SVCtqe3fzJxoi8nxCwKAqPjqRkazn3a1xmg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Oct 1, 2018 at 3:32 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Jagan,
>
> Jagan Teki <jagan@amarulasolutions.com> wrote on Mon, 1 Oct 2018
> 15:23:46 +0530:
>
> > On Sat, Sep 29, 2018 at 4:29 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > include/mtd.h might be included by files even if CONFIG_DM is not
> > > enabled. In this case, the call to dev_get_uclass_priv() would trigger
> > > a build error. Because this helper has no user, let's drop it off.
> >
> > Why would they use DM include file w/o using it? we need to fix in those places.
>
> There was no user of include/mtd.h not using CONFIG_DM.
>
> But now I am creating cmd/mtd.c which should work with both CONFIG_DM
> and no CONFIG_DM support. So include/mtd.h has reasons to be included.

Then use ifdef CONFIG_MTD on the same file so it can arrange dm and
non-dm include at one place.