From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] rk3288: broken boot
Date: Tue, 13 Feb 2018 16:16:30 +0530 [thread overview]
Message-ID: <CAMty3ZBicqPYzedGxBhQFvqiEJQR6YJtgtZYeS9VAoJuxQcSHA@mail.gmail.com> (raw)
In-Reply-To: <e76a4dca-fe39-ce06-dc6d-477f50e8a795@rock-chips.com>
On Fri, Dec 15, 2017 at 2:45 PM, Kever Yang <kever.yang@rock-chips.com> wrote:
> Hi Jagan,
>
> Could you enable global DEBUG and share the log?
>
> Thanks,
>
> - Kever
>
>
> On 12/15/2017 03:08 PM, Jagan Teki wrote:
>>
>> Hi Philipp/Kever,
>>
>> Issue observed on rk3288 TPL supported board (vyasa), worked on
>> previous release v2017.11.
>>
>> Tried to bisect but i couldn't do it because of changes in many files any
>> help?
I don't understand how rk3288 boards were working since from 2
releases, I've bisect this and found the bad
d962e5dadc2cbc21bffd375f29665e5042879e66 is the first bad commit
commit d962e5dadc2cbc21bffd375f29665e5042879e66
Author: Kever Yang <kever.yang@rock-chips.com>
Date: Tue Oct 10 16:21:04 2017 +0200
rockchip: mkimage: use spl_boot0 for all Rockchip SoCs
Enable the spl_boot0 in SPL and use the pre-padding TAG memory,
the mkimage do not need to pad it but only need to replace the value
with correct TAG value.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
[Updated:]
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Look like the boot magic can't find it in 0x800 and it can't overwrite
4 bytes, so we need to explicitly specify 0x804 as header size
--- a/tools/rkcommon.c
+++ b/tools/rkcommon.c
@@ -357,7 +357,7 @@ int rkcommon_vrec_header(struct image_tool_params *params,
* 4 bytes of these images can safely be overwritten using the
* boot magic.
*/
- tparams->header_size = RK_SPL_HDR_START;
+ tparams->header_size = RK_SPL_HDR_START + 4;
/* Allocate, clear and install the header */
tparams->hdr = malloc(tparams->header_size);
Please let me know for comments.
Jagan.
next prev parent reply other threads:[~2018-02-13 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 7:08 [U-Boot] rk3288: broken boot Jagan Teki
2017-12-15 9:00 ` Dr. Philipp Tomsich
2017-12-15 9:15 ` Kever Yang
2018-02-13 10:46 ` Jagan Teki [this message]
2018-02-13 11:15 ` Dr. Philipp Tomsich
2018-02-13 11:59 ` Dr. Philipp Tomsich
2018-02-13 12:20 ` Jagan Teki
2018-02-14 0:08 ` Dr. Philipp Tomsich
2018-02-14 10:47 ` Jagan Teki
2018-02-14 11:02 ` Dr. Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZBicqPYzedGxBhQFvqiEJQR6YJtgtZYeS9VAoJuxQcSHA@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.