From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A398C49EAB for ; Fri, 25 Jun 2021 08:20:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F03846142D for ; Fri, 25 Jun 2021 08:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbhFYIWY (ORCPT ); Fri, 25 Jun 2021 04:22:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbhFYIWX (ORCPT ); Fri, 25 Jun 2021 04:22:23 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B9B3C06175F for ; Fri, 25 Jun 2021 01:20:02 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id nb6so13793951ejc.10 for ; Fri, 25 Jun 2021 01:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=fUPOg7qJFU4+Ky55nonbhHO3m4gsmtHJ5JR19iPaBEvYjk3/idyXrnOzPF0RETsFki aon0d55/n0DgoLxhyqvpHSMAzPTz5otjiNSZ/KZCVwhjW1FHTLiHnWh/CM8AwwZZpldx Kdh+7y5JjZRwPrcv7S0CsQpczGiUAYa472kT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=VPLtNYkViPALh5oJxYzbrWpySiDCJe6XO5m83iMyHNo3EtsU9CBTuPzd1UxXfjpgPd S/XE6spFnNPjvkL5EjP24lwvQtv7O9aWMrnsWAW9T9l6ZrGJw/Kc9G+DUz8+Pmi0N1Of nL8gd+HuM4BrxxrXcgHA6bSzDhbDQD5aALyoBqKWjjq6ewuxs0gKYqHbQ/Fug+YE/B/l BPll+S0cSxKmo8ssMmBeIw0KqZFSLtEWxwIJ8rBP4AoHaaxEoN4GAbVjI7nHfJwmyWLw mJOMgR9Xnp2R/UK20bkKAdcg06XUjp9f4rdp4/PVZo2GVehxLEmdhy4gDGQTasOwjph9 oZOg== X-Gm-Message-State: AOAM531hWwu3/cy65RAov2jHweE8mxKnPpU6Xjn/c3DAn54/6QwUiLpX rXaFQTPZLyaP1US33EwFN7pubz/2Zxph//kcYQM5DA== X-Google-Smtp-Source: ABdhPJxPYVWDTuNQnGVZcTr/J+zl2QMfQDE1LFW7NWpHcZf0GBIjnlowThGs9yNuKiJWJssteOsB7NCRRWQI1Rw+mOk= X-Received: by 2002:a17:906:bb10:: with SMTP id jz16mr5890056ejb.252.1624609200411; Fri, 25 Jun 2021 01:20:00 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 25 Jun 2021 13:49:49 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 6:17 PM Laurent Pinchart wrote: > > On Thu, Jun 24, 2021 at 06:02:36PM +0530, Jagan Teki wrote: > > Hi Laurent, > > > > On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart > > wrote: > > > > > > Hi Jagan, > > > > > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > > > that driver instead of adding a new one for the same IP core ? > > > > > > > > > > Yes. there was an attempt from Michael in this direction: > > > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > > > > > Thanks for the reference, I will check it out and see I can send any > > > > updated versions wrt my i.MX8MM platform. > > > > > > Thanks. > > > > > > I had a brief look at the exynos driver, and I think it should be turned > > > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > > > > > Is there someone from Samsung who could assist, at least to test the > > > changes ? > > > > I have hardware to verify it on i.MX8MM but from exynos I don't have > > any contact from Samsung to suggest or test. Maybe I can add Tomasz > > Figa while sending the changes? > > Tomasz hasn't been working for Samsung for a loooong time (I've dropped > his Samsung address from the CC list for this reason). Okay. I think exynos drm maintainers might help out here, but not sure of it. > > > I understand that there are 2 key implementations. > > > > 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM > > flow with LCDIF doesn't have component_ops (make sure it works with > > exynos platform first) > > I think it should be turned into a real drm_bridge, it's currently > implemented based on drm_encoder. Yes, ie what I'm trying for. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC93EC48BC2 for ; Fri, 25 Jun 2021 08:30:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A35F96044F for ; Fri, 25 Jun 2021 08:30:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A35F96044F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l2IQsQ8JR8xjGEw8FiV/LcwaXqWbHdT7qCNyWwYxJtw=; b=N/kC0hVV8HsGDW alP29FnWP3pV9KecdOtJn63/yy+C7f/MJQMmlh0huP193W3XBV2cYkfO6cr8j1W1f9DqbcTI/2bMF ENBZTLlfW327bHULUe9PDbVsGAeDr20EpTFaXu/wMtpLtV6shmDFyfQHiMIqgriGP42SVZBbILPwz g7ZvSSR3QFVgoypzZx83E4pDDp+EUSyLzyVBWqgsetT98fqpmWx/bpjjaXri/SBKpt5dk2NJXa5x9 zSskaXGf2pRmxN327AwCfK0/G51tAaVNppUjakvaInbzG8zwqetWv33EU/8wr8tWWzS7m6HSJvtGE +E1uIHJycGMeRul4DKIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwhC8-000KH1-I8; Fri, 25 Jun 2021 08:28:13 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwh4E-000H6O-Vu for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 08:20:04 +0000 Received: by mail-ej1-x633.google.com with SMTP id hc16so13671504ejc.12 for ; Fri, 25 Jun 2021 01:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=fUPOg7qJFU4+Ky55nonbhHO3m4gsmtHJ5JR19iPaBEvYjk3/idyXrnOzPF0RETsFki aon0d55/n0DgoLxhyqvpHSMAzPTz5otjiNSZ/KZCVwhjW1FHTLiHnWh/CM8AwwZZpldx Kdh+7y5JjZRwPrcv7S0CsQpczGiUAYa472kT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=fhNMltucXZGtCySpvIFH3JmvC4xfcrqxYvZmIMWiN3lvf3CoXMB3ZCObIwtwNQUc7C 6qVNr0u8uLkqikmuTU4m054gI6414LkVw6epDjSgpX9bq6Bb3UE1LbYzXK01oUFaLLWi calhNypdiP4mPMI9YJKdqjNnz/WM/88C19tNliydBhQ7g8R3/3wq3N1cQO/4YJZCzBNI B5HYlASZ2a9NhfMjuRQ7hYtJ09YUuIrtR9ho3w2KICpMQjrB/u/G6BxeRPdQ8X9quCxE w2fSXCcoVBzciDqV2Vz06Stv3oRvbHFzcMAWUqwUkXGcUKxkpv6YYHKK2yOew1Mj7MUI Jerw== X-Gm-Message-State: AOAM530EeI0fi4FIZ7tajeQ0KvSXCW+Fg3tuo+47PqFUNaJrywjoOKBk btdSenG9s0USJ3sUDQSiyByy0VltvVT9dpsTY6tpvw== X-Google-Smtp-Source: ABdhPJxPYVWDTuNQnGVZcTr/J+zl2QMfQDE1LFW7NWpHcZf0GBIjnlowThGs9yNuKiJWJssteOsB7NCRRWQI1Rw+mOk= X-Received: by 2002:a17:906:bb10:: with SMTP id jz16mr5890056ejb.252.1624609200411; Fri, 25 Jun 2021 01:20:00 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 25 Jun 2021 13:49:49 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_012003_243664_4B2792E9 X-CRM114-Status: GOOD ( 30.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 24, 2021 at 6:17 PM Laurent Pinchart wrote: > > On Thu, Jun 24, 2021 at 06:02:36PM +0530, Jagan Teki wrote: > > Hi Laurent, > > > > On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart > > wrote: > > > > > > Hi Jagan, > > > > > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > > > that driver instead of adding a new one for the same IP core ? > > > > > > > > > > Yes. there was an attempt from Michael in this direction: > > > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > > > > > Thanks for the reference, I will check it out and see I can send any > > > > updated versions wrt my i.MX8MM platform. > > > > > > Thanks. > > > > > > I had a brief look at the exynos driver, and I think it should be turned > > > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > > > > > Is there someone from Samsung who could assist, at least to test the > > > changes ? > > > > I have hardware to verify it on i.MX8MM but from exynos I don't have > > any contact from Samsung to suggest or test. Maybe I can add Tomasz > > Figa while sending the changes? > > Tomasz hasn't been working for Samsung for a loooong time (I've dropped > his Samsung address from the CC list for this reason). Okay. I think exynos drm maintainers might help out here, but not sure of it. > > > I understand that there are 2 key implementations. > > > > 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM > > flow with LCDIF doesn't have component_ops (make sure it works with > > exynos platform first) > > I think it should be turned into a real drm_bridge, it's currently > implemented based on drm_encoder. Yes, ie what I'm trying for. Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30947C2B9F4 for ; Fri, 25 Jun 2021 08:20:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 670CE61426 for ; Fri, 25 Jun 2021 08:20:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 670CE61426 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C29F96E09F; Fri, 25 Jun 2021 08:20:02 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id E51396E09F for ; Fri, 25 Jun 2021 08:20:01 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id nd37so13853803ejc.3 for ; Fri, 25 Jun 2021 01:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=fUPOg7qJFU4+Ky55nonbhHO3m4gsmtHJ5JR19iPaBEvYjk3/idyXrnOzPF0RETsFki aon0d55/n0DgoLxhyqvpHSMAzPTz5otjiNSZ/KZCVwhjW1FHTLiHnWh/CM8AwwZZpldx Kdh+7y5JjZRwPrcv7S0CsQpczGiUAYa472kT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=eycLa6mNU/0U0rEYhyaJPKMNSjmkgXzN7VUKNZBcKFdYLLDmLEkVIV7xF+KkMOqll0 cOCB6YcGUgMh5QztLGRMGnGBlNjv/ihmg/K2xh+UADu+7X1oXCANntty/C64dyWHX0u3 gx2EGk5OnsiNmMks59R1VgkfGXQXDhfdZH1Fctq9OmGVZCgLqYjaBGY02ya4bqCflxZI Ae2nwxwQcou/Xmzg54ZvCjr1vnsDwgX5rct9u8lrSjPLkhJh3oPJcyVXRI48meZ0Skzj N1cJFzaSGtgqGzQiDCLQ8hfPLCH4kcy7x0Bx8qpLIr9W9qlvMRV3huS+uR4mLT1hry5A 2Nzw== X-Gm-Message-State: AOAM53237aUCcwNwLJQRhibq4HE7AXP6l/c4Jm4UOxT3LTeOWtASNltU O35mpPUhO4CPWCtHreO/VC0wQZQQ2AZBHb4f9hbncg== X-Google-Smtp-Source: ABdhPJxPYVWDTuNQnGVZcTr/J+zl2QMfQDE1LFW7NWpHcZf0GBIjnlowThGs9yNuKiJWJssteOsB7NCRRWQI1Rw+mOk= X-Received: by 2002:a17:906:bb10:: with SMTP id jz16mr5890056ejb.252.1624609200411; Fri, 25 Jun 2021 01:20:00 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 25 Jun 2021 13:49:49 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , Sascha Hauer , Michael Tretter , Robert Foss , linux-kernel , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Shawn Guo , Fancy Fang , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 24, 2021 at 6:17 PM Laurent Pinchart wrote: > > On Thu, Jun 24, 2021 at 06:02:36PM +0530, Jagan Teki wrote: > > Hi Laurent, > > > > On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart > > wrote: > > > > > > Hi Jagan, > > > > > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > > > that driver instead of adding a new one for the same IP core ? > > > > > > > > > > Yes. there was an attempt from Michael in this direction: > > > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > > > > > Thanks for the reference, I will check it out and see I can send any > > > > updated versions wrt my i.MX8MM platform. > > > > > > Thanks. > > > > > > I had a brief look at the exynos driver, and I think it should be turned > > > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > > > > > Is there someone from Samsung who could assist, at least to test the > > > changes ? > > > > I have hardware to verify it on i.MX8MM but from exynos I don't have > > any contact from Samsung to suggest or test. Maybe I can add Tomasz > > Figa while sending the changes? > > Tomasz hasn't been working for Samsung for a loooong time (I've dropped > his Samsung address from the CC list for this reason). Okay. I think exynos drm maintainers might help out here, but not sure of it. > > > I understand that there are 2 key implementations. > > > > 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM > > flow with LCDIF doesn't have component_ops (make sure it works with > > exynos platform first) > > I think it should be turned into a real drm_bridge, it's currently > implemented based on drm_encoder. Yes, ie what I'm trying for. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C4AC2B9F4 for ; Fri, 25 Jun 2021 08:28:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59D1861427 for ; Fri, 25 Jun 2021 08:28:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59D1861427 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wIfMcujK1+GqHFGLP+L/2/3Ag0OnHIFuz9f+z8Vyipw=; b=ekDK3JL7xNhuo2 2o531M/EFAYeKjq9BR0f1TAQPnFoql1pmtfwGMWE05fr7Avy1K2nMStarrTmKg0iq0KHj1zo0igcb FZ9/SaxkaHrzlEPSS2MXb7bwT1DozVnJ7ISqcRrO7ZOb6kIQiyHcF8qBDpOopYVtxOHLxZew171I6 fR9DiiSqVq3zftxz38yrY7kFm/J+bfATrZeGmayBmJop07MYCd9ejUMcmIn4o6Aq1jx0ikZADYDf1 kKnTMG0hDxjCa/KGnqW4B7I0tK9XCQO6VZbrY0n/Y/7bdeksIRLkd8XxqyZrGOsVf+0MGbTvp3BqL CRUVZGQVwCi/lffR/lCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwhC3-000KGU-9R; Fri, 25 Jun 2021 08:28:07 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwh4E-000H6N-V7 for linux-phy@lists.infradead.org; Fri, 25 Jun 2021 08:20:05 +0000 Received: by mail-ej1-x62e.google.com with SMTP id gn32so13859600ejc.2 for ; Fri, 25 Jun 2021 01:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=fUPOg7qJFU4+Ky55nonbhHO3m4gsmtHJ5JR19iPaBEvYjk3/idyXrnOzPF0RETsFki aon0d55/n0DgoLxhyqvpHSMAzPTz5otjiNSZ/KZCVwhjW1FHTLiHnWh/CM8AwwZZpldx Kdh+7y5JjZRwPrcv7S0CsQpczGiUAYa472kT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ij57ec/kT6vqdj3SkA9+UxDinMRytbLturPpNw8vjWU=; b=D+vCXDVXpgP/+GtfhxEViqkD/fIx29it+Rs+LYfhxE9Tljj7BREDMOWy4sevkYk63Y GPpa/AkIPSqc3wLfweB+fY95UD30k2KP9vrcBweUcnWypWwMMXDnJ/5rqUE8NG38jWgy +R4fok/iHqeQ7X4LIQ3H9mq3IaS8YRD0ZiQaB4g406ShldSbp9+Glv2OmzVeanqv5zDP YlVLSUndfUV8NxMKkaL5ND7DwP5qhoY8Rx4i3et+s9cn8R+vp98bhmwpTDPp1wIG1fDw NIdR0buxxq1J/gyQ+pjd3E2fdQErgjOmi8idyoRUkMh7/AAF0rdRk+rrVUNdxmxvuw8y vyKA== X-Gm-Message-State: AOAM531h1F7oRvnKfeum81Rk8plPBUScxPFeifWjR+yVYp6H9Rj4mk2Z tiQRn8vwhO2X9t4tHHxPTLhl0lfvY0XqEeb4ZjgC7w== X-Google-Smtp-Source: ABdhPJxPYVWDTuNQnGVZcTr/J+zl2QMfQDE1LFW7NWpHcZf0GBIjnlowThGs9yNuKiJWJssteOsB7NCRRWQI1Rw+mOk= X-Received: by 2002:a17:906:bb10:: with SMTP id jz16mr5890056ejb.252.1624609200411; Fri, 25 Jun 2021 01:20:00 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 25 Jun 2021 13:49:49 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_012003_241473_783E0439 X-CRM114-Status: GOOD ( 28.72 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Jun 24, 2021 at 6:17 PM Laurent Pinchart wrote: > > On Thu, Jun 24, 2021 at 06:02:36PM +0530, Jagan Teki wrote: > > Hi Laurent, > > > > On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart > > wrote: > > > > > > Hi Jagan, > > > > > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > > > that driver instead of adding a new one for the same IP core ? > > > > > > > > > > Yes. there was an attempt from Michael in this direction: > > > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > > > > > Thanks for the reference, I will check it out and see I can send any > > > > updated versions wrt my i.MX8MM platform. > > > > > > Thanks. > > > > > > I had a brief look at the exynos driver, and I think it should be turned > > > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > > > > > Is there someone from Samsung who could assist, at least to test the > > > changes ? > > > > I have hardware to verify it on i.MX8MM but from exynos I don't have > > any contact from Samsung to suggest or test. Maybe I can add Tomasz > > Figa while sending the changes? > > Tomasz hasn't been working for Samsung for a loooong time (I've dropped > his Samsung address from the CC list for this reason). Okay. I think exynos drm maintainers might help out here, but not sure of it. > > > I understand that there are 2 key implementations. > > > > 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM > > flow with LCDIF doesn't have component_ops (make sure it works with > > exynos platform first) > > I think it should be turned into a real drm_bridge, it's currently > implemented based on drm_encoder. Yes, ie what I'm trying for. Jagan. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy