From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CFF8C433FE for ; Fri, 11 Nov 2022 12:46:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 784BB10E12D; Fri, 11 Nov 2022 12:46:00 +0000 (UTC) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C57D10E12D for ; Fri, 11 Nov 2022 12:45:57 +0000 (UTC) Received: by mail-io1-xd33.google.com with SMTP id p141so3467073iod.6 for ; Fri, 11 Nov 2022 04:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1xS4s0avgD255rcYtA4Gae74h0+wxtz39GOAv7A9upU=; b=ObGg9stT9HoCf/3hi1Z8le25KXMunJrziAtRLVbUrZC4OS5ZtiDcTMHcaGRON8E8GL f70DgnO7ZlPPXUeY1riLAsY4ZhsJ37ghiVyGrL3GrcSv6n+V+1vU8ZIskBXu6uGBlifV uuHw2MHM12kOhnHVUcPa9b4kVnHlJ3/egwDuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1xS4s0avgD255rcYtA4Gae74h0+wxtz39GOAv7A9upU=; b=C+cNGpvVPBKZ6DVnTuJjAqONRG0ZYJr5rfWiK6cvgMJym2nrJ4Wx7O2usK14QuOQSk NDxRlmYkogSmmXDTyybPDWZDAFZ4+B7Y52SoxTsIrKz15G+8smSqyEMcBTRUtb2rCcB1 5u+lmLyvoKCAruV0EbEdaMUE3bemYrEt3zdz5WEhpBkBaEpHU6Jj6mPYHHEIR4EhpOxr JpDOV8v9qzbuqCb60OMOY6Wsw2o5T0ckM5D4WBk8QhbHgOJoC7UmVe/r/OZGRdNvG+Dd IrKN79NOv3dGFsdZgQWhd005bjUmYb3BYs5Tl9TIeRsVApDXh4aTHx+WR5TjGP7v+1RG djcA== X-Gm-Message-State: ANoB5plfNQDwbNuADfNkMX/Q1Cw7vnnJWj8v8KMgzHpPMkhulcwxLwUE pZK8q7CkcJNYmM93pXa4FGJAEecU86xQnH1w2Y6BSg== X-Google-Smtp-Source: AA0mqf7rYEZg0X5ct8WvgQlQepH0xO2ddeWLJ/U9eXDDUpUybtT+Gidz8gRXMfRuJhf1bDsJCgY4OkIFIvHR1swiyNI= X-Received: by 2002:a02:860e:0:b0:375:2c83:3f2f with SMTP id e14-20020a02860e000000b003752c833f2fmr636049jai.104.1668170756860; Fri, 11 Nov 2022 04:45:56 -0800 (PST) MIME-Version: 1.0 References: <20221110183853.3678209-1-jagan@amarulasolutions.com> <20221110183853.3678209-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 11 Nov 2022 18:15:45 +0530 Message-ID: Subject: Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags To: Nicolas Boichat Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Laurent Pinchart , Andrzej Hajda , Fancy Fang , Marek Szyprowski , Marek Vasut , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Neil Armstrong , Frieder Schrempf , Tommaso Merciai , NXP Linux Team , Michael Nazzareno Trimarchi , Matteo Lisi , Adam Ford , linux-arm-kernel@lists.infradead.org, Seung-Woo Kim , Robert Foss , Kyungmin Park , =?UTF-8?Q?S=C3=A9bastien_Szymanski?= , linux-amarula Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 11, 2022 at 5:42 PM Nicolas Boichat wro= te: > > On Fri, Nov 11, 2022 at 4:49 PM Jagan Teki w= rote: > > > > On Fri, Nov 11, 2022 at 6:19 AM Nicolas Boichat = wrote: > > > > > > On Fri, Nov 11, 2022 at 2:40 AM Jagan Teki wrote: > > > > > > > > HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies > > > > 0 =3D Enable and 1 =3D Disable. > > > > > > Oh I see, that's confusing... IMHO you might want to change the > > > register macro name... (but if that's what the datasheet uses, it > > > might not be ideal either). At the _very_ least, I'd add a comment in > > > the code so the next person doesn't attempt to "fix" it again... > > > > 02/14 on the same series doing the name change. > > https://lore.kernel.org/all/20221110183853.3678209-3-jagan@amarulasolut= ions.com/ > > Oh thanks I wasn't cc'ed on that one, makes sense. > > You can add my reviewed tag to this one, as my HSE comment doesn't change= this. > > Reviewed-by: Nicolas Boichat > > But please double check HSE. > > > > > > > > > BTW, are you sure DSIM_HSE_MODE is correct now? > > > > Yes, we have tested in imx8m platforms as well. S=C3=A9bastien Szymansk= i > > initially observed this issue on the imx8m platform. > > I'll repeat, are you sure about HSE specifically? You invert the > polarity for HBP, HFP, and HSA, which makes sense given your patch > 02/14. > > I'm concerned about HSE. Is the bit really a disable bit? > MIPI_DSI_MODE_VIDEO_HSE is supposed to be an enable flag, so you > should not do `reg |=3D DSIM_HSE_DISABLE;`, probably. HSE typically enables bit logic, unlike other bits which are disabled bits. HseDisableMod: In Vsync pulse and Vporch area, MIPI DSI master transfers only Hsync start packet to MIPI DSI slave at MIPI DSI spec 1.1r02. This bit transfers Hsync end packet in Vsync pulse and Vporch area (optional). 0 =3D Disables transfer 1 =3D Enables transfer HfpDisableMode: Specifies HFP disable mode. If this bit set, DSI master ignores HFP area in Video mode. 0 =3D Enables 1 =3D Disables I think the naming of 'HseDisableMod' is misleading in the datasheet, but I have used it as per the spec. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D37BC4332F for ; Fri, 11 Nov 2022 12:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232609AbiKKMqA (ORCPT ); Fri, 11 Nov 2022 07:46:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231615AbiKKMp6 (ORCPT ); Fri, 11 Nov 2022 07:45:58 -0500 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7894819C0B for ; Fri, 11 Nov 2022 04:45:57 -0800 (PST) Received: by mail-io1-xd32.google.com with SMTP id 63so3461951iov.8 for ; Fri, 11 Nov 2022 04:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1xS4s0avgD255rcYtA4Gae74h0+wxtz39GOAv7A9upU=; b=ObGg9stT9HoCf/3hi1Z8le25KXMunJrziAtRLVbUrZC4OS5ZtiDcTMHcaGRON8E8GL f70DgnO7ZlPPXUeY1riLAsY4ZhsJ37ghiVyGrL3GrcSv6n+V+1vU8ZIskBXu6uGBlifV uuHw2MHM12kOhnHVUcPa9b4kVnHlJ3/egwDuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1xS4s0avgD255rcYtA4Gae74h0+wxtz39GOAv7A9upU=; b=t5p7+e3nIixRSaJnC1xHmLf8ZqFcvtQ868KjOGwqez17JxZmZbRH4rVGRSqsViPtJ8 3zJT3GPgFCZmwj00N90XyIEOf+26UnVvXDUYYbl9+QVEgx+18h3jd6JT171bm/03JyoT e115zRXtTDQyC/6102w2fKwImatpwOTnz1PDQMZ1BCPXdPSkZuqSHhwimid5BKJrut+y KVlk+2jHuBOJpHHCdxJFwL+cdlGQNWCb2eKCaoV+pFZZUPr5YCgpseHEgdHzmMVK5+0x mi0V+uihnWJgIadaWZhlzTC5JySoaRuEiJk7wBLEA2DEuoNgdCYL2sKfpr8HQ8C92gem Ogaw== X-Gm-Message-State: ANoB5plyr9BCxvsS/BNt7d3/Hby4tA/ao0XQ1jOSj85yXqughZSDpSpw JHlg4PDil+pvdy162xUecvLTwsGyK4lSjRlYH3Nrxg== X-Google-Smtp-Source: AA0mqf7rYEZg0X5ct8WvgQlQepH0xO2ddeWLJ/U9eXDDUpUybtT+Gidz8gRXMfRuJhf1bDsJCgY4OkIFIvHR1swiyNI= X-Received: by 2002:a02:860e:0:b0:375:2c83:3f2f with SMTP id e14-20020a02860e000000b003752c833f2fmr636049jai.104.1668170756860; Fri, 11 Nov 2022 04:45:56 -0800 (PST) MIME-Version: 1.0 References: <20221110183853.3678209-1-jagan@amarulasolutions.com> <20221110183853.3678209-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 11 Nov 2022 18:15:45 +0530 Message-ID: Subject: Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags To: Nicolas Boichat Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , =?UTF-8?Q?S=C3=A9bastien_Szymanski?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, Nov 11, 2022 at 5:42 PM Nicolas Boichat wro= te: > > On Fri, Nov 11, 2022 at 4:49 PM Jagan Teki w= rote: > > > > On Fri, Nov 11, 2022 at 6:19 AM Nicolas Boichat = wrote: > > > > > > On Fri, Nov 11, 2022 at 2:40 AM Jagan Teki wrote: > > > > > > > > HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies > > > > 0 =3D Enable and 1 =3D Disable. > > > > > > Oh I see, that's confusing... IMHO you might want to change the > > > register macro name... (but if that's what the datasheet uses, it > > > might not be ideal either). At the _very_ least, I'd add a comment in > > > the code so the next person doesn't attempt to "fix" it again... > > > > 02/14 on the same series doing the name change. > > https://lore.kernel.org/all/20221110183853.3678209-3-jagan@amarulasolut= ions.com/ > > Oh thanks I wasn't cc'ed on that one, makes sense. > > You can add my reviewed tag to this one, as my HSE comment doesn't change= this. > > Reviewed-by: Nicolas Boichat > > But please double check HSE. > > > > > > > > > BTW, are you sure DSIM_HSE_MODE is correct now? > > > > Yes, we have tested in imx8m platforms as well. S=C3=A9bastien Szymansk= i > > initially observed this issue on the imx8m platform. > > I'll repeat, are you sure about HSE specifically? You invert the > polarity for HBP, HFP, and HSA, which makes sense given your patch > 02/14. > > I'm concerned about HSE. Is the bit really a disable bit? > MIPI_DSI_MODE_VIDEO_HSE is supposed to be an enable flag, so you > should not do `reg |=3D DSIM_HSE_DISABLE;`, probably. HSE typically enables bit logic, unlike other bits which are disabled bits. HseDisableMod: In Vsync pulse and Vporch area, MIPI DSI master transfers only Hsync start packet to MIPI DSI slave at MIPI DSI spec 1.1r02. This bit transfers Hsync end packet in Vsync pulse and Vporch area (optional). 0 =3D Disables transfer 1 =3D Enables transfer HfpDisableMode: Specifies HFP disable mode. If this bit set, DSI master ignores HFP area in Video mode. 0 =3D Enables 1 =3D Disables I think the naming of 'HseDisableMod' is misleading in the datasheet, but I have used it as per the spec. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7277EC4332F for ; Fri, 11 Nov 2022 12:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y88KDgEU6I0szSzxGOVyUN3+8HqG+gdOZ/hJjosOc4I=; b=Rl0lpVORxpFzjZ WZc8C3lH9EiMWZNxX5rkJEZN/d+tSvq2FubIXJbW5AMW7lZzeByqKeE+sQTi7jyHvxvZm6Cjyh3BY 0UH76DxikZqS4SDjxSra1mvWGkPp7LU0u6SDv1UKPHZwC/YE/A+8rkvhdN50CJRb+oEhggsbnonlz nL5H3d5mo6B9r/E/MGg4xi/6IPjeIuV6T2ojJBa5gzaF056mr3RRWnvOt1g3nQzreWzcw5SvCXd3b Gn8g2oaRVXVSpIutM9IrG2r0qZo5jOuMPdE7xnxrGmdow0PZ+kPHL6ACQVzrsNiXYwMS5rx5YqLVL JY5fhPlOqhrVPgfr0+Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otTQ9-00Fg36-2E; Fri, 11 Nov 2022 12:46:09 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otTPz-00Fg0w-4G for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 12:46:00 +0000 Received: by mail-io1-xd32.google.com with SMTP id r81so3490262iod.2 for ; Fri, 11 Nov 2022 04:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1xS4s0avgD255rcYtA4Gae74h0+wxtz39GOAv7A9upU=; b=ObGg9stT9HoCf/3hi1Z8le25KXMunJrziAtRLVbUrZC4OS5ZtiDcTMHcaGRON8E8GL f70DgnO7ZlPPXUeY1riLAsY4ZhsJ37ghiVyGrL3GrcSv6n+V+1vU8ZIskBXu6uGBlifV uuHw2MHM12kOhnHVUcPa9b4kVnHlJ3/egwDuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1xS4s0avgD255rcYtA4Gae74h0+wxtz39GOAv7A9upU=; b=Y3yD6g+KoWgsOA1YxWdCZStZLaLsRoSk5C0awALg+QpSMv9o9w3JI5qXaPg6eX8K67 RRgOAecJ0Z0F4ALlXN6ULYTuNjvaJzzy02oFCAVVyWbYrBD1m3unpENG8fpDBE11Cres KimRfuWo/KArx4VKdtc6wbrdXT+pxpHCYbzbD1+2XddVNCl1EIs9wollYoxoGLNMjTol gp7F5G4U/ldM7ESrfvu57TNqkoOlxIGPHQrz8utZ6M1Ukv49dUVt8mfFWiRC+WliY7/j hRPK8JVEhtvMnMEbjdGK2djYDKx8b7moLHzkbCdLDd3CBCJx1oDp9vexBBofvRwQoDmc BoPQ== X-Gm-Message-State: ANoB5pm1MAc2NhnVUxdzfbHzhn/4rO3jz9EwBNi3OLUHiT/xvc/LMPUF hxiopxuxsUGpRGQ6NNSR+TU+MK/gYE8PUcSKpYU6JQ== X-Google-Smtp-Source: AA0mqf7rYEZg0X5ct8WvgQlQepH0xO2ddeWLJ/U9eXDDUpUybtT+Gidz8gRXMfRuJhf1bDsJCgY4OkIFIvHR1swiyNI= X-Received: by 2002:a02:860e:0:b0:375:2c83:3f2f with SMTP id e14-20020a02860e000000b003752c833f2fmr636049jai.104.1668170756860; Fri, 11 Nov 2022 04:45:56 -0800 (PST) MIME-Version: 1.0 References: <20221110183853.3678209-1-jagan@amarulasolutions.com> <20221110183853.3678209-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Fri, 11 Nov 2022 18:15:45 +0530 Message-ID: Subject: Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags To: Nicolas Boichat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_044559_214375_EE2CE18D X-CRM114-Status: GOOD ( 23.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Laurent Pinchart , Andrzej Hajda , Fancy Fang , Marek Szyprowski , Marek Vasut , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Neil Armstrong , Frieder Schrempf , Tommaso Merciai , NXP Linux Team , Michael Nazzareno Trimarchi , Matteo Lisi , Tim Harvey , Inki Dae , Adam Ford , linux-arm-kernel@lists.infradead.org, Seung-Woo Kim , Robert Foss , Kyungmin Park , linux-amarula Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBOb3YgMTEsIDIwMjIgYXQgNTo0MiBQTSBOaWNvbGFzIEJvaWNoYXQgPGRyaW5rY2F0 QGNocm9taXVtLm9yZz4gd3JvdGU6Cj4KPiBPbiBGcmksIE5vdiAxMSwgMjAyMiBhdCA0OjQ5IFBN IEphZ2FuIFRla2kgPGphZ2FuQGFtYXJ1bGFzb2x1dGlvbnMuY29tPiB3cm90ZToKPiA+Cj4gPiBP biBGcmksIE5vdiAxMSwgMjAyMiBhdCA2OjE5IEFNIE5pY29sYXMgQm9pY2hhdCA8ZHJpbmtjYXRA Y2hyb21pdW0ub3JnPiB3cm90ZToKPiA+ID4KPiA+ID4gT24gRnJpLCBOb3YgMTEsIDIwMjIgYXQg Mjo0MCBBTSBKYWdhbiBUZWtpIDxqYWdhbkBhbWFydWxhc29sdXRpb25zLmNvbT4gd3JvdGU6Cj4g PiA+ID4KPiA+ID4gPiBIRlAvSEJQL0hTQS9FT1RfUEFDS0VUIG1vZGVzIGluIEV4eW5vcyBEU0kg aG9zdCBzcGVjaWZpZXMKPiA+ID4gPiAwID0gRW5hYmxlIGFuZCAxID0gRGlzYWJsZS4KPiA+ID4K PiA+ID4gT2ggSSBzZWUsIHRoYXQncyBjb25mdXNpbmcuLi4gSU1ITyB5b3UgbWlnaHQgd2FudCB0 byBjaGFuZ2UgdGhlCj4gPiA+IHJlZ2lzdGVyIG1hY3JvIG5hbWUuLi4gKGJ1dCBpZiB0aGF0J3Mg d2hhdCB0aGUgZGF0YXNoZWV0IHVzZXMsIGl0Cj4gPiA+IG1pZ2h0IG5vdCBiZSBpZGVhbCBlaXRo ZXIpLiBBdCB0aGUgX3ZlcnlfIGxlYXN0LCBJJ2QgYWRkIGEgY29tbWVudCBpbgo+ID4gPiB0aGUg Y29kZSBzbyB0aGUgbmV4dCBwZXJzb24gZG9lc24ndCBhdHRlbXB0IHRvICJmaXgiIGl0IGFnYWlu Li4uCj4gPgo+ID4gMDIvMTQgb24gdGhlIHNhbWUgc2VyaWVzIGRvaW5nIHRoZSBuYW1lIGNoYW5n ZS4KPiA+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIyMTExMDE4Mzg1My4zNjc4MjA5 LTMtamFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20vCj4KPiBPaCB0aGFua3MgSSB3YXNuJ3QgY2Mn ZWQgb24gdGhhdCBvbmUsIG1ha2VzIHNlbnNlLgo+Cj4gWW91IGNhbiBhZGQgbXkgcmV2aWV3ZWQg dGFnIHRvIHRoaXMgb25lLCBhcyBteSBIU0UgY29tbWVudCBkb2Vzbid0IGNoYW5nZSB0aGlzLgo+ Cj4gUmV2aWV3ZWQtYnk6IE5pY29sYXMgQm9pY2hhdCA8ZHJpbmtjYXRAY2hyb21pdW0ub3JnPgo+ Cj4gQnV0IHBsZWFzZSBkb3VibGUgY2hlY2sgSFNFLgo+Cj4gPgo+ID4gPgo+ID4gPiBCVFcsIGFy ZSB5b3Ugc3VyZSBEU0lNX0hTRV9NT0RFIGlzIGNvcnJlY3Qgbm93Pwo+ID4KPiA+IFllcywgd2Ug aGF2ZSB0ZXN0ZWQgaW4gaW14OG0gcGxhdGZvcm1zIGFzIHdlbGwuIFPDqWJhc3RpZW4gU3p5bWFu c2tpCj4gPiBpbml0aWFsbHkgb2JzZXJ2ZWQgdGhpcyBpc3N1ZSBvbiB0aGUgaW14OG0gcGxhdGZv cm0uCj4KPiBJJ2xsIHJlcGVhdCwgYXJlIHlvdSBzdXJlIGFib3V0IEhTRSBzcGVjaWZpY2FsbHk/ IFlvdSBpbnZlcnQgdGhlCj4gcG9sYXJpdHkgZm9yIEhCUCwgSEZQLCBhbmQgSFNBLCB3aGljaCBt YWtlcyBzZW5zZSBnaXZlbiB5b3VyIHBhdGNoCj4gMDIvMTQuCj4KPiBJJ20gY29uY2VybmVkIGFi b3V0IEhTRS4gSXMgdGhlIGJpdCByZWFsbHkgYSBkaXNhYmxlIGJpdD8KPiBNSVBJX0RTSV9NT0RF X1ZJREVPX0hTRSBpcyBzdXBwb3NlZCB0byBiZSBhbiBlbmFibGUgZmxhZywgc28geW91Cj4gc2hv dWxkIG5vdCBkbyBgcmVnIHw9IERTSU1fSFNFX0RJU0FCTEU7YCwgcHJvYmFibHkuCgpIU0UgdHlw aWNhbGx5IGVuYWJsZXMgYml0IGxvZ2ljLCB1bmxpa2Ugb3RoZXIgYml0cyB3aGljaCBhcmUgZGlz YWJsZWQgYml0cy4KCkhzZURpc2FibGVNb2Q6CkluIFZzeW5jIHB1bHNlIGFuZCBWcG9yY2ggYXJl YSwgTUlQSSBEU0kgbWFzdGVyIHRyYW5zZmVycyBvbmx5IEhzeW5jCnN0YXJ0IHBhY2tldCB0byBN SVBJIERTSSBzbGF2ZSBhdApNSVBJIERTSSBzcGVjIDEuMXIwMi4gVGhpcyBiaXQgdHJhbnNmZXJz IEhzeW5jIGVuZCBwYWNrZXQgaW4gVnN5bmMKcHVsc2UgYW5kIFZwb3JjaCBhcmVhIChvcHRpb25h bCkuCjAgPSBEaXNhYmxlcyB0cmFuc2ZlcgoxID0gRW5hYmxlcyB0cmFuc2ZlcgoKSGZwRGlzYWJs ZU1vZGU6ClNwZWNpZmllcyBIRlAgZGlzYWJsZSBtb2RlLiBJZiB0aGlzIGJpdCBzZXQsIERTSSBt YXN0ZXIgaWdub3JlcyBIRlAKYXJlYSBpbiBWaWRlbyBtb2RlLgowID0gRW5hYmxlcwoxID0gRGlz YWJsZXMKCkkgdGhpbmsgdGhlIG5hbWluZyBvZiAnSHNlRGlzYWJsZU1vZCcgaXMgbWlzbGVhZGlu ZyBpbiB0aGUgZGF0YXNoZWV0LApidXQgSSBoYXZlIHVzZWQgaXQgYXMgcGVyIHRoZSBzcGVjLgoK SmFnYW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==