From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH 12/15] include: rk3399: Disable watchdog in TPL Date: Mon, 26 Aug 2019 01:44:16 +0530 Message-ID: References: <20190729074711.16988-1-jagan@amarulasolutions.com> <20190729074711.16988-13-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Kever Yang Cc: "open list:ARM/Rockchip SoC..." , U-Boot-Denx , Akash Gajjar , linux-amarula List-Id: linux-rockchip.vger.kernel.org T24gTW9uLCBBdWcgNSwgMjAxOSBhdCA2OjEzIFBNIEtldmVyIFlhbmcgPGtldmVyLnlhbmdAcm9j ay1jaGlwcy5jb20+IHdyb3RlOgo+Cj4KPiBPbiAyMDE5LzcvMjkg5LiL5Y2IMzo0NywgSmFnYW4g VGVraSB3cm90ZToKPiA+IERpc2FibGUgd2F0Y2hkb2cgZm9yIFRQTCwgc2luY2UgdGhlcmUgaXMg bm8gc3VwcG9ydCBpdC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKYWdhbiBUZWtpIDxqYWdhbkBh bWFydWxhc29sdXRpb25zLmNvbT4KPiA+IC0tLQo+ID4gICBpbmNsdWRlL2NvbmZpZ3MvcmszMzk5 X2NvbW1vbi5oIHwgNSArKysrKwo+ID4gICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCsp Cj4gPgo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvY29uZmlncy9yazMzOTlfY29tbW9uLmggYi9p bmNsdWRlL2NvbmZpZ3MvcmszMzk5X2NvbW1vbi5oCj4gPiBpbmRleCA4ZGYwMTgwMjg0Li42N2I0 OGUwM2JhIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9jb25maWdzL3JrMzM5OV9jb21tb24uaAo+ ID4gKysrIGIvaW5jbHVkZS9jb25maWdzL3JrMzM5OV9jb21tb24uaAo+ID4gQEAgLTQ2LDYgKzQ2 LDExIEBACj4gPiAgICNkZWZpbmUgQ09ORklHX1NZU19TRFJBTV9CQVNFICAgICAgICAgICAgICAg MAo+ID4gICAjZGVmaW5lIFNEUkFNX01BWF9TSVpFICAgICAgICAgICAgICAgICAgICAgIDB4Zjgw MDAwMDAKPiA+Cj4gPiArI2lmZGVmIENPTkZJR19UUExfQlVJTEQKPiA+ICsjIHVuZGVmIENPTkZJ R19XRFQKPiA+ICsjIHVuZGVmIENPTkZJR19XQVRDSERPRwo+ID4gKyNlbmRpZgo+Cj4KPiBJdCB3 aWxsIGJlIGJldHRlciB0byB1c2UgQ09ORklHXyR7U1BMX1RQTH1XRFQgaW4gd2F0Y2hkb2cgTWFr ZWZpbGUsCj4KPiBiZWNhdXNlIGFsbCB0aGUgU29DIG5lZWRzIHRyZWF0IHRoaXMgZHJpdmVyIHNl cGFyYXRlIGluIFRQTC9TUEwvVS1Cb290Cj4gcHJvcGVyLgoKRW5hYmxpbmcgVFBMICh2aWEgRE0g b3Igc28pIGNhbm5vdCBiZSBhbiBvcHRpbWFsIHNvbHV0aW9ucyBhcyBvZiBub3csCnNpbmNlIGlm IGl0IGNvbnRpbnVvdXNseSByZXNldHRpbmcgd2UgbmVlZCB0byB0YWtlIGJvb3Qgc3dpdGNoIGJh c2VkCm9uIGJvb3Rjb3VudCwgaWUgcG9zc2libGUgd2l0aCBTUEwgYW5kIFUtQm9vdCBwcm9wZXIg bm93LiBNYWtpbmcgYQpib290IHN3aXRjaCB0byBUUEwgbWlnaHQgaW5jcmVhc2UgY29kZSBzaXpl LCBzbyB3aWxsIGNoZWNrIHRoaXMKZGVjaXNpb24gbGF0ZXIgYmFzZWQgb24gdGhlIHJlcXVpcmVt ZW50LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpVLUJv b3QgbWFpbGluZyBsaXN0ClUtQm9vdEBsaXN0cy5kZW54LmRlCmh0dHBzOi8vbGlzdHMuZGVueC5k ZS9saXN0aW5mby91LWJvb3QK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Mon, 26 Aug 2019 01:44:16 +0530 Subject: [U-Boot] [PATCH 12/15] include: rk3399: Disable watchdog in TPL In-Reply-To: References: <20190729074711.16988-1-jagan@amarulasolutions.com> <20190729074711.16988-13-jagan@amarulasolutions.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Mon, Aug 5, 2019 at 6:13 PM Kever Yang wrote: > > > On 2019/7/29 下午3:47, Jagan Teki wrote: > > Disable watchdog for TPL, since there is no support it. > > > > Signed-off-by: Jagan Teki > > --- > > include/configs/rk3399_common.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h > > index 8df0180284..67b48e03ba 100644 > > --- a/include/configs/rk3399_common.h > > +++ b/include/configs/rk3399_common.h > > @@ -46,6 +46,11 @@ > > #define CONFIG_SYS_SDRAM_BASE 0 > > #define SDRAM_MAX_SIZE 0xf8000000 > > > > +#ifdef CONFIG_TPL_BUILD > > +# undef CONFIG_WDT > > +# undef CONFIG_WATCHDOG > > +#endif > > > It will be better to use CONFIG_${SPL_TPL}WDT in watchdog Makefile, > > because all the SoC needs treat this driver separate in TPL/SPL/U-Boot > proper. Enabling TPL (via DM or so) cannot be an optimal solutions as of now, since if it continuously resetting we need to take boot switch based on bootcount, ie possible with SPL and U-Boot proper now. Making a boot switch to TPL might increase code size, so will check this decision later based on the requirement.