From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A10C43381 for ; Tue, 19 Mar 2019 07:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F32BC20989 for ; Tue, 19 Mar 2019 07:48:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="jFML4Hgk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbfCSHsf (ORCPT ); Tue, 19 Mar 2019 03:48:35 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:36458 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfCSHse (ORCPT ); Tue, 19 Mar 2019 03:48:34 -0400 Received: by mail-it1-f193.google.com with SMTP id h9so3330086itl.1 for ; Tue, 19 Mar 2019 00:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+xr/SOAxOJeQKx7fzIkY/QbRd/ireuzdXNkxy00mmQ=; b=jFML4HgkEkwOMNvHtm7ji3p51vOwO6uKXoGBk0r8ig/O/Sm1TtvluNX7fCjJjj9YRn Nyq8Js0Ab9tl2ZEaHM+vmc8f86FwLizix+FgFgUt8c5zPFz5gq45ULqhw3EDXucrwSyQ hKN4qFaULzAubwq1yavDSu2Oia6xbCHLqJ+ZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+xr/SOAxOJeQKx7fzIkY/QbRd/ireuzdXNkxy00mmQ=; b=JQk9DZmp4d5fw5Z9HlIVhMfna9BiqzsSA0TCJ07lRDORPFMHDS2Xk9u4MJ2SUIpPgm UpmDCNdyiSY/5wXSwFGjVumu8WuuTPWH82ok3sXtYveMQ1b2KGyJjedTE3MFWcI443pp mH010B3BPG1MmYt75It1fKe/yF9ybvq9fhT3Nlr0IMwxxuR8xrG51ptaz35DqyTp7C+f J+a3Nc6K1f8Czd2tR5AIP+TXwM5o4VrJ+LiJbjy7xSfo2oMN2L1xCkGENQK+eMAmvKG/ brFgX84BQFP4ww4o1vO4echo6KKOTQEw1KzNI3D4mebi6c1PwwJVIsPTdSV8ImzNvHX2 2Pcg== X-Gm-Message-State: APjAAAWr3yN9/n7ervCV3ekiOViT6wq4uXhR3YybG3TijMBG8uR+7ssf Q2oq7ipjUmnNiMFgQzbVVsv/dcI0yaFuAtK+U0W8LA== X-Google-Smtp-Source: APXvYqyb68UUVVNyi4p1YGb2ynJmkDsaofw4xmpWiajE+2dNzUY9v+BKcOX/KIp+Gz0HiLYofu/c2C0OiozRYPV1Hzs= X-Received: by 2002:a05:660c:252:: with SMTP id t18mr545368itk.173.1552981712770; Tue, 19 Mar 2019 00:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-5-jagan@amarulasolutions.com> <20190315133414.5zwc5qtrivrbrzow@flea> In-Reply-To: From: Jagan Teki Date: Tue, 19 Mar 2019 13:18:21 +0530 Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge To: Chen-Yu Tsai Cc: Maxime Ripard , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Michael Trimarchi , dri-devel , linux-kernel , devicetree , linux-arm-kernel , linux-sunxi , linux-amarula@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 8:29 AM Chen-Yu Tsai wrote: > > On Tue, Mar 19, 2019 at 12:58 AM Jagan Teki wrote: > > > > On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard wrote: > > > > > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > > It has a flexible configuration of MIPI DSI signal input > > > > and produce RGB565, RGB666, RGB888 output format. > > > > > > > > Add dt-bingings for it. > > > > > > > > Signed-off-by: Jagan Teki > > > > --- > > > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > > > 1 file changed, 36 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > new file mode 100644 > > > > index 000000000000..7f13efd7ee7f > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > @@ -0,0 +1,36 @@ > > > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > > > + > > > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > > +It has a flexible configuration of MIPI DSI signal input > > > > +and produce RGB565, RGB666, RGB888 output format. > > > > + > > > > +Required properties for RGB: > > > > +- compatible: must be "chipone,icn6211" and one of: > > > > + * "bananapi,icn6211" > > > > > > Why is that compatible needed? > > > > chipone,icn6211 - generic compatible bridge controller IC > > bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel > > > > I hope this would be proper bindings in terms of controller IC with > > associate device, anything wrong? Infact I used similar reference from > > Ilitek Bananapi panel from here > > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt > > > > This is what I understood based on dt-binding, correct if I'm wrong. > > > > ilitek,ili9881c - generic ilitek,ili9881c compatable > > bananapi,lhr050h41 - compatible for bananapi panel associated with > > this ilitek IC > > ili9881c is an LCD driver chip with a MIPI DSI interface. It directly > drives the LCD panel, not outputting some RGB stuff. So it is a binding > and driver for a panel, not a bridge in your case. > > > > > > > > +- reg: the virtual channel number of a DSI peripheral > > > > +- reset-gpios: a GPIO phandle for the reset pin > > > > + > > > > +The device node can contain following 'port' child nodes, > > > > +according to the OF graph bindings defined in [1]: > > > > + 0: DSI Input, not required, if the bridge is DSI controlled > > > > + 1: RGB Output, mandatory > > > > > > Your example doesn't have that input port > > > > Yes, I intentionally did this by referring existing bridge binding. > > Documentation/devicetree/bindings/display/bridge/toshiba,tc35876*.txt > > > > Do we really need? since the input port can be part of panel binding. > > How could the input port of _your_ _bridge_ be part of the panel binding? Here the panel is from another vendor say bananapi, so the binding of that part could be already covered ie is what I mean. Since I mentioned I took the reference binding from another bridge. It has similar structure of binding / example. arch/arm/boot/dts/exynos5250-arndale.dts Bridge example binding: Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt Panel example binding mentioned here Documentation/devicetree/bindings/display/panel/boe,hv070wsa-100.txt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [linux-sunxi] Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge Date: Tue, 19 Mar 2019 13:18:21 +0530 Message-ID: References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-5-jagan@amarulasolutions.com> <20190315133414.5zwc5qtrivrbrzow@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: Mark Rutland , devicetree , Maxime Ripard , David Airlie , linux-kernel , dri-devel , linux-sunxi , Rob Herring , Laurent Pinchart , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel List-Id: devicetree@vger.kernel.org T24gVHVlLCBNYXIgMTksIDIwMTkgYXQgODoyOSBBTSBDaGVuLVl1IFRzYWkgPHdlbnNAY3NpZS5v cmc+IHdyb3RlOgo+Cj4gT24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMTI6NTggQU0gSmFnYW4gVGVr aSA8amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgTWFy IDE1LCAyMDE5IGF0IDc6MDQgUE0gTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGlu LmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIEZyaSwgTWFyIDE1LCAyMDE5IGF0IDA2OjM4OjIz UE0gKzA1MzAsIEphZ2FuIFRla2kgd3JvdGU6Cj4gPiA+ID4gSUNONjIxMSBpcyBNSVBJLURTSS9S R0IgY29udmVydGVyIGJyaWRnZSBmcm9tIGNoaXBvbmUuCj4gPiA+ID4gSXQgaGFzIGEgZmxleGli bGUgY29uZmlndXJhdGlvbiBvZiBNSVBJIERTSSBzaWduYWwgaW5wdXQKPiA+ID4gPiBhbmQgcHJv ZHVjZSBSR0I1NjUsIFJHQjY2NiwgUkdCODg4IG91dHB1dCBmb3JtYXQuCj4gPiA+ID4KPiA+ID4g PiBBZGQgZHQtYmluZ2luZ3MgZm9yIGl0Lgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTog SmFnYW4gVGVraSA8amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+Cj4gPiA+ID4gLS0tCj4gPiA+ ID4gIC4uLi9kaXNwbGF5L2JyaWRnZS9jaGlwb25lLGljbjYyMTEudHh0ICAgICAgICB8IDM2ICsr KysrKysrKysrKysrKysrKysKPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlvbnMo KykKPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9jaGlwb25lLGljbjYyMTEudHh0Cj4gPiA+ID4KPiA+ID4g PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkv YnJpZGdlL2NoaXBvbmUsaWNuNjIxMS50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9icmlkZ2UvY2hpcG9uZSxpY242MjExLnR4dAo+ID4gPiA+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0Cj4gPiA+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi43ZjEzZWZkN2VlN2YKPiA+ ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2NoaXBvbmUsaWNuNjIxMS50eHQKPiA+ID4gPiBAQCAt MCwwICsxLDM2IEBACj4gPiA+ID4gK0NoaXBvbmUgSUNONjIxMSBNSVBJLURTSSB0byBSR0IgQ29u dmVydG9yIEJyaWRnZQo+ID4gPiA+ICsKPiA+ID4gPiArSUNONjIxMSBpcyBNSVBJLURTSS9SR0Ig Y29udmVydGVyIGJyaWRnZSBmcm9tIGNoaXBvbmUuCj4gPiA+ID4gK0l0IGhhcyBhIGZsZXhpYmxl IGNvbmZpZ3VyYXRpb24gb2YgTUlQSSBEU0kgc2lnbmFsIGlucHV0Cj4gPiA+ID4gK2FuZCBwcm9k dWNlIFJHQjU2NSwgUkdCNjY2LCBSR0I4ODggb3V0cHV0IGZvcm1hdC4KPiA+ID4gPiArCj4gPiA+ ID4gK1JlcXVpcmVkIHByb3BlcnRpZXMgZm9yIFJHQjoKPiA+ID4gPiArLSBjb21wYXRpYmxlOiBt dXN0IGJlICJjaGlwb25lLGljbjYyMTEiIGFuZCBvbmUgb2Y6Cj4gPiA+ID4gKyAgKiAiYmFuYW5h cGksaWNuNjIxMSIKPiA+ID4KPiA+ID4gV2h5IGlzIHRoYXQgY29tcGF0aWJsZSBuZWVkZWQ/Cj4g Pgo+ID4gY2hpcG9uZSxpY242MjExIC0gZ2VuZXJpYyBjb21wYXRpYmxlIGJyaWRnZSBjb250cm9s bGVyIElDCj4gPiBiYW5hbmFwaSxpY242MjExIC0gIGNvbXBhdGlibGUgZm9yIGljbjYyMTEgYnJp ZGdlIHVzaW5nIG9uIGJhbmFuYXBpIHBhbmVsCj4gPgo+ID4gSSBob3BlIHRoaXMgd291bGQgYmUg cHJvcGVyIGJpbmRpbmdzIGluIHRlcm1zIG9mIGNvbnRyb2xsZXIgSUMgd2l0aAo+ID4gYXNzb2Np YXRlIGRldmljZSwgYW55dGhpbmcgd3Jvbmc/IEluZmFjdCBJIHVzZWQgc2ltaWxhciByZWZlcmVu Y2UgZnJvbQo+ID4gSWxpdGVrIEJhbmFuYXBpIHBhbmVsIGZyb20gaGVyZQo+ID4gRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvaWxpdGVrLGlsaTk4ODFjLnR4 dAo+ID4KPiA+IFRoaXMgaXMgd2hhdCBJIHVuZGVyc3Rvb2QgYmFzZWQgb24gZHQtYmluZGluZywg Y29ycmVjdCBpZiBJJ20gd3JvbmcuCj4gPgo+ID4gaWxpdGVrLGlsaTk4ODFjIC0gZ2VuZXJpYyBp bGl0ZWssaWxpOTg4MWMgY29tcGF0YWJsZQo+ID4gYmFuYW5hcGksbGhyMDUwaDQxIC0gY29tcGF0 aWJsZSBmb3IgYmFuYW5hcGkgcGFuZWwgYXNzb2NpYXRlZCB3aXRoCj4gPiB0aGlzIGlsaXRlayBJ Qwo+Cj4gaWxpOTg4MWMgaXMgYW4gTENEIGRyaXZlciBjaGlwIHdpdGggYSBNSVBJIERTSSBpbnRl cmZhY2UuIEl0IGRpcmVjdGx5Cj4gZHJpdmVzIHRoZSBMQ0QgcGFuZWwsIG5vdCBvdXRwdXR0aW5n IHNvbWUgUkdCIHN0dWZmLiBTbyBpdCBpcyBhIGJpbmRpbmcKPiBhbmQgZHJpdmVyIGZvciBhIHBh bmVsLCBub3QgYSBicmlkZ2UgaW4geW91ciBjYXNlLgo+Cj4gPiA+Cj4gPiA+ID4gKy0gcmVnOiB0 aGUgdmlydHVhbCBjaGFubmVsIG51bWJlciBvZiBhIERTSSBwZXJpcGhlcmFsCj4gPiA+ID4gKy0g cmVzZXQtZ3Bpb3M6IGEgR1BJTyBwaGFuZGxlIGZvciB0aGUgcmVzZXQgcGluCj4gPiA+ID4gKwo+ ID4gPiA+ICtUaGUgZGV2aWNlIG5vZGUgY2FuIGNvbnRhaW4gZm9sbG93aW5nICdwb3J0JyBjaGls ZCBub2RlcywKPiA+ID4gPiArYWNjb3JkaW5nIHRvIHRoZSBPRiBncmFwaCBiaW5kaW5ncyBkZWZp bmVkIGluIFsxXToKPiA+ID4gPiArICAwOiBEU0kgSW5wdXQsIG5vdCByZXF1aXJlZCwgaWYgdGhl IGJyaWRnZSBpcyBEU0kgY29udHJvbGxlZAo+ID4gPiA+ICsgIDE6IFJHQiBPdXRwdXQsIG1hbmRh dG9yeQo+ID4gPgo+ID4gPiBZb3VyIGV4YW1wbGUgZG9lc24ndCBoYXZlIHRoYXQgaW5wdXQgcG9y dAo+ID4KPiA+IFllcywgSSBpbnRlbnRpb25hbGx5IGRpZCB0aGlzIGJ5IHJlZmVycmluZyBleGlz dGluZyBicmlkZ2UgYmluZGluZy4KPiA+IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9kaXNwbGF5L2JyaWRnZS90b3NoaWJhLHRjMzU4NzYqLnR4dAo+ID4KPiA+IERvIHdlIHJlYWxs eSBuZWVkPyBzaW5jZSB0aGUgaW5wdXQgcG9ydCBjYW4gYmUgcGFydCBvZiBwYW5lbCBiaW5kaW5n Lgo+Cj4gSG93IGNvdWxkIHRoZSBpbnB1dCBwb3J0IG9mIF95b3VyXyBfYnJpZGdlXyBiZSBwYXJ0 IG9mIHRoZSBwYW5lbCBiaW5kaW5nPwoKSGVyZSB0aGUgcGFuZWwgaXMgZnJvbSBhbm90aGVyIHZl bmRvciBzYXkgYmFuYW5hcGksIHNvIHRoZSBiaW5kaW5nIG9mCnRoYXQgcGFydCBjb3VsZCBiZSBh bHJlYWR5IGNvdmVyZWQgaWUgaXMgd2hhdCBJIG1lYW4uCgpTaW5jZSBJIG1lbnRpb25lZCBJIHRv b2sgdGhlIHJlZmVyZW5jZSBiaW5kaW5nIGZyb20gYW5vdGhlciBicmlkZ2UuIEl0CmhhcyBzaW1p bGFyIHN0cnVjdHVyZSBvZiBiaW5kaW5nIC8gZXhhbXBsZS4KYXJjaC9hcm0vYm9vdC9kdHMvZXh5 bm9zNTI1MC1hcm5kYWxlLmR0cwpCcmlkZ2UgZXhhbXBsZSBiaW5kaW5nOgpEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdG9zaGliYSx0YzM1ODc2NC50eHQK UGFuZWwgZXhhbXBsZSBiaW5kaW5nIG1lbnRpb25lZCBoZXJlCkRvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2JvZSxodjA3MHdzYS0xMDAudHh0Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21764C43381 for ; Tue, 19 Mar 2019 07:48:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E766620989 for ; Tue, 19 Mar 2019 07:48:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NJUJs9cQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="jFML4Hgk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E766620989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ut97YfHyNyGsHKL28KtDyUIJVrMh2AWl6Ql4SFz5twU=; b=NJUJs9cQa64yZr s5iFxiRsrEouhj+Ty1iRW8/ofqptrb1sT3U/LT97aUXV8shscjYw+P+ueeKdK7WHdXDQxFCEMEBla 0bNrLxg9CK9tUDgoyajrKq2N2n1eOtMMPWLENReGomcjOdkDLAnFhqXc1SuUQ+oKsOz31UvpFLY3a aUyS1QBjXT7YCEcnfuQfEV+6v5ItstaRCDoL6nmdV3Zl23Yz6GFQuDiE/ZSjk/sEBpvy6Jtvkc2F4 H+IZf6z1lT2tnY+mUhgHZ5hNfr0jO0Hg0cYlt+muhy0xqtVPeWtzoQSLQ9tLTX0g7pUSEAZCvW53u bQXyHANdpzqXzAFXt3qQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h69UE-0001tL-VU; Tue, 19 Mar 2019 07:48:38 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h69UB-0001sl-7p for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 07:48:37 +0000 Received: by mail-it1-x142.google.com with SMTP id l139so25500918ita.5 for ; Tue, 19 Mar 2019 00:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+xr/SOAxOJeQKx7fzIkY/QbRd/ireuzdXNkxy00mmQ=; b=jFML4HgkEkwOMNvHtm7ji3p51vOwO6uKXoGBk0r8ig/O/Sm1TtvluNX7fCjJjj9YRn Nyq8Js0Ab9tl2ZEaHM+vmc8f86FwLizix+FgFgUt8c5zPFz5gq45ULqhw3EDXucrwSyQ hKN4qFaULzAubwq1yavDSu2Oia6xbCHLqJ+ZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+xr/SOAxOJeQKx7fzIkY/QbRd/ireuzdXNkxy00mmQ=; b=GJcC4oJig7NT6ECGlh2I7NHOk9y4J1g3CpZ3i1kwx5JivwdfR1S+8B1XZY4M3RK0r+ ENhfbOWbP/XAeB0tt/mDzzsRu+t5KgHGfFQXt0IijSirtc3R4ZOvZyT75zZxcsB3e13Z xzcz6CtCalBYIkeIXcF1/R7HVpBNiYTS0+WAOvk0fIyld93nhT3OFjjxFGlEIGpypN/u z2egPDpbhv5rw5vdU1FRdw4MzpUP1gzOf2s/9jWj6yBxzm6khYMStykUJQ83ofoZZEDv Wo5EnrzTmh9rUOc0zyGu6zSJ89TC6a8B1UiJTCtFJuuPLZ/JJXM7QoKTwfry32LYSv1s lXXg== X-Gm-Message-State: APjAAAUfzstAt3InPglBypVyPfdAky83NAoZ0TRWPJxtVRaMSVL4Q1bV ou+//gI2ZzZujTKwJkH1Ljb9cFLYLqYOWJD9XtA8Rg== X-Google-Smtp-Source: APXvYqyb68UUVVNyi4p1YGb2ynJmkDsaofw4xmpWiajE+2dNzUY9v+BKcOX/KIp+Gz0HiLYofu/c2C0OiozRYPV1Hzs= X-Received: by 2002:a05:660c:252:: with SMTP id t18mr545368itk.173.1552981712770; Tue, 19 Mar 2019 00:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-5-jagan@amarulasolutions.com> <20190315133414.5zwc5qtrivrbrzow@flea> In-Reply-To: From: Jagan Teki Date: Tue, 19 Mar 2019 13:18:21 +0530 Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge To: Chen-Yu Tsai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_004835_772101_9745CB8B X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Maxime Ripard , David Airlie , linux-kernel , dri-devel , Andrzej Hajda , linux-sunxi , Rob Herring , Laurent Pinchart , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2019 at 8:29 AM Chen-Yu Tsai wrote: > > On Tue, Mar 19, 2019 at 12:58 AM Jagan Teki wrote: > > > > On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard wrote: > > > > > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > > It has a flexible configuration of MIPI DSI signal input > > > > and produce RGB565, RGB666, RGB888 output format. > > > > > > > > Add dt-bingings for it. > > > > > > > > Signed-off-by: Jagan Teki > > > > --- > > > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > > > 1 file changed, 36 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > new file mode 100644 > > > > index 000000000000..7f13efd7ee7f > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > @@ -0,0 +1,36 @@ > > > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > > > + > > > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > > +It has a flexible configuration of MIPI DSI signal input > > > > +and produce RGB565, RGB666, RGB888 output format. > > > > + > > > > +Required properties for RGB: > > > > +- compatible: must be "chipone,icn6211" and one of: > > > > + * "bananapi,icn6211" > > > > > > Why is that compatible needed? > > > > chipone,icn6211 - generic compatible bridge controller IC > > bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel > > > > I hope this would be proper bindings in terms of controller IC with > > associate device, anything wrong? Infact I used similar reference from > > Ilitek Bananapi panel from here > > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt > > > > This is what I understood based on dt-binding, correct if I'm wrong. > > > > ilitek,ili9881c - generic ilitek,ili9881c compatable > > bananapi,lhr050h41 - compatible for bananapi panel associated with > > this ilitek IC > > ili9881c is an LCD driver chip with a MIPI DSI interface. It directly > drives the LCD panel, not outputting some RGB stuff. So it is a binding > and driver for a panel, not a bridge in your case. > > > > > > > > +- reg: the virtual channel number of a DSI peripheral > > > > +- reset-gpios: a GPIO phandle for the reset pin > > > > + > > > > +The device node can contain following 'port' child nodes, > > > > +according to the OF graph bindings defined in [1]: > > > > + 0: DSI Input, not required, if the bridge is DSI controlled > > > > + 1: RGB Output, mandatory > > > > > > Your example doesn't have that input port > > > > Yes, I intentionally did this by referring existing bridge binding. > > Documentation/devicetree/bindings/display/bridge/toshiba,tc35876*.txt > > > > Do we really need? since the input port can be part of panel binding. > > How could the input port of _your_ _bridge_ be part of the panel binding? Here the panel is from another vendor say bananapi, so the binding of that part could be already covered ie is what I mean. Since I mentioned I took the reference binding from another bridge. It has similar structure of binding / example. arch/arm/boot/dts/exynos5250-arndale.dts Bridge example binding: Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt Panel example binding mentioned here Documentation/devicetree/bindings/display/panel/boe,hv070wsa-100.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel