From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD741C43381 for ; Tue, 19 Feb 2019 08:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 673D221903 for ; Tue, 19 Feb 2019 08:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="q+BZ+2Zx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbfBSIp1 (ORCPT ); Tue, 19 Feb 2019 03:45:27 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:36359 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727011AbfBSIp1 (ORCPT ); Tue, 19 Feb 2019 03:45:27 -0500 Received: by mail-it1-f196.google.com with SMTP id h6so4399165itl.1 for ; Tue, 19 Feb 2019 00:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Tc8CQGbFy9+Ale7tXGzBY1Nuks7rjjNOdLvOBlxEHI=; b=q+BZ+2ZxT3H1m1p+9rUtK/Eorj+iS/DUQ7s2ZLgl7juAO7Xu0iqCYV63hJ+k93p0VB xJJxOINtFZSC8qzkJUf+xYlzJdWmVHtMmNYJVET6xA79q6zCN84rM1W7KW/vgiAcv6bw 2ujdygyMqWhonraxfu1VtvFBPaGup8yg9v8hE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Tc8CQGbFy9+Ale7tXGzBY1Nuks7rjjNOdLvOBlxEHI=; b=q+L40WwFNHtzXsAV/5DpMXiaIEGbw2iwDBcdwEva58XgK+1se+L60TCW2rDQtIzzTD eQgPu4Jps5GDqt66AHVzcY6RwcdXn+AsWS419z52z2ftpSnb3nfuBhiW7GOya1rajgD+ ZnZD6hJmocMnDoGrlZSlOiFxjyfeBew1KIGEY3aUL24FegQc+OVJJ+2i5QzfxXOwRXG0 P0w3b3q7vpCcIGvZ2rrfG7NwzteQCldvjjjDfiFwrSq13RkKUgHOHXfDA+aViU3ZvKs6 S+t+NvkF6mxmB9xsh0SasPBh5wNnQHuDDlEykO0a76Es+uGwNjcpTGvOpIv8FQ4PqTIk slyA== X-Gm-Message-State: AHQUAuZDNzwjkbiYQeRFlASppq1BZym+EkgzTXfwuheRfiyfetDkJTur tN7PpW934bsBpJWgKZHE2C6QvAdvJTpVEei1xyV5Mw== X-Google-Smtp-Source: AHgI3IYmHWhiy6Dy2DpeB/1hgyhMP9QlqCfj8Q0fv6kISSlKJlOm5fJN1Zr0UPs+ePBb/2BUt5cc/RSCYM5Xr+iS5B0= X-Received: by 2002:a5d:97c8:: with SMTP id k8mr17473181ios.267.1550565925650; Tue, 19 Feb 2019 00:45:25 -0800 (PST) MIME-Version: 1.0 References: <20190218071207.GE242714@dtor-ws> <20190219081510.GB65896@dtor-ws> In-Reply-To: <20190219081510.GB65896@dtor-ws> From: Jagan Teki Date: Tue, 19 Feb 2019 14:15:14 +0530 Message-ID: Subject: Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property To: Dmitry Torokhov Cc: Rob Herring , devicetree , Chen-Yu Tsai , linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , Michael Trimarchi , linux-amarula@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 1:45 PM Dmitry Torokhov wrote: > > On Tue, Feb 19, 2019 at 01:00:19AM +0530, Jagan Teki wrote: > > On Mon, Feb 18, 2019 at 3:03 PM Jagan Teki wrote: > > > > > > Hi Dmitry, > > > > > > On Mon, Feb 18, 2019 at 12:42 PM Dmitry Torokhov > > > wrote: > > > > > > > > On Sun, Feb 17, 2019 at 02:45:52PM +0530, Jagan Teki wrote: > > > > > On Sun, Feb 17, 2019 at 1:21 PM Jagan Teki wrote: > > > > > > > > > > > > Hi Dmitry and Rob, > > > > > > > > > > > > On Thu, Feb 14, 2019 at 3:21 AM Rob Herring wrote: > > > > > > > > > > > > > > On Tue, Jan 22, 2019 at 7:39 AM Jagan Teki wrote: > > > > > > > > > > > > > > > > On Mon, Jan 21, 2019 at 9:46 PM Rob Herring wrote: > > > > > > > > > > > > > > > > > > On Fri, Jan 18, 2019 at 10:01 AM Jagan Teki wrote: > > > > > > > > > > > > > > > > > > > > On Wed, Jan 9, 2019 at 7:08 PM Rob Herring wrote: > > > > > > > > > > > > > > > > > > > > > > Please CC DT list if you want bindings reviewed. > > > > > > > > > > > > > > > > > > > > Sorry I forgot. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Jan 9, 2019 at 1:40 AM Dmitry Torokhov > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Dec 15, 2018 at 08:47:59PM +0530, Jagan Teki wrote: > > > > > > > > > > > > > Most of the Goodix CTP controllers are supply with AVDD28 pin. > > > > > > > > > > > > > which need to supply for controllers like GT5663 on some boards > > > > > > > > > > > > > to trigger the power. > > > > > > > > > > > > > > > > > > > > > > > > > > So, document the supply property so-that the require boards > > > > > > > > > > > > > that used on GT5663 can enable it via device tree. > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > > > > > > > > > --- > > > > > > > > > > > > > Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + > > > > > > > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > > > > > > > > > > > > > index f7e95c52f3c7..c4622c983e08 100644 > > > > > > > > > > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > > > > > > > > > > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > > > > > > > > > > > > > @@ -23,6 +23,7 @@ Optional properties: > > > > > > > > > > > > > - touchscreen-inverted-y : Y axis is inverted (boolean) > > > > > > > > > > > > > - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) > > > > > > > > > > > > > (swapping is done after inverting the axis) > > > > > > > > > > > > > + - AVDD28-supply : Analog power supply regulator on AVDD28 pin > > > > > > > > > > > > > > > > > > > > > > > > I think we normally use lower case in DT bindings and rarely encode > > > > > > > > > > > > voltage in the supply name unless we are dealing with several supplies > > > > > > > > > > > > of the same kind, but I'll let Ron comment on this. > > > > > > > > > > > > > > > > > > > > > > Yes on lowercase though there are some exceptions. > > > > > > > > > > > > > > > > > > > > > > There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we > > > > > > > > > > > probably need to keep the voltage, but the binding is incomplete. > > > > > > > > > > > > > > > > > > > > What is incomplete here? can you please elaborate. > > > > > > > > > > > > > > > > > > You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO. > > > > > > > > > > > > > > > > Though it has other supplies, only AVDD28 is connected in the Host > > > > > > > > interface design similar like 9. Reference Schematic on Page, 23 in > > > > > > > > attached manual. > > > > > > > > > > > > > > That is for a particular board design. It still has other supplies. > > > > > > > Just make the binding complete please. You can make them optional. I > > > > > > > don't care if the driver supports controlling all the supplies or not > > > > > > > (though Dmitry might). > > > > > > > > > > > > So, Can I make bulk get and enable in all 4 regulators global to > > > > > > driver or specific to that chip, in either way the regulators which > > > > > > are not used to process via dummy regulators (which we all know). > > > > > > > > > > > > or regulator which are not using are get via devm_regulator_get_optional. > > > > > > > > > > > > Any suggestions? > > > > > > > > > > Just realized to go with bulk calls, please have a look at on v5 [1] > > > > > > > > I do not believe you can use bulk regulator API here as you need to > > > > implement the power up timing scheme mentioned on p. 12 of the spec you > > > > referenced earlier. And, because of that timing diagram, I believe if > > > > you want to control AVDD supply, you also have to control VDDIO supply > > > > as it has to be on only after enabling AVDD. > > > > > > AVDD here is AVDD28 it' is an out name of pin (mentioned in p. 23). So > > > the power scheme goes to enable AVDD28 and then VDDIO does that really > > > mean bulk of two regulators? > > > > The time between these two regulator operations is nearly 0, as per > > power scheme diagram T1 >= 0us. I think I can use bulk since there is > > no necessity of delay between these two regulator operations. > > > > What do you think? > > Does the bulk enable provide any guarantees as to the order of > operations? If it does not then I think we should ensure that they are > powered up/down in the right order. At-least I can saw from the log, async enables based on the definition of supply arrays. Indeed the regulators with bulk calls enables based on the supply array order, this is what I usually think. [ 3.676483] Goodix-TS 1-005d: 1-005d supply VDDIO not found, using dummy regulator [ 3.693159] regulator_bulk_enable_async: Supply AVDD28 [ 3.693162] regulator_bulk_enable_async: Supply VDDIO [ 3.806095] Goodix-TS 1-005d: ID 5663, version: 0100 Do we need to go reverse order for power-down? I couldn't see this information on the datasheet. If yes then we need to go for normal calls.