From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH 00/92] ram: rk3399: Add LPDDR4 support Date: Thu, 13 Jun 2019 11:56:08 +0530 Message-ID: References: <20190611145135.21399-1-jagan@amarulasolutions.com> <349AB0AF-4DEE-4BC8-8FEF-B3DBD34564E4@theobroma-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Kever Yang Cc: YouMin Chen , U-Boot-Denx , Simon Glass , Akash Gajjar , "open list:ARM/Rockchip SoC..." , Philipp Tomsich , linux-amarula List-Id: linux-rockchip.vger.kernel.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgNzoyMSBBTSBLZXZlciBZYW5nIDxrZXZlci55YW5nQHJv Y2stY2hpcHMuY29tPiB3cm90ZToKPgo+IEhpIEphZ2FuLAo+Cj4KPiBPbiAwNi8xMS8yMDE5IDEx OjAzIFBNLCBKYWdhbiBUZWtpIHdyb3RlOgo+Cj4gTm90ZTogUHVtYSByazMzOTkgaGFzIFNQTCBz aXplIG92ZXJmbG93LCBiZXR0ZXIgdG8gZW5hYmxlIFRQTAo+IGZvciB0aGlzIGJvYXJkLgo+Cj4g V2UgbmVlZCB0byBrZWVwIFB1bWEgb24gYSBTUEwtb25seSBjb25maWd1cmF0aW9uIGZvciB0aGUg dGltZSBiZWluZy4KPiBQbGVhc2UgbWFrZSBzdXJlIHRoYXQgdGhlIExQRERSNCBjb2RlIGlzIGFu IG9wdGlvbmFsIGZlYXR1cmUgdGhhdCBkb2VzIG5vdAo+IGluY3JlYXNlIHRoZSBEUkFNLWRyaXZl ciBzaXplIGZvciBib2FyZHMgdGhhdCBkb27igJl0IG5lZWQvd2FudCBpdC4KPgo+IFdlIGhhdmUg ZmV3IGJvYXJkcyBkbyBoYXZlIFRQTC1ydW5uYWJsZSwgd291bGQgYmUgYW55IHRlY2huaWNhbCBp c3N1ZQo+IHRvIHN3aXRjaCBwdW1hIHRvIFRQTD8gYmVjYXVzZSB3ZSBoYXZlIGxwZGRyNCBjb2Rl IHBhcnQgb2YgZXhpc3RpbmcKPiBkcml2ZXIgaXRzZWxmIGFuZCBpdCByZXF1aXJlIGV4dHJhIGlm ZGVmIHRvIGNvbnNpZGVyIHdoaWNoIGluZGVlZCBsb29rCj4gYXdmdWwgZnJvbSBjb2RlIHBvaW50 LW9mLXZpZXcuCj4KPiBEb3NlIHRoZSBkcml2ZXIgc2l6ZSBpbmNyZWFzZSB0b28gbXVjaCBmb3Ig UHVtYSBiZWNhdXNlIG9mIHRoZSBscGRkcjQKPiBpbml0IGxvZ2ljIG9yIGJlY2F1c2Ugb2YgdGhl IHR3byBleHRyYSB0aW1pbmcgZGF0YT8gVGhlIHR3byB0aW1pbmcgZGF0YQo+IGFyZSBwcmV0dHkg YmlnLCBtYXliZSB3ZSBkbyBub3QgbmVlZCB0aGVtIGlmIHRoZSBib2FyZCBpcyBub3QgbHBkZHI0 PwoKWWVzLCBhbG9uZyB3aXRoIHRoZSBjb2RlIHRoYXQgc3VwcG9ydCBzZXQgcmF0ZSBmb3IgbHBk ZHI0LiBTdGlsbAp0aGlua2luZyBob3cgd2UgY2FuIG1hbmFnZSB0byBtYXJrIHRoZSBscGRkcjQg Y2hhbmdlcyBpbmRlcGVuZGVudCwKbWFya2luZyBpZmRlZiBpbiBhbGwgdGhlIGNvZGUgbG9vayBh d2Z1bC4gbGV0IG1lIGtub3cgaWYgeW91IGhhdmUgYW55CmlucHV0cz8KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcg bGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Thu, 13 Jun 2019 11:56:08 +0530 Subject: [U-Boot] [PATCH 00/92] ram: rk3399: Add LPDDR4 support In-Reply-To: References: <20190611145135.21399-1-jagan@amarulasolutions.com> <349AB0AF-4DEE-4BC8-8FEF-B3DBD34564E4@theobroma-systems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Thu, Jun 13, 2019 at 7:21 AM Kever Yang wrot= e: > > Hi Jagan, > > > On 06/11/2019 11:03 PM, Jagan Teki wrote: > > Note: Puma rk3399 has SPL size overflow, better to enable TPL > for this board. > > We need to keep Puma on a SPL-only configuration for the time being. > Please make sure that the LPDDR4 code is an optional feature that does not > increase the DRAM-driver size for boards that don=E2=80=99t need/want it. > > We have few boards do have TPL-runnable, would be any technical issue > to switch puma to TPL? because we have lpddr4 code part of existing > driver itself and it require extra ifdef to consider which indeed look > awful from code point-of-view. > > Dose the driver size increase too much for Puma because of the lpddr4 > init logic or because of the two extra timing data? The two timing data > are pretty big, maybe we do not need them if the board is not lpddr4? Yes, along with the code that support set rate for lpddr4. Still thinking how we can manage to mark the lpddr4 changes independent, marking ifdef in all the code look awful. let me know if you have any inputs?