From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AB5ECE587 for ; Mon, 14 Oct 2019 12:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AC1A20673 for ; Mon, 14 Oct 2019 12:08:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="gQEUAXsM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731849AbfJNMIE (ORCPT ); Mon, 14 Oct 2019 08:08:04 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:37752 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730314AbfJNMID (ORCPT ); Mon, 14 Oct 2019 08:08:03 -0400 Received: by mail-io1-f65.google.com with SMTP id b19so37400213iob.4 for ; Mon, 14 Oct 2019 05:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6crmpTwGnz+uFcnLN62tbtxngSexhL6XeYQRkm/JhoY=; b=gQEUAXsMwogpgVvZgUXndfP8Yx1YL+c7KNJMu+nO1RwHxW4SfBzwf+tTSjUdob83Lt 8bjCllxos6er4GVPWpid4x2QZH+CKRzOyTW+27zQjnfWvMatBzD0PFfILP+3UmKhPM8Z CoPSGPu5lzhnetQrfUKDbabRzqD5JKJCzT9Pw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6crmpTwGnz+uFcnLN62tbtxngSexhL6XeYQRkm/JhoY=; b=NPZ/3396773WomDLM9pnnD0VN1uYfTsEdUJz/GYch8Q+0GL31ULvunR3dJ0l2MAPCc 6E1Qv3tqmU6D5MS21E19d0rl9anNDllYYRL7MWb7of4ySojOaH7xotV+CxHimKC/MyGd cNE6Yfnzu8RGz7Sw5Wd+3XtYdv+ElDr5nkc/Cj3YQcO1wCEJe0TknjFCGvjyfy/VDBK6 Bq1ZPm/z5TEPGDPGd+X71uSQu2P7KcEKXiHuvSa6RI5D8st363IddONhDXdl19BfetsT SER8mUjgq7bJsxI8X6jV5ML4aAIV8q3yqK5kAVjQIGfRKFDMQAeZwejokA/FX+rUcR/i GjCg== X-Gm-Message-State: APjAAAVghDkwFg4icvBSpdBnA066vwTgRHV30N64JFa3wf7SXXbb2p36 h/I5rsKQZW0h1cU567TO4DYWxzphH6nlSX8SJUKR3A== X-Google-Smtp-Source: APXvYqxpgGP82G+0e/506RQFRNOo+V1cYmj86xwy/H75qzek0TZSuNPkcdhhBjRp/kGb802FWG6ooo62z42OJaaLFpU= X-Received: by 2002:a6b:37c6:: with SMTP id e189mr18175247ioa.61.1571054882584; Mon, 14 Oct 2019 05:08:02 -0700 (PDT) MIME-Version: 1.0 References: <20191005141913.22020-1-jagan@amarulasolutions.com> <20191005141913.22020-6-jagan@amarulasolutions.com> <20191007105708.raxavxk4n7bvxh7x@gilmour> In-Reply-To: <20191007105708.raxavxk4n7bvxh7x@gilmour> From: Jagan Teki Date: Mon, 14 Oct 2019 17:37:50 +0530 Message-ID: Subject: Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline To: Maxime Ripard Cc: Chen-Yu Tsai , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Michael Trimarchi , Icenowy Zheng , linux-sunxi , dri-devel , linux-arm-kernel , linux-kernel , devicetree Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 7, 2019 at 4:27 PM Maxime Ripard wrote: > > On Sat, Oct 05, 2019 at 07:49:12PM +0530, Jagan Teki wrote: > > Add MIPI DSI pipeline for Allwinner A64. > > > > - dsi node, with A64 compatible since it doesn't support > > DSI_SCLK gating unlike A33 > > - dphy node, with A64 compatible with A33 fallback since > > DPHY on A64 and A33 is similar > > - finally, attach the dsi_in to tcon0 for complete MIPI DSI > > > > Signed-off-by: Jagan Teki > > Tested-by: Merlijn Wajer > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > index 69128a6dfc46..ad4170b8aee0 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -382,6 +382,12 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <1>; > > + > > + tcon0_out_dsi: endpoint@1 { > > + reg = <1>; > > + remote-endpoint = <&dsi_in_tcon0>; > > + allwinner,tcon-channel = <1>; > > + }; > > }; > > }; > > }; > > @@ -1003,6 +1009,38 @@ > > status = "disabled"; > > }; > > > > + dsi: dsi@1ca0000 { > > + compatible = "allwinner,sun50i-a64-mipi-dsi"; > > + reg = <0x01ca0000 0x1000>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_MIPI_DSI>; > > + clock-names = "bus"; > > This won't validate with the bindings you have either here, since it > still expects bus and mod. > > I guess in that cas, we can just drop clock-names, which will require > a bit of work on the driver side as well. Okay. mod clock is not required for a64, ie reason we have has_mod_clk quirk patch. Adjust the clock-names: on dt-bindings would make sense here, what do you think? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4F8C4CECE for ; Mon, 14 Oct 2019 12:08:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EFA520673 for ; Mon, 14 Oct 2019 12:08:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M6Y6E+ly"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="gQEUAXsM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EFA520673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=htnhyIt3GJQn9rz3q2cPj1f8gWTMlBX5fwY1QWhOzgI=; b=M6Y6E+lyKlf4lK sQ6PKQZQ4MvXJAZShHeu9yADdgI5A0YIiuWCMwlt5JxdXsCx7KqFKoQfzKZQJpXk/MuZdl0Ru//LB JbN41sTvAEIYv+ToXMhnVsuT98gI3khEw+5nhJo/iKsWpJm+cNqxo3Y+isGS67XHpVIJKJPl1QkUG Pc3buFbiIYnii2uayXmyplYM1yt7U5EmicxSCaR2O0OPd220X043JkwR2EtEb/7CC4uOWdABDW40E zWKVI8cGsu6DhnYgwNgBafHtrP6r3rtCHOO9EBPGu6ZTxTFvsRlJYC2lXhI3daF2d84mIrKWL+YYi 76f+WP12BrFP6WALkmag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJz93-0006Ur-O1; Mon, 14 Oct 2019 12:08:13 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJz8u-0006Nj-2S for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2019 12:08:06 +0000 Received: by mail-io1-xd41.google.com with SMTP id c6so37224432ioo.13 for ; Mon, 14 Oct 2019 05:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6crmpTwGnz+uFcnLN62tbtxngSexhL6XeYQRkm/JhoY=; b=gQEUAXsMwogpgVvZgUXndfP8Yx1YL+c7KNJMu+nO1RwHxW4SfBzwf+tTSjUdob83Lt 8bjCllxos6er4GVPWpid4x2QZH+CKRzOyTW+27zQjnfWvMatBzD0PFfILP+3UmKhPM8Z CoPSGPu5lzhnetQrfUKDbabRzqD5JKJCzT9Pw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6crmpTwGnz+uFcnLN62tbtxngSexhL6XeYQRkm/JhoY=; b=Aol2EyH4pfOElyu4/jVlQVXQqvOT1HgZb98DZWLLbBtRP9GdlxEbq+KS5y/bHiXaLB 137JICisQ2W3wsXMLKKHpDlQSqdsFWk8p4xcWMsfqxHqgQlHQNjhgYQALHxoacMA/y+1 yZFlNgGtzkKk4gNVj1FavO6ElYQMl6gR9w7rXb82tSFxTqd2HqlFTs1/82oIrN+zb8ZE 9L391KEUxh5syZwdZ0dETIbn/xTg+5+Kg2HHB2t+UygJPP+uCChIx6QV3TKfbcrYaIp5 s79CQ/qHWAsja9bAY00lTZkQZioY7lNoeSNCad3vF77Ynwn7yfbYbhPLjFHE9B5IRMxA ytcw== X-Gm-Message-State: APjAAAUdgSFtUBaPoLn2pOf8xuaZBOv/056ZHpHpz9Sig0uRn1taVNmi kAKG8C+vK6EH9MLe6l6Du1uYzFrLQr08iG+vYMbXUw== X-Google-Smtp-Source: APXvYqxpgGP82G+0e/506RQFRNOo+V1cYmj86xwy/H75qzek0TZSuNPkcdhhBjRp/kGb802FWG6ooo62z42OJaaLFpU= X-Received: by 2002:a6b:37c6:: with SMTP id e189mr18175247ioa.61.1571054882584; Mon, 14 Oct 2019 05:08:02 -0700 (PDT) MIME-Version: 1.0 References: <20191005141913.22020-1-jagan@amarulasolutions.com> <20191005141913.22020-6-jagan@amarulasolutions.com> <20191007105708.raxavxk4n7bvxh7x@gilmour> In-Reply-To: <20191007105708.raxavxk4n7bvxh7x@gilmour> From: Jagan Teki Date: Mon, 14 Oct 2019 17:37:50 +0530 Message-ID: Subject: Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_050804_284951_DDA45BEE X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , David Airlie , linux-sunxi , dri-devel , linux-kernel , Chen-Yu Tsai , Rob Herring , Daniel Vetter , Michael Trimarchi , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 7, 2019 at 4:27 PM Maxime Ripard wrote: > > On Sat, Oct 05, 2019 at 07:49:12PM +0530, Jagan Teki wrote: > > Add MIPI DSI pipeline for Allwinner A64. > > > > - dsi node, with A64 compatible since it doesn't support > > DSI_SCLK gating unlike A33 > > - dphy node, with A64 compatible with A33 fallback since > > DPHY on A64 and A33 is similar > > - finally, attach the dsi_in to tcon0 for complete MIPI DSI > > > > Signed-off-by: Jagan Teki > > Tested-by: Merlijn Wajer > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > index 69128a6dfc46..ad4170b8aee0 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -382,6 +382,12 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <1>; > > + > > + tcon0_out_dsi: endpoint@1 { > > + reg = <1>; > > + remote-endpoint = <&dsi_in_tcon0>; > > + allwinner,tcon-channel = <1>; > > + }; > > }; > > }; > > }; > > @@ -1003,6 +1009,38 @@ > > status = "disabled"; > > }; > > > > + dsi: dsi@1ca0000 { > > + compatible = "allwinner,sun50i-a64-mipi-dsi"; > > + reg = <0x01ca0000 0x1000>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_MIPI_DSI>; > > + clock-names = "bus"; > > This won't validate with the bindings you have either here, since it > still expects bus and mod. > > I guess in that cas, we can just drop clock-names, which will require > a bit of work on the driver side as well. Okay. mod clock is not required for a64, ie reason we have has_mod_clk quirk patch. Adjust the clock-names: on dt-bindings would make sense here, what do you think? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel